kylefang/react-native-code-push
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-code-push.git synced 2026-06-11 08:04:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed app crash caused by multiple callback invocation from java code. (#1289)

Browse Source 
Added CodePushUtils.log method for logging exceptions.
This commit is contained in:
Nickolay Toropov
2018-05-24 13:52:59 +03:00
committed by Alexander Goncharov
parent 21f8388f6a
commit e0bc8b00d2
2 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
android/app/src/main/java/com/microsoft/codepush/react/CodePushDialog.java
View File

@@ -57,16 +57,20 @@ public class CodePushDialog extends ReactContextBaseJavaModule{
DialogInterface.OnClickListener clickListener = new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
dialog.cancel();
switch (which) {
case DialogInterface.BUTTON_POSITIVE:
successCallback.invoke(0);
break;
case DialogInterface.BUTTON_NEGATIVE:
successCallback.invoke(1);
break;
default:
throw new CodePushUnknownException("Unknown button ID pressed.");
try {
dialog.cancel();
switch (which) {
case DialogInterface.BUTTON_POSITIVE:
successCallback.invoke(0);
break;
case DialogInterface.BUTTON_NEGATIVE:
successCallback.invoke(1);
break;
default:
throw new CodePushUnknownException("Unknown button ID pressed.");
}
} catch (Throwable e) {
CodePushUtils.log(e);
}
}
};

4
android/app/src/main/java/com/microsoft/codepush/react/CodePushUtils.java
View File

@@ -203,6 +203,10 @@ public class CodePushUtils {
Log.d(CodePushConstants.REACT_NATIVE_LOG_TAG, "[CodePush] " + message);
}
public static void log(Throwable tr) {
Log.e(CodePushConstants.REACT_NATIVE_LOG_TAG, "[CodePush] Exception", tr);
}
public static void logBundleUrl(String path) {
log("Loading JS bundle from \"" + path + "\"");
}