kylefang/react-native-code-push
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-code-push.git synced 2026-05-19 11:34:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update the debug message for missing bundles (#923)

Browse Source 
* Update the debug message in CodePush.m for missing bundles

* Update text for updated RN PR

* Add a real example of what to add to the script
This commit is contained in:
Kevin Cooper
2017-09-07 10:03:10 -04:00
committed by Max
parent d78956bc65
commit 359ab9819c
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ios/CodePush/CodePush.m
View File

@@ -332,16 +332,19 @@ static NSString *bundleResourceSubdirectory = nil;
#ifdef DEBUG
#if TARGET_IPHONE_SIMULATOR
errorMessage = @"React Native doesn't generate your app's JS bundle by default when deploying to the simulator. "
"If you'd like to test CodePush using the simulator, you can do one of three things depending on your React "
"Native version and/or preferred workflow:\n\n"
"If you'd like to test CodePush using the simulator, you can do one of the following depending on your "
"React Native version and/or preferred workflow:\n\n"
"1. Update your AppDelegate.m file to load the JS bundle from the packager instead of from CodePush. "
"You can still test your CodePush update experience using this workflow (debug builds only).\n\n"
"You can still test your CodePush update experience using this workflow (Debug builds only).\n\n"
"2. Force the JS bundle to be generated in simulator builds by removing the if block that echoes "
"\"Skipping bundling for Simulator platform\" in the \"node_modules/react-native/packager/react-native-xcode.sh\" file.\n\n"
"2. Force the JS bundle to be generated in simulator builds by adding 'export FORCE_BUNDLING=true' to the script under "
"\"Build Phases\" > \"Bundle React Native code and images\" (React Native >=0.48 only).\n\n"
"3. Deploy a release build to the simulator, which unlike debug builds, will generate the JS bundle (React Native >=0.22.0 only).";
"3. Force the JS bundle to be generated in simulator builds by removing the if block that echoes "
"\"Skipping bundling for Simulator platform\" in the \"node_modules/react-native/packager/react-native-xcode.sh\" file (React Native <=0.47 only)\n\n"
"4. Deploy a Release build to the simulator, which unlike Debug builds, will generate the JS bundle (React Native >=0.22.0 only).";
#else
errorMessage = [NSString stringWithFormat:@"The specified JS bundle file wasn't found within the app's binary. Is \"%@\" the correct file name?", [bundleResourceName stringByAppendingPathExtension:bundleResourceExtension]];
#endif