kylefang/quark-shell-mac
1
0
Fork 0
mirror of https://github.com/HackPlan/quark-shell-mac.git synced 2026-01-12 15:04:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Close #46] Revert "[Close #27] Keep icon highlight state after click."

Browse Source 
This reverts commit 5d28894c7a.

The way to keep status item highlighted no longer works on El Capitan. Revert for now. Need a better approach.
This commit is contained in:
LIU Dongyuan / 柳东原
2015-09-21 20:08:36 -07:00
parent 4a9a4bf331
commit 7f7e1238eb
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
quark-shell/QSHAppDelegate.m
View File

@@ -55,19 +55,10 @@
NSImage *statusIcon = [NSImage imageNamed:@"StatusIcon"];
[statusIcon setTemplate:YES];
self.statusItem.button.image = statusIcon;
// We can't keep the button highlighted by calling `setHighlighted:` or `highlight:`.
// So we are adding another invisible button as subview to take over the event handler.
// Then we can call `highlight:` in the event handler.
// See: http://stackoverflow.com/questions/26004684/nsstatusbarbutton-keep-highlighted
NSButton *button = [[NSButton alloc] initWithFrame:self.statusItem.button.frame];
button.alphaValue = 0;
NSArray *array = @[self.statusItem.button, button];
self.statusItem.button.superview.subviews = array;
[button sendActionOn:(NSLeftMouseDownMask | NSRightMouseDownMask)];
button.target = self;
button.action = @selector(statusItemClicked);
self.statusItem.button.target = self;
self.statusItem.button.action = @selector(statusItemClicked);
[self.statusItem.button sendActionOn:(NSLeftMouseDownMask | NSRightMouseDownMask)];
}
self.window.level = NSFloatingWindowLevel;
@@ -147,8 +138,6 @@
- (void)refreshStyle
{
[self.statusItem.button highlight:self.shouldBeVisible];
NSRect itemFrame;
if (IS_PERIOR_TO_10_9) {