Commit Graph

240 Commits

Author SHA1 Message Date
Brandon Keepers
34f1d993d4 Merge branch 'webhook-types' into github-app-webhooks
* webhook-types:
  Test for context.isBot
  Add test for deprecated receive behavior
  Add strong typing for exported webhooks property
  Fix deprecation warnings
  Make most webhook payload properties optional for now
  Move webhook type declarations
2018-07-15 13:52:41 -05:00
Brandon Keepers
5085f45a76 Test for context.isBot 2018-07-15 11:45:33 -05:00
Brandon Keepers
766d2d1757 Add test for deprecated receive behavior 2018-07-15 11:45:23 -05:00
Brandon Keepers
25694becc0 Fix deprecation warnings 2018-07-15 11:21:22 -05:00
Brandon Keepers
565ad9a246 Make most webhook payload properties optional for now
Until we have a way to generate test fixtures, it's too much of a hassle 
to require all these properties.
2018-07-15 11:21:22 -05:00
Brandon Keepers
28aa21c3d5 Move webhook type declarations 2018-07-15 11:21:22 -05:00
Brandon Keepers
5da38a01c2 Merge branch 'ts-extract-github-adapter' into github-app-webhooks
* ts-extract-github-adapter: (24 commits)
  Doc tweaks
  Remove @private
  Fix accidental change to catchErrors in constructor
  Add deprecations for `app.app()` and `app.auth`
  Rename `adapter` to just `github`
  chore(package): update ts-jest to version 23.0.0 (#602)
  chore(test): Convert application tests to TypeScript (#614)
  Clarifies the Probot requires a webhook secret (#621)
  chore(test): Run tslint against tests (#622)
  Tweak formatting of config docs (#603)
  Fix: Improve typing of Context (#617)
  fix: Make cacheErrors option optional (#616)
  7.0.1
  Update ocotokit/rest.js to v15.9.4 (#610)
  fix: Remove extra event setting (#611)
  Update eslint to the latest version 🚀 (#581)
  docs: Fix new contribution grammar (#609)
  update the example app id image (#606)
  Update links for our API (#604)
  Remove next tag (#595)
  ...
2018-07-15 09:25:38 -05:00
Brandon Keepers
c56370d99d Doc tweaks 2018-07-15 08:36:44 -05:00
Brandon Keepers
5611d862b6 Add deprecations for app.app() and app.auth 2018-07-15 07:53:05 -05:00
Brandon Keepers
8928971e81 Rename adapter to just github 2018-07-15 07:36:34 -05:00
Brandon Keepers
c869a18b02 Merge remote-tracking branch 'origin/master' into ts-extract-github-adapter
* origin/master:
  chore(package): update ts-jest to version 23.0.0 (#602)
  chore(test): Convert application tests to TypeScript (#614)
  Clarifies the Probot requires a webhook secret (#621)
  chore(test): Run tslint against tests (#622)
  Tweak formatting of config docs (#603)
  Fix: Improve typing of Context (#617)
  fix: Make cacheErrors option optional (#616)
  7.0.1
  Update ocotokit/rest.js to v15.9.4 (#610)
  fix: Remove extra event setting (#611)
  Update eslint to the latest version 🚀 (#581)
  docs: Fix new contribution grammar (#609)
  update the example app id image (#606)
  Update links for our API (#604)
  Remove next tag (#595)
  7.0.0
  Various cleanup and fixes from TS checklist (#585)
  Add some documentation about TS to README and CONTRIBUTING (#590)
  chore: Use tslint-config-standard (#594)
2018-07-15 07:02:50 -05:00
Kentaro Matsushita
88cdb2bfa4 chore(test): Convert application tests to TypeScript (#614) 2018-07-15 05:52:28 -05:00
Brandon Keepers
1795133ee4 chore(test): Run tslint against tests (#622) 2018-07-13 10:23:50 -05:00
Tommy Byrd
48887fa938 Various cleanup and fixes from TS checklist (#585)
* Optional Options

* Webhook ID is a string

* turning on no-var-requires and related fixes

* remove any. app is inferring correctly

* linter
2018-06-28 12:35:11 -04:00
Brandon Keepers
27f3a02cd4 Merge branch 'ts-extract-github-adapter' into github-app-webhooks
* ts-extract-github-adapter:
  chore(package): update @types/jest to version 23.1.3 (#593)
  Revert "Configuration: DISABLE_STATS=true" (#591)
  chore(package): update @types/jest to version 23.0.0 (#555)
  docs(configuration): DISABLE_STATS=true (#578)
  fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
  Adds error case (#589)
  doc: Clarify that `WEBHOOK_SECRET` needs to match GitHub settings 
(#588)
  chore: Replace jsdoc with typedoc (#583)
  Adds missing awaits (#584)
  doc: Update robot => app in README (#586)
  docs: clarify GitHub apps as GA in 2.13 and above (#579)
  docs: Tweak payload info in testing.md (#575)
  add backticks (#574)
  docs: Typo (#572)
  fix: Throw if GHE_HOST includes a protocol (#570)
  feat: app.load() (#554)
  fix: Optimize IGNORED_ACCOUNTS check to reduce the number of API 
requests that the stats endpoint makes for spammy accounts (#566)
  add env config docs (#544)
2018-06-27 22:50:59 -05:00
Brandon Keepers
b6183605ca Extend options, test for webhook aliasing 2018-06-27 22:48:27 -05:00
Brandon Keepers
c107a83563 Merge remote-tracking branch 'origin/master' into ts-extract-github-adapter
* origin/master:
  chore(package): update @types/jest to version 23.1.3 (#593)
  Revert "Configuration: DISABLE_STATS=true" (#591)
  chore(package): update @types/jest to version 23.0.0 (#555)
  docs(configuration): DISABLE_STATS=true (#578)
  fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
  Adds error case (#589)
  doc: Clarify that `WEBHOOK_SECRET` needs to match GitHub settings
(#588)
  chore: Replace jsdoc with typedoc (#583)
  Adds missing awaits (#584)
  doc: Update robot => app in README (#586)
  docs: clarify GitHub apps as GA in 2.13 and above (#579)
  docs: Tweak payload info in testing.md (#575)
  add backticks (#574)
  docs: Typo (#572)
  fix: Throw if GHE_HOST includes a protocol (#570)
  feat: app.load() (#554)
  fix: Optimize IGNORED_ACCOUNTS check to reduce the number of API
requests that the stats endpoint makes for spammy accounts (#566)
  add env config docs (#544)
2018-06-27 22:38:11 -05:00
Morgan Delagrange
73ac539f45 fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
The API path should be <ghe_host>/api/graphql, but
it is defaulting to <ghe_host>/api/v3/graphql.
2018-06-27 19:11:34 -05:00
Bex Warner
43ea6ce815 Adds error case (#589)
* add case

* i saved it before I typed the colon ::::::

* showdown: my 3 commits vs 1 colon

* add test cases for all scenarios
2018-06-27 16:53:34 -07:00
Jason Etcovitch
b60de0c123 fix: Throw if GHE_HOST includes a protocol (#570) 2018-06-18 14:32:02 -04:00
Jason Etcovitch
de18b9000b feat: app.load() (#554) 2018-06-15 20:14:41 -04:00
Brandon Keepers
17a7f0c820 Remove webhooks from accessor from Probot class 2018-06-12 00:06:18 -05:00
Brandon Keepers
14f971541e Move WebhookEvent definition 2018-06-11 23:47:34 -05:00
Brandon Keepers
2bfaea6282 Rename to GitHubApp 2018-06-10 22:23:55 -05:00
Brandon Keepers
cbd677a501 Merge remote-tracking branch 'origin/master' into ts-extract-github-adapter
* origin/master:
  fix(package): update dotenv to version 6.0.0 (#556)
  chore: Remove noImplicitAny and add types to params (#546)
  chore: Convert Context tests to TypeScript (#541)
  chore(package): Update bottleneck to the latest version 🚀 (#562)
2018-06-10 22:19:28 -05:00
Brandon Keepers
623260ad2f chore: Convert Context tests to TypeScript (#541) 2018-06-09 22:45:15 -05:00
greenkeeper[bot]
c5bf773cb3 chore(package): Update bottleneck to the latest version 🚀 (#562) 2018-06-09 21:40:58 -05:00
Brandon Keepers
e17e4a45d9 Move jwt creation into adapter 2018-06-07 18:15:00 -07:00
Brandon Keepers
220c2c6506 Move the webhook handler setup out of the server 2018-06-07 17:41:54 -07:00
Brandon Keepers
6e3d8efb71 Pass adapter into Application 2018-06-07 17:41:49 -07:00
Brandon Keepers
622a5996b3 Extract GitHubAdapter class 2018-06-07 17:41:17 -07:00
Brandon Keepers
3349082e5d Extract context creation to method 2018-06-07 17:41:04 -07:00
Brandon Keepers
2efa0b24b7 chore: Rename robot to app (#542)
This replaces all internal references to "robot" with "app" or
"Application". There should be no functional change in public APIs, but
may cause some issues for anyone using internal APIs.
2018-06-01 17:45:23 -05:00
Tommy Byrd
d2fe925e1a chore: Rewrite core in Typescript (#372) 2018-05-25 15:17:19 -05:00
Brandon Keepers
61393304f0 chore: Commit version number, remove snapshot tests (#535) 2018-05-19 08:26:01 -05:00
Bartosz Łaniewski
f525df9e8a fix: Allow listening to installation.deleted event and other events that don't include an installation id (#475) 2018-05-18 23:43:16 -05:00
Bex Warner
c0140b5d7b add ignore spammy/abusive user option for stats endpoint (#513)
* add spammy user ignorance and test - not sure why failing 😭

* set account.stars to 0

* use id 1 for test user to properly authenticate

* delete process.env.ignored_accounts on aftereach

* add extra line
2018-05-13 15:28:18 -05:00
Richard Littauer
4524ada62c docs: suggested changes from audit #522 (#523) 2018-05-13 01:16:43 -04:00
Kautilya Tripathi
cfe3cddd58 fix: throw informative error if payload is missing repository (#508) 2018-04-22 16:36:08 -04:00
Kautilya Tripathi
72d0d81bf8 chore: Add icon to title of probot (#483) 2018-04-05 13:59:44 -05:00
Brandon Keepers
6e60927dba fix: allow initializing the GitHub client without options (#479) 2018-03-22 17:33:38 -05:00
Brandon Keepers
3503b1f611 Add GraphQL support (#472) 2018-03-21 21:33:16 -05:00
Brandon Keepers
9f324c79e3 chore: Minimal changes to get @octokit/webhooks working (#462) 2018-03-21 13:23:51 -04:00
Jason Etcovitch
2fc8fd8f45 feat: Better error messages (#434) 2018-03-21 01:33:58 -04:00
Alexey Alekhin
ddb5b3d9ba Raise an error if there are several .pem files (#441) 2018-03-08 21:33:46 -05:00
greenkeeper[bot]
0060098fd7 chore(package): Update standard to the latest version 🚀 (#436) 2018-02-28 10:09:40 -05:00
Brandon Keepers
72d6911a79 fix: Re-throw errors from octokit (#418) 2018-02-05 10:28:02 -05:00
greenkeeper[bot]
2f3f434ab8 fix(package): Update bottleneck to the latest version 🚀 (#397) 2018-02-03 15:55:50 -05:00
Gregor
5bf1c315c7 test: adapt for @octokit/rest
Turns out that the `per_page` & `page` params are missing in [routes.json](https://github.com/octokit/rest.js/blob/master/lib/routes.json#L1682-L1687), which means, with the previous implementations, they have been ignored!

The new implementation automatically passes all remaining options as query parameter (for `GET` requests) so it works anyway.

So tl;dr: the new release actually fixed a bug, getting the stats will be more performant now, as it gets 100 results instead of 30
2018-01-29 11:07:17 -08:00
Brandon Keepers
0a4b297757 Allow setting logger name to separate components (#355) 2018-01-29 08:26:33 -06:00