Commit Graph

1055 Commits

Author SHA1 Message Date
Brandon Keepers
34f1d993d4 Merge branch 'webhook-types' into github-app-webhooks
* webhook-types:
  Test for context.isBot
  Add test for deprecated receive behavior
  Add strong typing for exported webhooks property
  Fix deprecation warnings
  Make most webhook payload properties optional for now
  Move webhook type declarations
2018-07-15 13:52:41 -05:00
Brandon Keepers
5085f45a76 Test for context.isBot 2018-07-15 11:45:33 -05:00
Brandon Keepers
766d2d1757 Add test for deprecated receive behavior 2018-07-15 11:45:23 -05:00
Brandon Keepers
bdc90cd040 Add strong typing for exported webhooks property 2018-07-15 11:21:22 -05:00
Brandon Keepers
25694becc0 Fix deprecation warnings 2018-07-15 11:21:22 -05:00
Brandon Keepers
565ad9a246 Make most webhook payload properties optional for now
Until we have a way to generate test fixtures, it's too much of a hassle 
to require all these properties.
2018-07-15 11:21:22 -05:00
Brandon Keepers
28aa21c3d5 Move webhook type declarations 2018-07-15 11:21:22 -05:00
Brandon Keepers
5da38a01c2 Merge branch 'ts-extract-github-adapter' into github-app-webhooks
* ts-extract-github-adapter: (24 commits)
  Doc tweaks
  Remove @private
  Fix accidental change to catchErrors in constructor
  Add deprecations for `app.app()` and `app.auth`
  Rename `adapter` to just `github`
  chore(package): update ts-jest to version 23.0.0 (#602)
  chore(test): Convert application tests to TypeScript (#614)
  Clarifies the Probot requires a webhook secret (#621)
  chore(test): Run tslint against tests (#622)
  Tweak formatting of config docs (#603)
  Fix: Improve typing of Context (#617)
  fix: Make cacheErrors option optional (#616)
  7.0.1
  Update ocotokit/rest.js to v15.9.4 (#610)
  fix: Remove extra event setting (#611)
  Update eslint to the latest version 🚀 (#581)
  docs: Fix new contribution grammar (#609)
  update the example app id image (#606)
  Update links for our API (#604)
  Remove next tag (#595)
  ...
2018-07-15 09:25:38 -05:00
Brandon Keepers
c56370d99d Doc tweaks 2018-07-15 08:36:44 -05:00
Brandon Keepers
9c5cc31ff3 Remove @private 2018-07-15 08:21:00 -05:00
Brandon Keepers
bfa3e683f3 Fix accidental change to catchErrors in constructor 2018-07-15 07:54:23 -05:00
Brandon Keepers
5611d862b6 Add deprecations for app.app() and app.auth 2018-07-15 07:53:05 -05:00
Brandon Keepers
8928971e81 Rename adapter to just github 2018-07-15 07:36:34 -05:00
Brandon Keepers
c869a18b02 Merge remote-tracking branch 'origin/master' into ts-extract-github-adapter
* origin/master:
  chore(package): update ts-jest to version 23.0.0 (#602)
  chore(test): Convert application tests to TypeScript (#614)
  Clarifies the Probot requires a webhook secret (#621)
  chore(test): Run tslint against tests (#622)
  Tweak formatting of config docs (#603)
  Fix: Improve typing of Context (#617)
  fix: Make cacheErrors option optional (#616)
  7.0.1
  Update ocotokit/rest.js to v15.9.4 (#610)
  fix: Remove extra event setting (#611)
  Update eslint to the latest version 🚀 (#581)
  docs: Fix new contribution grammar (#609)
  update the example app id image (#606)
  Update links for our API (#604)
  Remove next tag (#595)
  7.0.0
  Various cleanup and fixes from TS checklist (#585)
  Add some documentation about TS to README and CONTRIBUTING (#590)
  chore: Use tslint-config-standard (#594)
2018-07-15 07:02:50 -05:00
greenkeeper[bot]
37fc44440b chore(package): update ts-jest to version 23.0.0 (#602) 2018-07-15 06:26:32 -05:00
Kentaro Matsushita
88cdb2bfa4 chore(test): Convert application tests to TypeScript (#614) 2018-07-15 05:52:28 -05:00
Bex Warner
952f88b5b4 Clarifies the Probot requires a webhook secret (#621)
* Update development.md

* Update configuration.md

* Update configuration.md

* Update development.md
2018-07-13 09:50:42 -07:00
Brandon Keepers
1795133ee4 chore(test): Run tslint against tests (#622) 2018-07-13 10:23:50 -05:00
Brandon Keepers
e284ee2567 Tweak formatting of config docs (#603)
* Move required indicator inline

* Remove example column

* Several tweaks to env docs

1. Sort alphabetically
2. Tweak descriptions
3. Clearer pattern for default values: `Default: <value>`

* implement @tcbyrd's idea for examples
2018-07-10 15:40:04 -07:00
Ben Scott
9d94cd6675 Fix: Improve typing of Context (#617)
* State event in Context constructor implements WebhookEvent
* State Context implements WebhookEvent
* Explicitly state properties in Context constructor instead of using
  Object.assign
2018-07-10 09:24:08 -05:00
Ben Scott
c275173ce3 fix: Make cacheErrors option optional (#616)
Set a default value of false and update the property to note that it
will now always be a boolean
2018-07-09 16:57:01 -05:00
Jason Etcovitch
b32fc2b38d 7.0.1 2018-07-06 17:02:43 -04:00
Tommy Byrd
8340d85dbb Update ocotokit/rest.js to v15.9.4 (#610)
* update ocotokit rest
2018-07-06 16:56:13 -04:00
Jason Etcovitch
fa371375db fix: Remove extra event setting (#611) 2018-07-06 16:36:59 -04:00
greenkeeper[bot]
13ca06d852 Update eslint to the latest version 🚀 (#581)
* chore(package): update eslint to version 5.0.0

* Fix eslint-plugin-markdown

* Add standard-markdown to use with tslint
2018-07-06 15:33:35 -04:00
Garen Torikian
b5806ba816 docs: Fix new contribution grammar (#609) 2018-07-06 13:59:19 -04:00
Brian Douglas
1aaf280776 update the example app id image (#606)
* update the example app id image

per https://github.com/probot/probot/issues/600

* updates image to remove retina blurryness
2018-07-04 20:10:38 -07:00
Bex Warner
eef84796ed Update links for our API (#604)
* Update hello-world.md

* Update best-practices.md
2018-07-02 09:17:37 -07:00
Brandon Keepers
9ec8765b79 Remove next tag (#595) 2018-06-28 11:41:40 -05:00
Brandon Keepers
a90fe25c54 7.0.0 v7.0.0 2018-06-28 11:35:51 -05:00
Tommy Byrd
48887fa938 Various cleanup and fixes from TS checklist (#585)
* Optional Options

* Webhook ID is a string

* turning on no-var-requires and related fixes

* remove any. app is inferring correctly

* linter
2018-06-28 12:35:11 -04:00
Tommy Byrd
be1d8568e4 Add some documentation about TS to README and CONTRIBUTING (#590)
* Add TS info to README

* Add info about ts compiler when running tests

* don't talk about compiling

* Simplify and Unbold
2018-06-28 12:24:04 -04:00
Brandon Keepers
d740f2aa3e chore: Use tslint-config-standard (#594) 2018-06-28 11:10:23 -05:00
Brandon Keepers
27f3a02cd4 Merge branch 'ts-extract-github-adapter' into github-app-webhooks
* ts-extract-github-adapter:
  chore(package): update @types/jest to version 23.1.3 (#593)
  Revert "Configuration: DISABLE_STATS=true" (#591)
  chore(package): update @types/jest to version 23.0.0 (#555)
  docs(configuration): DISABLE_STATS=true (#578)
  fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
  Adds error case (#589)
  doc: Clarify that `WEBHOOK_SECRET` needs to match GitHub settings 
(#588)
  chore: Replace jsdoc with typedoc (#583)
  Adds missing awaits (#584)
  doc: Update robot => app in README (#586)
  docs: clarify GitHub apps as GA in 2.13 and above (#579)
  docs: Tweak payload info in testing.md (#575)
  add backticks (#574)
  docs: Typo (#572)
  fix: Throw if GHE_HOST includes a protocol (#570)
  feat: app.load() (#554)
  fix: Optimize IGNORED_ACCOUNTS check to reduce the number of API 
requests that the stats endpoint makes for spammy accounts (#566)
  add env config docs (#544)
2018-06-27 22:50:59 -05:00
Brandon Keepers
b6183605ca Extend options, test for webhook aliasing 2018-06-27 22:48:27 -05:00
Brandon Keepers
c107a83563 Merge remote-tracking branch 'origin/master' into ts-extract-github-adapter
* origin/master:
  chore(package): update @types/jest to version 23.1.3 (#593)
  Revert "Configuration: DISABLE_STATS=true" (#591)
  chore(package): update @types/jest to version 23.0.0 (#555)
  docs(configuration): DISABLE_STATS=true (#578)
  fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
  Adds error case (#589)
  doc: Clarify that `WEBHOOK_SECRET` needs to match GitHub settings
(#588)
  chore: Replace jsdoc with typedoc (#583)
  Adds missing awaits (#584)
  doc: Update robot => app in README (#586)
  docs: clarify GitHub apps as GA in 2.13 and above (#579)
  docs: Tweak payload info in testing.md (#575)
  add backticks (#574)
  docs: Typo (#572)
  fix: Throw if GHE_HOST includes a protocol (#570)
  feat: app.load() (#554)
  fix: Optimize IGNORED_ACCOUNTS check to reduce the number of API
requests that the stats endpoint makes for spammy accounts (#566)
  add env config docs (#544)
2018-06-27 22:38:11 -05:00
greenkeeper[bot]
cec2e58d29 chore(package): update @types/jest to version 23.1.3 (#593) 2018-06-27 22:31:18 -05:00
Bex Warner
866929f2aa Revert "Configuration: DISABLE_STATS=true" (#591)
* Revert "chore(package): update @types/jest to version 23.0.0 (#555)"

This reverts commit dee76d207b.

* Revert "docs(configuration): DISABLE_STATS=true (#578)"

This reverts commit 3ac0fa1e68.
2018-06-27 17:21:49 -07:00
greenkeeper[bot]
dee76d207b chore(package): update @types/jest to version 23.0.0 (#555) 2018-06-27 19:15:58 -05:00
Gregor Martynus
3ac0fa1e68 docs(configuration): DISABLE_STATS=true (#578) 2018-06-27 19:15:14 -05:00
Morgan Delagrange
73ac539f45 fix: Fix path to GraphQL API when using GitHub Enterprise (#580)
The API path should be <ghe_host>/api/graphql, but
it is defaulting to <ghe_host>/api/v3/graphql.
2018-06-27 19:11:34 -05:00
Bex Warner
43ea6ce815 Adds error case (#589)
* add case

* i saved it before I typed the colon ::::::

* showdown: my 3 commits vs 1 colon

* add test cases for all scenarios
2018-06-27 16:53:34 -07:00
Bex Warner
a54243394d doc: Clarify that WEBHOOK_SECRET needs to match GitHub settings (#588) 2018-06-27 09:32:27 -05:00
Brandon Keepers
c2476c74e9 chore: Replace jsdoc with typedoc (#583) 2018-06-26 18:02:59 -05:00
Alberto Gimeno
8df333ccf8 Adds missing awaits (#584)
Both `get` and `set` are async in the metadata library. The `await` in `get` is required in this case because otherwise it will always to set a promise on the metadata, which doesn't make sense, and the await in set is required to not swallow the rejection if it fails.
2018-06-26 13:23:50 -07:00
Abhijeet Singh
6c2cc02e83 doc: Update robot => app in README (#586) 2018-06-26 14:44:11 -05:00
Brent Beer
9920d26cca docs: clarify GitHub apps as GA in 2.13 and above (#579) 2018-06-22 09:25:28 -04:00
Ben Scott
fba83a10c6 docs: Tweak payload info in testing.md (#575)
This helps enforce the idea that a payload fixture file should be the
webhook payload body, so that the fixture can be referenced by both
tests and `probot simulate`.
2018-06-20 17:26:40 -07:00
Bex Warner
c676d6c561 add backticks (#574) 2018-06-20 14:50:27 -07:00
peterennis
f855f51743 docs: Typo (#572)
s/to customized/to be customized
2018-06-18 21:35:20 -04:00