Improve error signalling for client certificates.

netlib/tcp.py

@@ -177,11 +177,14 @@ class TCPClient:
             clientcert: Path to a file containing both client cert and private key.
         """
         context = SSL.Context(method)
-        if not options is None:
+        if options is not None:
             ctx.set_options(options)
         if clientcert:
-            context.use_privatekey_file(clientcert)
-            context.use_certificate_file(clientcert)
+            try:
+                context.use_privatekey_file(clientcert)
+                context.use_certificate_file(clientcert)
+            except SSL.Error, v:
+                raise NetLibError("SSL client certificate error: %s"%str(v))
         self.connection = SSL.Connection(context, self.connection)
         self.ssl_established = True
         if sni:

test/test_tcp.py

@@ -189,6 +189,15 @@ class TestSSLClientCert(ServerTestBase):
         c.convert_to_ssl(clientcert=tutils.test_data.path("data/clientcert/client.pem"))
         assert c.rfile.readline().strip() == "1"
 
+    def test_clientcert_err(self):
+        c = tcp.TCPClient("127.0.0.1", self.port)
+        c.connect()
+        tutils.raises(
+            tcp.NetLibError,
+            c.convert_to_ssl,
+            clientcert=tutils.test_data.path("data/clientcert/make")
+        )
+
 
 class TestSNI(ServerTestBase):
     @classmethod