kylefang/esbuild
1
0
Fork 0
mirror of https://github.com/zhigang1992/esbuild.git synced 2026-01-12 17:13:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

rename "isPrivateUnsupported"

Browse Source
This commit is contained in:
Evan Wallace
2021-04-10 04:06:16 -07:00
parent 16de3d5692
commit f7440d70ba
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/js_parser/js_parser.go
View File

@@ -9054,7 +9054,7 @@ func (p *parser) visitClass(nameScopeLoc logger.Loc, class *js_ast.Class) js_ast
// We need to explicitly assign the name to the property initializer if it
// will be transformed such that it is no longer an inline initializer.
nameToKeep := ""
if isPrivate && p.isPrivateUnsupported(private) {
if isPrivate && p.privateSymbolNeedsToBeLowered(private) {
nameToKeep = p.symbols[private.Ref.InnerIndex].OriginalName
} else if !property.IsMethod && !property.IsComputed &&
((!property.IsStatic && p.options.unsupportedJSFeatures.Has(compat.ClassField)) ||
@@ -10538,7 +10538,7 @@ func (p *parser) visitExprInOut(expr js_ast.Expr, in exprIn) (js_ast.Expr, exprO
// Lower private member access only if we're sure the target isn't needed
// for the value of "this" for a call expression. All other cases will be
// taken care of by the enclosing call expression.
if p.options.unsupportedJSFeatures.Has(kind.Feature()) && e.OptionalChain == js_ast.OptionalChainNone &&
if p.privateSymbolNeedsToBeLowered(private) && e.OptionalChain == js_ast.OptionalChainNone &&
in.assignTarget == js_ast.AssignTargetNone && !isCallTarget {
// "foo.#bar" => "__privateGet(foo, #bar)"
return p.lowerPrivateGet(e.Target, e.Index.Loc, private), exprOut{}

14
internal/js_parser/js_parser_lower.go
View File

@@ -197,7 +197,7 @@ func (p *parser) markLoweredSyntaxFeature(feature compat.JSFeature, r logger.Ran
}
}
func (p *parser) isPrivateUnsupported(private *js_ast.EPrivateIdentifier) bool {
func (p *parser) privateSymbolNeedsToBeLowered(private *js_ast.EPrivateIdentifier) bool {
return p.options.unsupportedJSFeatures.Has(p.symbols[private.Ref.InnerIndex].Kind.Feature())
}
@@ -481,7 +481,7 @@ flatten:
// itself will have to be lowered even if the language target supports
// optional chaining. This is because there's no way to use our shim
// function for private names with optional chaining syntax.
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.isPrivateUnsupported(private) {
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.privateSymbolNeedsToBeLowered(private) {
containsPrivateName = true
}
@@ -585,7 +585,7 @@ flatten:
// Capture the value of "this" if the target of the starting call
// expression is a private property access
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.isPrivateUnsupported(private) {
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.privateSymbolNeedsToBeLowered(private) {
// "foo().#bar?.()" must capture "foo()" for "this"
expr = p.lowerPrivateGet(targetFunc(), e.Index.Loc, private)
thisArg = targetFunc()
@@ -633,7 +633,7 @@ flatten:
}}
case *js_ast.EIndex:
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.isPrivateUnsupported(private) {
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.privateSymbolNeedsToBeLowered(private) {
// If this is private name property access inside a call expression and
// the call expression is part of this chain, then the call expression
// is going to need a copy of the property access target as the value
@@ -1076,7 +1076,7 @@ func (p *parser) lowerPrivateSetBinOp(target js_ast.Expr, loc logger.Loc, privat
// the language target is such that private members must be lowered
func (p *parser) extractPrivateIndex(target js_ast.Expr) (js_ast.Expr, logger.Loc, *js_ast.EPrivateIdentifier) {
if index, ok := target.Data.(*js_ast.EIndex); ok {
if private, ok := index.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.isPrivateUnsupported(private) {
if private, ok := index.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.privateSymbolNeedsToBeLowered(private) {
return index.Target, index.Index.Loc, private
}
}
@@ -1253,7 +1253,7 @@ func (p *parser) lowerPrivateInAssign(expr js_ast.Expr) (js_ast.Expr, bool) {
case *js_ast.EIndex:
// "[a.#b] = [c]" => "[__privateAssign(a, #b)._] = [c]"
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.isPrivateUnsupported(private) {
if private, ok := e.Index.Data.(*js_ast.EPrivateIdentifier); ok && p.privateSymbolNeedsToBeLowered(private) {
var target js_ast.Expr
switch p.symbols[private.Ref.InnerIndex].Kind {
@@ -1805,7 +1805,7 @@ func (p *parser) lowerClass(stmt js_ast.Stmt, expr js_ast.Expr, shadowRef js_ast
// However, the TypeScript compiler doesn't remove the field when doing
// strict class field initialization, so we shouldn't either.
private, _ := prop.Key.Data.(*js_ast.EPrivateIdentifier)
mustLowerPrivate := private != nil && p.isPrivateUnsupported(private)
mustLowerPrivate := private != nil && p.privateSymbolNeedsToBeLowered(private)
shouldOmitFieldInitializer := p.options.ts.Parse && !prop.IsMethod && prop.Initializer == nil &&
!useDefineForClassFields && !mustLowerPrivate