kylefang/devhub
1
0
Fork 0
mirror of https://github.com/zhigang1992/devhub.git synced 2026-06-18 12:14:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update link anchor ids

Browse Source 
https://twitter.com/brunolemos/status/1066061097520766976?s=20
This commit is contained in:
Bruno Lemos
2018-11-23 18:13:45 -02:00
parent ed9575f55f
commit 7ad49fc51f
1 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/shared-core/src/utils/helpers/github/url.ts
View File

@@ -130,14 +130,9 @@ export function githubHTMLUrlFromAPIUrl(
switch (type2) {
case 'commits': {
if (commentId) {
const elementId =
realOSName === 'web'
? `commitcomment-${commentId}`
: `comment-${commentId}`
return `${baseURL}/${repoFullName}/commit/${
restOfURL2[0]
}#${elementId}`
}#commitcomment-${commentId}`
}
return `${baseURL}/${repoFullName}/commit/${restOfURL2.join('/')}`
@@ -148,12 +143,8 @@ export function githubHTMLUrlFromAPIUrl(
issueOrPullRequestNumber &&
(commentId || (restOfURL2[0] === 'comments' && restOfURL2[1]))
) {
const elementId =
realOSName === 'web'
? `issuecomment-${commentId || restOfURL2[1]}`
: `comment-${commentId || restOfURL2[1]}`
return `${baseURL}/${repoFullName}/issues/${issueOrPullRequestNumber}#${elementId}`
return `${baseURL}/${repoFullName}/issues/${issueOrPullRequestNumber}#issuecomment-${commentId ||
restOfURL2[1]}`
}
return `${baseURL}/${repoFullName}/issues/${restOfURL2.join('/')}`
@@ -163,12 +154,8 @@ export function githubHTMLUrlFromAPIUrl(
issueOrPullRequestNumber &&
(commentId || (restOfURL2[0] === 'comments' && restOfURL2[1]))
) {
const elementId =
realOSName === 'web'
? `discussion_r${commentId || restOfURL2[1]}`
: `comment-${commentId || restOfURL2[1]}`
return `${baseURL}/${repoFullName}/pull/${issueOrPullRequestNumber}#${elementId}`
return `${baseURL}/${repoFullName}/pull/${issueOrPullRequestNumber}#discussion_r${commentId ||
restOfURL2[1]}`
}
return `${baseURL}/${repoFullName}/pull/${restOfURL2.join('/')}`