Commit Graph

45 Commits

Author SHA1 Message Date
Joe Haddad
ca2e9f0f3c Adjust ESLint configuration for v5 (#5051) 2018-09-21 08:07:12 -04:00
Ian Sutherland
8a34b7cc77 Add ESLint check for incorrect propTypes usage (#3840) (#4048) 2018-03-25 16:17:41 -06:00
Andreas Cederström
33f1294f07 Revert "Change no-unused-vars 'args' from none to all to show warning on destructured objects"
This reverts commit 1dcb3db3ed.
2018-03-23 14:41:28 +01:00
goncy
1dcb3db3ed Change no-unused-vars 'args' from none to all to show warning on destructured objects 2018-03-20 08:27:23 -03:00
Michaël De Boey
25184c4e91 Fix links to package (#3898) 2018-01-22 22:16:22 +00:00
Sendil Kumar N
ee2dd27ec1 remove radix eslint rule (#3844) 2018-01-17 22:40:04 +00:00
Victor Amupitan
ed276295d6 Changes no-unused-expressions lint from warning to error (#2319)
* Changes no-unused-expressions lint from warning to error

* Update index.js

* Update index.js
2018-01-17 12:06:44 +00:00
Siddharth Doshi
c36d1a00a1 Add restricted globals package (#2286)
* Add restricted globals package

* Use new package in eslint-config

* Add eslint-restricted-globals dependency

* Fixes

* Update dependencies

* Update test and README

* Use jest

* tweaks

* Add lint/test to CI

* Fix lint
2018-01-15 00:08:14 -05:00
Chris Laughlin
f6c3730085 Enable getter-return rule as a warning (#3723)
* Updating ESlint to ^4.15.0 and adding new rules to config

* remoning style rule and auto fixing breakages from new rules

* Removing implicit-arrow-linebreak style rule

* adding new rule to eslint config project

* updating react scripts eslint version

* Pinning version.

* Changing getter-return to warn

* Update package.json

* Update .eslintrc
2018-01-15 00:08:14 -05:00
Dan Abramov
bf02edbef2 Bump eslint-plugin-jsx-a11y version (#2690)
* Bump eslint-plugin-jsx-a11y

* Update index.js

* Update index.js

* Update package.json

* Don't use links for non-linky things
2018-01-15 00:07:58 -05:00
everdimension
813584ff35 Redisable require.ensure() (#3121) 2018-01-15 00:06:24 -05:00
Dan Abramov
ce07e98bbd Relax no-cond-assign rule (#3716)
Fixes #2793
2018-01-08 21:34:01 +00:00
Sophie Alpert
2e82ebb337 BSD+Patents -> MIT (#3189)
* File headers BSD+Patents -> MIT

* BSD+Patents -> MIT
2017-09-26 10:30:05 +01:00
Oskar Köök
664b7651ae Re-enable flowtype warning (#2718)
* Re-enable flowtype warning

* Update eslint-plugin-flowtype dependency
2017-08-01 22:35:06 -04:00
Kristoffer
df00d8071a allowTaggedTemplates to avoid warnings from SC's (#2701) 2017-07-01 15:49:49 +01:00
Dan Abramov
a171d93064 Reformat source code with Prettier 1.5.2 2017-06-28 16:23:16 +01:00
Dan Abramov
42efedbeb2 Allow declaring variables before use in a scope above (#2325) 2017-05-22 16:04:35 +01:00
Robert DeLuca
3260d17f07 Remove flowtype/require-valid-file-annotation temporarily. (#2311)
Until this issue (https://github.com/gajus/eslint-plugin-flowtype/issues/165) is
fixed we're disabling `flowtype/require-valid-file-annotation`.
2017-05-21 20:42:55 +01:00
Dan Abramov
e939a5b80d Turn off operator-assignment stylistic rule (#2256) 2017-05-19 18:16:45 +01:00
Tharaka Wijebandara
54ea47815a Add documentation about using code splitting (#1801)
* Add documentation about using code splitting

* Revise docs a bit

* Update README.md

* Update README.md

* Update README.md
2017-05-19 05:05:18 +01:00
Dan Abramov
493e5a6996 Tweak lint rules (#2186) 2017-05-16 23:35:14 +01:00
Dan Abramov
dadf93b2bc Disable require.ensure() warning (#2177) 2017-05-16 15:43:51 +01:00
Dan Abramov
0ffed85e6c Bump dependencies (#2170)
* Bump dependencies

* Bump CSS deps

* Somehow I missed dotenv

* Bump ESLint deps

* Tweak ESLint rules
2017-05-16 02:59:32 +01:00
anraka
814365b4d0 Removing extra eslint rules (#2064)
Removing a stylistic lint rule
2017-05-15 23:42:46 +01:00
Almero Steyn
7bff7154d9 ESLint Config: Upgrade eslint-plugin-jsx-a11y and activate more rules. (#2163)
* ESLint Config: Upgrade eslint-plugin-jsx-a11y and activate more rules.

* Try to fix Lerna

* Update README.md

* Remove html-has-lang

* Update README.md
2017-05-15 23:25:40 +01:00
Siddharth Doshi
06e73fa6b3 Blacklist confusing global variables (#2130)
* Blacklist confusing global variables

* Blacklist globals

* Fix kitchensink test to lint

* Edit the list

* Use no-restricted globals for this
2017-05-14 19:47:04 +01:00
Siddharth Doshi
efd99a95f3 disable ignoring unused vars prefixed with _ (#1763) 2017-05-11 14:34:52 +01:00
Dan Abramov
3a527f2a09 Revert "Forbid using window properties as global variables" (#2099)
* Revert "Ignore the yarn cache directory (#2063)"

This reverts commit 94149c77a8.

* Revert "Forbid using window properties as global variables (#1840)"

This reverts commit 5a7d8e899e.
2017-05-08 19:26:03 +01:00
Siddharth Doshi
5a7d8e899e Forbid using window properties as global variables (#1840)
* Forbid using window properties as global variables

* Change globals list to match Standard.

* Fix globals
2017-05-05 18:59:49 -04:00
anilreddykatta
a0b16df53f Relax label rules (#1989) 2017-04-18 21:28:10 -04:00
Ben Alpert
9c9f8f66e2 Remove 'guard-for-in' lint rule (#1773)
Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?
2017-03-09 03:49:34 +00:00
Valerii Sorokobatko
fe7b5c212b update to modern code style (#1738)
* mv create-react-app/index.js -> create-react-app/creteReactApp.js

* update to modern code style

* var -> cosnt

* set trailing-coma to es5 for prettier
2017-03-07 19:46:10 +00:00
Dan Abramov
2f7e3a2168 Lint internal scripts with eslint:recommended (#1729)
* Lint internal scripts with eslint:recommended

* Warnings r bad
2017-03-05 22:29:28 +00:00
Chris Drackett
19a46724fb Add support for ignoreRestSiblings in no-unused-vars (#1705)
* updating eslint to 3.16.1

* add support for ignoreRestSiblings in eslint

http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings

* updating eslint to 3.16.1 in `react-scripts`

* updating eslint

* missing `^`

* missing ^

* pinning main eslint and updating readme

* Pin ESLint version
2017-03-05 14:54:33 +00:00
Vlad
dd801e218c Disallow event global variable with no-restricted-globals rule (#1530) (#1532)
* Disallow event global variable with no-restricted-globals rule (#1530)

* changed event global variable usage liniting from warn to error
2017-02-24 19:29:04 +00:00
Tharaka Wijebandara
09cfcde018 Add lint rule to disallow require.ensure and System.import (#1536) 2017-02-24 17:29:45 +00:00
Brian Ng
15f65a0a4e Make jsx-no-undef rule an error (#1159) 2016-12-05 19:59:25 +00:00
Stefan
6e00813632 Adapt jest and eslint for new default loader scope. (#1077)
Revert webpack prod config comments to not refer to dev server.
2016-11-22 00:03:40 +02:00
Vadzim
8a5c50d97a Fixes https://github.com/facebookincubator/create-react-app/issues/952 (#953) 2016-10-28 13:51:56 +01:00
Ville Immonen
27500900af Forbid Webpack loader syntax in imports (#803)
Enable no-webpack-loader-syntax rule in eslint-config-react-app.
2016-10-22 23:11:25 +03:00
Dan Abramov
68d9ff6d6a Promote "React must be in scope" to be an error (#822) 2016-10-03 12:37:35 +01:00
Brian Ng
909d938166 Fix some typos (#809) 2016-10-01 12:13:42 +03:00
Aaron Cannon
90e3cc1fb2 Relaxed eslint rule no-unused-expressions (#724)
Now allows the use of short circuit and ternary expressions.
2016-09-30 13:20:24 +01:00
Ville Immonen
2ed2b59a69 Update eslint-plugin-react and enable new rules (#696)
* Update eslint-plugin-react and enable new rules

New rules:
* `react/no-danger-with-children` (yannickcr/eslint-plugin-react#710)
* `react/no-find-dom-node` (yannickcr/eslint-plugin-react#678)
* `react/style-prop-object` (yannickcr/eslint-plugin-react#715)

* Remove react/no-find-dom-node for now
2016-09-22 13:58:23 +01:00
Ville Immonen
a2d0469c39 Create a shareable ESLint configuration package (#689)
* Move ESLint configuration to a separate package

* Remove the ESLint configuration, moved to eslint-config-react-app

* Update ESLint instructions

* Pin the package versions in eslint-config-react-app

* Add a README for eslint-config-react-app

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update package.json

* Update package.json

* Update production eslint-loader config

* Add the ESLint config to devDependencies of the repo
2016-09-21 15:08:02 +01:00