kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-04-28 09:25:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Forbid using window properties as global variables" (#2099)

Browse Source 
* Revert "Ignore the yarn cache directory (#2063)"

This reverts commit 94149c77a8.

* Revert "Forbid using window properties as global variables (#1840)"

This reverts commit 5a7d8e899e.
This commit is contained in:
Dan Abramov
2017-05-08 19:26:03 +01:00
committed by GitHub
parent 94149c77a8
commit 3a527f2a09
4 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/eslint-config-react-app/index.js
View File

@@ -26,19 +26,13 @@ module.exports = {
plugins: ['import', 'flowtype', 'jsx-a11y', 'react'],
env: {
browser: true,
commonjs: true,
es6: true,
jest: true,
node: true,
},
globals: {
document: true,
window: true,
console: true,
navigator: true
},
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',

4
packages/react-scripts/fixtures/kitchensink/src/App.js vendored
View File

@@ -26,7 +26,7 @@ class BuiltEmitter extends Component {
}
handleReady() {
document.dispatchEvent(new window.Event('ReactFeatureDidMount'));
document.dispatchEvent(new Event('ReactFeatureDidMount'));
}
render() {
@@ -54,7 +54,7 @@ class App extends Component {
}
componentDidMount() {
const feature = window.location.hash.slice(1);
const feature = location.hash.slice(1);
switch (feature) {
case 'array-destructuring':
import(

2
packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js vendored
View File

@@ -11,7 +11,7 @@ import React from 'react';
import aFileWithoutExt from './assets/aFileWithoutExt';
const text = aFileWithoutExt.includes('base64')
? window.atob(aFileWithoutExt.split('base64,')[1]).trim()
? atob(aFileWithoutExt.split('base64,')[1]).trim()
: aFileWithoutExt;
export default () => (

2
packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js vendored
View File

@@ -11,7 +11,7 @@ import React from 'react';
import aFileWithExtUnknown from './assets/aFileWithExt.unknown';
const text = aFileWithExtUnknown.includes('base64')
? window.atob(aFileWithExtUnknown.split('base64,')[1]).trim()
? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
: aFileWithExtUnknown;
export default () => (