kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-06-18 03:58:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #143 from swengorschewski/dependencies

Browse Source 
Install typings as dev dependencies
This commit is contained in:
Will Monk
2017-08-22 13:48:05 +01:00
committed by GitHub
parent d0d51332ab 6ae7751218
commit e87df91de8
1 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
packages/react-scripts/scripts/init.js vendored
View File

@@ -45,8 +45,6 @@ module.exports = function(
eject: 'react-scripts-ts eject',
};
console.log(appPackage);
fs.writeFileSync(
path.join(appPath, 'package.json'),
JSON.stringify(appPackage, null, 2)
@@ -104,6 +102,23 @@ module.exports = function(
args = ['install', '--save', verbose && '--verbose'].filter(e => e);
}
// Install dev dependencies
const types = [
'@types/node',
'@types/react',
'@types/react-dom',
'@types/jest',
];
console.log(`Installing ${types.join(', ')} as dev dependencies ${command}...`);
console.log();
const devProc = spawn.sync(command, args.concat('-D').concat(types), { stdio: 'inherit' });
if (devProc.status !== 0) {
console.error(`\`${command} ${args.concat(types).join(' ')}\` failed`);
return;
}
// Install additional template dependencies, if present
const templateDependenciesPath = path.join(
appPath,
@@ -119,22 +134,6 @@ module.exports = function(
fs.unlinkSync(templateDependenciesPath);
}
const types = [
'@types/node',
'@types/react',
'@types/react-dom',
'@types/jest',
];
console.log(`Installing ${types.join(', ')} ${command}...`);
console.log();
const proc = spawn.sync(command, args.concat(types), { stdio: 'inherit' });
if (proc.status !== 0) {
console.error(`\`${command} ${args.concat(types).join(' ')}\` failed`);
return;
}
// Install react and react-dom for backward compatibility with old CRA cli
// which doesn't install react and react-dom along with react-scripts
// or template is presetend (via --internal-testing-template)