kylefang/boxen
1
0
Fork 0
mirror of https://github.com/zhigang1992/boxen.git synced 2026-06-14 17:39:14 +08:00
Code Issues Packages Projects Releases Wiki Activity
139 Commits 8 Branches 24 Tags
runner
Commit Graph

86 Commits

Author SHA1 Message Date
Yossef Mendelssohn
2c2c24a4ba Oh hey maybe I should commit the code too 
cf. 739e8a5ef9
 2012-10-11 12:29:38 -04:00
Yossef Mendelssohn
2d33c44b57 Use that Boxen::Service in the Runner 
Isn't that so much nicer?

Yes, yes it is.
 2012-10-11 12:21:13 -04:00
Yossef Mendelssohn
329d4efe66 an wild Boxen::Service appears! 
This could be cleaned up more, what with the com.boxen.*.plist
repetition. Later.
 2012-10-11 12:16:05 -04:00
Yossef Mendelssohn
ce4f86f35c Don't abort for help display 
`abort` is a quick way to print-and-quit, but asking for help isn't the
same as the command failing.
 2012-10-11 11:59:40 -04:00
Yossef Mendelssohn
d5c0e5b5df calm down on the Struct tricks, I guess 
@jbarnette got totally concern :trollface: about this
 2012-10-10 23:35:25 -04:00
Yossef Mendelssohn
f1f695f6f6 Extract service-listing to a separate method 
Ugh, this could be even nicer if `launchctl` could take the 'human
name'. Going to ponder further.
 2012-10-10 23:28:40 -04:00
Yossef Mendelssohn
049abb6852 Extract flag-checking from Runner#process 2012-10-10 13:12:25 -04:00
Yossef Mendelssohn
1de664a8a6 Move help display back to CLI from Runner 
This is difficult to test because of that `abort` call.

Do we actually want the help to result in printing to stderr and
exiting with code 1?
 2012-10-10 13:06:40 -04:00
Yossef Mendelssohn
47b42ab439 Use Puppet::Status instead of exit code 2012-10-10 12:44:26 -04:00
Yossef Mendelssohn
bddede55b6 Add logic to Puppet status code 
This is used in multiple places now, and it should be boxed up with the
Puppet status anyway.
 2012-10-10 12:41:50 -04:00
Yossef Mendelssohn
26e2899728 Extract CLI#run to a Runner class 2012-10-10 12:35:30 -04:00
Will Farrington
79c6ef595a add cli support for --list-services, --enable-services, and --disable-services 2012-10-09 07:54:06 -10:00
Will Farrington
ca02b6aa6a add --list-services, --enable-services, --disable-services flags 2012-10-09 07:27:27 -10:00
Will Farrington
cf1638142f make successful_exit_code? a class method on CLI for consistency 2012-10-05 17:29:29 -10:00
Will Farrington
e0951c354c support puppet's detailed exit codes for issue reporting /cc @ymendel 2012-10-05 17:21:52 -10:00
Will Farrington
add1952393 redisable caffeinate 2012-10-05 11:53:43 -10:00
Yossef Mendelssohn
e38377985b Merge pull request #9 from boxen/errors 
WIP: Error Reporting
 2012-10-05 14:42:10 -07:00
Yossef Mendelssohn
f0a9ad99e0 Refactoring CLI#run 
If reporting is going to live within/around CLI#run, I want it to be
its own thing. It feels more right this way, except I don't much like
the `process` method name. I just don't have a good name for "actual
run" where "run" has been co-opted to mean "report on the actual run".
 2012-10-05 15:44:27 -04:00
Yossef Mendelssohn
ea7719caa1 report → reporter 
It makes more sense this way. I was trying too hard on the length
instead of the content.
 2012-10-05 15:39:18 -04:00
Yossef Mendelssohn
9fe1b631fd ivar → attr 2012-10-05 15:34:23 -04:00
Yossef Mendelssohn
66c4796f3e Don't affect issues unless it's wanted 2012-10-05 02:16:55 -04:00
Yossef Mendelssohn
1a1070f04e Check for whether issues should be affected 2012-10-05 02:14:33 -04:00
Yossef Mendelssohn
6c879a8dc4 Give CLI a Checkout, too 
It'll need this to check for master branch.

It's all coming together.
 2012-10-05 02:05:41 -04:00
Yossef Mendelssohn
e1a5da7a55 Move master? from Config to Checkout 
It belongs with sha/changes/dirty?, and you know it.
 2012-10-05 02:04:17 -04:00
Yossef Mendelssohn
988c9803bb Report failure/success of CLI#run 
There's some repetition I'm not sure about here. I went with what the
comment said, though.
 2012-10-05 01:56:54 -04:00
Yossef Mendelssohn
71edf89ddf Add Reporter to CLI 2012-10-05 01:42:16 -04:00
Yossef Mendelssohn
d9264b31f8 line shortening and cleanup 2012-10-05 00:16:41 -04:00
John Barnette
77ae71a255 Squash dat system_timer message 2012-10-04 21:13:37 -07:00
Yossef Mendelssohn
71fadf88a7 Move sha from Reporter to Checkout 2012-10-04 23:37:45 -04:00
Yossef Mendelssohn
96b8f94111 Add comment when auto-closing issues 2012-10-04 23:32:20 -04:00
Yossef Mendelssohn
9c73e9104d Can label ongoing failures to leave them open 2012-10-04 23:23:42 -04:00
Yossef Mendelssohn
0caeeb14b4 Reporter can also close failures 
This refers to the auto-opened failures, so we're looking for open
issues on this repo created by the same user and having the failure
label.
 2012-10-04 23:15:14 -04:00
Yossef Mendelssohn
e02a63cdb9 Remove changes/dirty? from Config 2012-10-04 22:45:22 -04:00
Yossef Mendelssohn
821e30aa3a Use changes from Checkout instead of Config 2012-10-04 22:44:33 -04:00
Yossef Mendelssohn
e82f191f7f chdir when checking local changes 
This seems like an oversight in the original code.
 2012-10-04 22:40:38 -04:00
Yossef Mendelssohn
6926afea96 Add Boxen::Checkout 
This class handles the local checkout of the boxen/boxen repo. Y'know,
things like saying whether there are changes.
 2012-10-04 22:38:03 -04:00
Yossef Mendelssohn
10ca468bc1 Make failure label customizable 2012-10-04 22:27:56 -04:00
Yossef Mendelssohn
bf97e2b7a4 Add puppet command to failure details 
Now the Reporter needs to know about the Puppeteer as well.

I'm not sure how I feel about a method called `command` returning an
array and consumers of that method needing to know to join it. On the
other hand, I don't really want to have a method called
`command_string`. It's kind of a dumb name.

It also makes the mock objects used in the tests more hairy, but those
should be ripped out and replaced with actual objects soon enough.
 2012-10-04 17:53:51 -04:00
Tim Sharpe
548a9659d0 s/GH/BOXEN/ 2012-10-04 13:55:03 -07:00
Yossef Mendelssohn
484e2c9df9 add failure label to created issue 
We may want to make this label configurable, and also create it if
necessary.
 2012-10-04 16:47:15 -04:00
Yossef Mendelssohn
50ec7f93c2 config ivar → attr_reader 2012-10-04 16:44:11 -04:00
Yossef Mendelssohn
e67995526a Add log to failure details 
Adding Reporter#log and tests.
 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
f846c5e7d7 Add changes to failure details 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
acfe3095ec Add Config#changes and tests for it and #dirty? 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
cbc429959f Add Reporter#failure_details 
Starting this off, more details forthcoming.
 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
b06c33434b Add Reporter#record_failure 2012-10-04 16:26:05 -04:00
John Barnette
1700c8e258 Expose a boxen_user fact and deprecate luser 2012-10-04 13:05:06 -07:00
John Barnette
4e051a10c4 Start extracting/porting a Boxen::Reporter 2012-10-03 21:59:16 -07:00
John Barnette
d00ea25ee3 Add Config#reponame 2012-10-03 21:36:06 -07:00
John Barnette
bb56d27ab1 Add a boxen_repodir fact 2012-10-03 18:56:06 -07:00