kylefang/boxen
1
0
Fork 0
mirror of https://github.com/zhigang1992/boxen.git synced 2026-04-29 04:24:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

report → reporter

Browse Source 
It makes more sense this way. I was trying too hard on the length
instead of the content.
This commit is contained in:
Yossef Mendelssohn
2012-10-05 15:39:18 -04:00
parent 9fe1b631fd
commit ea7719caa1
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/boxen/cli.rb
View File

@@ -13,14 +13,14 @@ module Boxen
attr_reader :flags
attr_reader :puppet
attr_reader :checkout
attr_reader :report
attr_reader :reporter
def initialize(config, flags)
@config = config
@flags = flags
@puppet = Boxen::Puppeteer.new @config
@checkout = Boxen::Checkout.new(@config)
@report = Boxen::Reporter.new(@config, @checkout, @puppet)
@reporter = Boxen::Reporter.new(@config, @checkout, @puppet)
end
def run
@@ -53,10 +53,10 @@ module Boxen
# Report errors
if result.zero?
report.close_failures
reporter.close_failures
else
warn "Sorry! Creating an issue on #{config.reponame}."
report.record_failure
reporter.record_failure
end
result

24
test/boxen_cli_test.rb
View File

@@ -18,10 +18,10 @@ class BoxenCLITest < Boxen::Test
assert_equal flags, cli.flags
assert_equal config, cli.puppet.config
assert_equal config, cli.report.config
assert_equal config, cli.report.checkout.config
assert_equal cli.checkout, cli.report.checkout
assert_equal cli.puppet, cli.report.puppet
assert_equal config, cli.reporter.config
assert_equal config, cli.reporter.checkout.config
assert_equal cli.checkout, cli.reporter.checkout
assert_equal cli.puppet, cli.reporter.puppet
end
def test_issues?
@@ -68,8 +68,8 @@ class BoxenCLITest < Boxen::Test
@cli.stubs(:issues?).returns(true)
@cli.puppet.stubs(:run).returns(1)
@cli.report.expects(:record_failure)
@cli.report.expects(:close_failures).never
@cli.reporter.expects(:record_failure)
@cli.reporter.expects(:close_failures).never
@cli.run
end
@@ -80,8 +80,8 @@ class BoxenCLITest < Boxen::Test
@cli.stubs(:issues?).returns(true)
@cli.puppet.stubs(:run).returns(0)
@cli.report.expects(:record_failure).never
@cli.report.expects(:close_failures)
@cli.reporter.expects(:record_failure).never
@cli.reporter.expects(:close_failures)
@cli.run
end
@@ -92,8 +92,8 @@ class BoxenCLITest < Boxen::Test
@cli.stubs(:issues?).returns(false)
@cli.puppet.stubs(:run).returns(1)
@cli.report.expects(:record_failure).never
@cli.report.expects(:close_failures).never
@cli.reporter.expects(:record_failure).never
@cli.reporter.expects(:close_failures).never
@cli.run
end
@@ -104,8 +104,8 @@ class BoxenCLITest < Boxen::Test
@cli.stubs(:issues?).returns(false)
@cli.puppet.stubs(:run).returns(0)
@cli.report.expects(:record_failure).never
@cli.report.expects(:close_failures).never
@cli.reporter.expects(:record_failure).never
@cli.reporter.expects(:close_failures).never
@cli.run
end