Commit Graph

4847 Commits

Author SHA1 Message Date
Freek Wielstra
1fe0d9990e docs($http): clear up Interceptor docs and code
The documentation and code example of $http interceptors is unclear about whether config can be null
or not, and whether the result should always be a promise or not. This pr clears up the documentation
a bit and removes the literal 'or a promise' interpretation of the docs in the code example.

Closes #7431
Closes #7460
2014-05-21 15:35:55 -07:00
NateRedding
f2f5a1dd39 docs(ngHide): corrected logic in example
Closes #7436
2014-05-21 15:26:29 -07:00
Peter Bacon Darwin
b696822c1c docs(misc/downloading): fix HTML example formatting
Closes #7060
2014-05-21 22:33:43 +01:00
Brice
b5fb2d4bec docs(tutorial): improve instructions for causing test failure (step 2)
Increase readability for test fail line

Closes #6943
2014-05-21 17:32:04 -04:00
specialorange
6c3a0519fa docs(error/$injector/unpr): clarify which code is being referred to in the text
Closes #7020
2014-05-21 22:26:43 +01:00
Edward Brey
510c328d74 docs(filter): description formatting fix
as it was, the third parameter's description was displayed as
a code block, rather than a bulletted list.
2014-05-21 13:57:25 -07:00
Tim van den Eijnden
d3163ff1cf docs(tutorial): fix controller unit tests to match phonecat / avoid ReferenceError
fix 'ReferenceError: PhoneDetailCtrl is not defined' & 'ReferenceError: PhoneListCtrl is not defined' in Karma unit tests

Closes #7421
2014-05-21 16:37:47 -04:00
Adam Bradley
b64c709808 docs(css): remove Firefox select element drop-down icon
In firefox the version picker's dropdown icon from the default `select` element
is still showing. This CSS forces FF to hide the ugly default.

Closes #6878
2014-05-21 21:33:56 +01:00
kalvn
0a3268f106 docs(tutorial): corrected version of jquery installed via bower (step 12)
Corrected the version of jquery in the text content.

Closes #7441
2014-05-21 16:29:57 -04:00
James Vanneman
636b3799b3 docs($filter): add runnable example
Closes #6871
2014-05-21 21:26:20 +01:00
Richard Littauer
ff16d224ca test(ngClass): add missing assertions 2014-05-21 13:23:30 -07:00
ABitTooCalm
d02fa32f36 docs(ngStyle): clarify using styles that are not valid property names
Closes #6838
2014-05-21 21:07:13 +01:00
Andrew Mortimer
f5f1fd1963 docs(guide/controller): fix typo 2014-05-21 12:31:26 -07:00
Kristof Mattei
84402b11c8 docs(shallowCopy): fixed typo
Closes #7456
2014-05-21 11:41:57 -07:00
Tobias Bosch
d606e66f7a docs(ngModelController): use $sce and $sanitize in the contenteditable example.
Closes #7464
2014-05-21 11:36:34 -07:00
Tobias Bosch
326fd809c8 docs(): mention implicit usage of 2014-05-21 11:23:38 -07:00
markau
bdfbceb3d3 docs(guide/concepts): The service is finance2.js
Closes #7470
2014-05-21 10:47:21 -07:00
Tobias Bosch
f9264eec07 docs(guide/concepts): clarify definitions 2014-05-21 10:47:09 -07:00
Sergei Z
854bf5b74d feat(ngMock): add support of mocha tdd interface
Closes #7489
2014-05-21 10:43:32 -07:00
Erich
9fb0e16719 docs(guide/concepts): clarify definitions
Closes #7483
2014-05-21 10:33:11 -07:00
Sam Dornan
20221f9582 docs(guide/services): fix link to minify Wikipedia page
Closes #7488
2014-05-21 10:29:13 -07:00
Yaron Uliel
7e4598663a docs(ngRepeat): fix formatting 2014-05-21 10:27:37 -07:00
Takashi Nakagawa
21a3cea657 docs(ngModelController): fix indentation code block
Closes #6660
2014-05-21 17:09:37 +01:00
Caitlin Potter
d8c55864d0 docs(guide/$location): clarify "$watchers" / "$observers" terminology with links
Add links to API docs for Scope#$watch and Attributes#$observe in $location in order to clarify
the meaning of that terminology.

Closes #7497
2014-05-21 11:58:52 -04:00
Firexion
92f588cd15 docs(tutorial): add <span> to index.html to match phonecat step4
Add missing <span> to app/index.html to match actual code on github

☆.。.:*・゜☆ Merci beaucoup! ☆.。.:*・゜☆

Closes #7520
2014-05-21 11:28:17 -04:00
GSC Leticia
ef13820cad docs(tutorial): add instructions for running node in Debian-based distributions
Specifying command for Debian based distributions, like Ubuntu, Mint, etc.

☆.。.:*・゜☆ Fantastique! ☆.。.:*・゜☆

Closes #7422
2014-05-21 11:20:20 -04:00
Sam Dornan
6cb35adfe8 chore(rootScope): fix grammar in a test description
it's -> its

☆.。.:*・゜☆ Yeah, why not ☆.。.:*・゜☆

Closes #7534
2014-05-21 10:41:47 -04:00
Peter Bacon Darwin
e3375ae37e docs(guide/expression): mention the ternary operator
Closes #6498
2014-05-21 14:46:05 +01:00
Peter Bacon Darwin
826450da20 docs($compile): remove reference to ngRepeat providing compile function
ngRepeat no longer has the compile function in its directive definition
object, since it retrieves its transclusion via the link function.

Closes 5638
2014-05-21 14:27:06 +01:00
Peter Bacon Darwin
16a7d54351 docs(tutorial/step-5): update image to match code
Closes #2753
2014-05-21 13:58:36 +01:00
Eli Dalbey
9332439d1d docs(guide/concepts-module-service.png): Typo in image
The ng-app was called ng=app in diagram image.

Closes #6473
Closes #7528
2014-05-21 12:51:13 +01:00
Wes Alvaro
ad0d3e0f1b docs(ngRoute): $routeParams is Object.<string, string>
Closes #7386
2014-05-21 12:48:37 +01:00
Igor Minar
82f45aee5b fix(Scope): $broadcast and $emit should set event.currentScope to null
When a event is finished propagating through Scope hierarchy the event's `currentScope` property
should be reset to `null` to avoid accidental use of this property in asynchronous event handlers.

In the previous code, the event's property would contain a reference to the last Scope instance that
was visited during the traversal, which is unlikely what the code trying to grab scope reference expects.

BREAKING CHANGE: $broadcast and $emit will now reset the `currentScope` property of the event to
null once the event finished propagating. If any code depends on asynchronously accessing thei
`currentScope` property, it should be migrated to use `targetScope` instead. All of these cases
should be considered programming bugs.

Closes #7445
Closes #7523
2014-05-21 00:20:20 -07:00
Ralph Giles
def5b57de8 docs(*): fix its vs it's typos.
Only use the apostrophe if you can expand "it's" to "it is" and
still have a grammatical phrase.

Closes #7524
2014-05-20 17:45:08 -04:00
Caitlin Potter
6b5284807a docs($interpolate): replace jerk with something nicer/more neutral
I thought `jerk` illustrated the "defacing" factor nicely, but I suppose it's not very nice to have
in official documentation.
2014-05-20 16:04:21 -04:00
Caitlin Potter
e3f78c17d3 feat($interpolate): escaped interpolation expressions
This CL enables interpolation expressions to be escaped, by prefixing each character of their
start/end markers with a REVERSE SOLIDUS U+005C, and to render the escaped expression as a
regular interpolation expression.

Example:

`<span ng-init="foo='Hello'">{{foo}}, \\{\\{World!\\}\\}</span>` would be rendered as:
`<span ng-init="foo='Hello'">Hello, {{World!}}</span>`

This will also work with custom interpolation markers, for example:

     module.
       config(function($interpolateProvider) {
         $interpolateProvider.startSymbol('\\\\');
         $interpolateProvider.endSymbol('//');
       }).
       run(function($interpolate) {
         // Will alert with "hello\\bar//":
         alert($interpolate('\\\\foo//\\\\\\\\bar\\/\\/')({foo: "hello", bar: "world"}));
       });

This change effectively only changes the rendering of these escaped markers, because they are
not context-aware, and are incapable of preventing nested expressions within those escaped
markers from being evaluated.

Therefore, backends are encouraged to ensure that when escaping expressions for security
reasons, every single instance of a start or end marker have each of its characters prefixed
with a backslash (REVERSE SOLIDUS, U+005C)

Closes #5601
Closes #7517
2014-05-20 15:41:20 -04:00
Igor Minar
e994259739 revert: fix($compile): pass transcludeFn down to nested transclude directives
This reverts commit 113850602d.

This change introduced regressions for several scenarios.

reduction: http://jsfiddle.net/5242N/4/
2014-05-20 11:00:26 -07:00
Gaëtan PRIOUR
f34de0ba35 docs(tutorial): fixed path to controllersSpec.js file
☆.。.:*・゜☆ DOMO ARIGATO MR ROBOTO ☆.。.:*・゜☆

Closes #7504
2014-05-20 12:16:27 -04:00
Vojta Jina
95cdb53e83 chore(travis/e2e): use Chrome on Mac
Because of this[1] issue, which is Linux specific, we see very frequent failures.

[1]: https://code.google.com/p/chromedriver/issues/detail?id=467
2014-05-20 08:46:26 +02:00
Vojta Jina
6708feffdb chore(travis/e2e): update Chrome to v34
See 28ef2637c1
2014-05-20 08:46:26 +02:00
Vojta Jina
6898ac5985 chore(travis): use latest selenium on SL 2014-05-20 08:46:26 +02:00
Vojta Jina
63e13a4df7 chore(travis): use SauceConnect v4
See https://saucelabs.com/docs/connect
2014-05-20 08:46:26 +02:00
Andrey Sidorov
35e53ca649 docs(guide): correct order of directive arguments within the animations chapter
Closes #7482
2014-05-19 14:27:58 -04:00
Igor Minar
e927193de0 perf($interpolate): optimize value stringification
previously we stringified numbers via toJson which was expensive, I optimized
the code so that toJson is invoked only if really necessary

Closes #7501
2014-05-19 06:29:07 -07:00
Diego Plentz
0dfbf8ad67 docs(guide/$location) remove duplicate 'Crawling your app' section
The "Crawling your app" section was duplicated.
I just removed the duplication and moved the section to the 'Caveats' section.

Closes #7244
2014-05-19 14:05:46 +01:00
Kebabpizza
d8bc44b7e9 docs(tutorial): fix link to bower in step 12
Muchas gracias! \o/

Closes #7507
2014-05-18 20:46:54 -04:00
Shahar Talmi
facd904a61 fix(ngModel): do not dirty the input on $commitViewValue if nothing was changed
Calling `$commitViewValue` was was dirtying the input, even if no update to the view
value was made.
For example, `updateOn` triggers and form submit may call `$commitViewValue` even
if the the view value had not changed.

Closes #7457
Closes #7495
2014-05-18 08:35:21 +01:00
Brian Ford
96fa70511d test($compile): use trim helper 2014-05-16 18:18:26 -07:00
Brian Ford
819dd5df92 docs(changelog): release notes for 1.3.0-beta.9 release-naming v1.3.0-beta.9 2014-05-16 15:14:12 -07:00
Shahar Talmi
5fbd618c2f fix(ngClass): handle index changes when an item is unshifted
Closes #7256
2014-05-16 14:02:41 -07:00