kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-01-12 22:45:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat($cookieStore): $cookieStore.get now parses blank string as blank string

Browse Source 
closes #1918
This commit is contained in:
Illniyar
2013-04-20 23:33:40 +03:00
committed by Pete Bacon Darwin
parent 4f2e360685
commit cf4729faa3
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ngCookies/cookies.js
View File

@@ -139,7 +139,8 @@ angular.module('ngCookies', ['ng']).
* @returns {Object} Deserialized cookie value.
*/
get: function(key) {
return angular.fromJson($cookies[key]);
var value = $cookies[key];
return value ? angular.fromJson(value) : value;
},
/**

11
test/ngCookies/cookiesSpec.js
View File

@@ -125,4 +125,15 @@ describe('$cookieStore', function() {
$rootScope.$digest();
expect($browser.cookies()).toEqual({});
}));
it('should handle empty string value cookies', inject(function ($cookieStore, $browser, $rootScope) {
$cookieStore.put("emptyCookie",'');
$rootScope.$digest();
expect($browser.cookies()).
toEqual({ 'emptyCookie': '""' });
expect($cookieStore.get("emptyCookie")).toEqual('');
$browser.cookieHash['blankCookie'] = '';
$browser.poll();
expect($cookieStore.get("blankCookie")).toEqual('');
}))
});