kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-04-07 08:57:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(select): relax test for IE8 bug

Browse Source 
There is a bug in IE8 (http://support.microsoft.com/kb/829907 and
http://yuilibrary.com/forum-archive/forum/viewtopic.php@p=14826.html):
when you clone an `<option>` element the selected attribute on the options
can become invalid.

This is not relevant to the proper behaviour of the `select` directive
since it uses `prop` not `attr` to store the selected status of each
option.

This test is only interested in there being at least on option with
the `selected` attribute, for conformance to accessibility guidelines.
So we can safely relax the test to check this rather than concerning
ourselves with which option actually has this attribute.

Fixes 79538afd7b
Closes #8465
This commit is contained in:
Peter Bacon Darwin
2014-08-03 22:05:22 +01:00
parent 2a6081057f
commit 29eaabc000
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/ng/directive/selectSpec.js
View File

@@ -997,6 +997,15 @@ describe('select', function() {
it('should ensure that at least one option element has the "selected" attribute', function() {
function countSelected() {
var count = 0;
forEach(element.find('option'), function(option) {
count += option.getAttribute('selected') ? 1 : 0;
});
return count;
}
createSelect({
'ng-model': 'selected',
'ng-options': 'item.id as item.name for item in values'
@@ -1006,34 +1015,34 @@ describe('select', function() {
scope.values = [{id: 10, name: 'A'}, {id: 20, name: 'B'}];
});
expect(element.val()).toEqual('?');
expect(element.find('option').eq(0).attr('selected')).toEqual('selected');
expect(countSelected()).toEqual(1);
scope.$apply(function() {
scope.selected = 10;
});
// Here the ? option should disappear and the first real option should have selected attribute
expect(element.val()).toEqual('0');
expect(element.find('option').eq(0).attr('selected')).toEqual('selected');
expect(countSelected()).toEqual(1);
// Here the selected value is changed but we don't change the selected attribute
scope.$apply(function() {
scope.selected = 20;
});
expect(element.val()).toEqual('1');
expect(element.find('option').eq(0).attr('selected')).toEqual('selected');
expect(countSelected()).toEqual(1);
scope.$apply(function() {
scope.values.push({id: 30, name: 'C'});
});
expect(element.val()).toEqual('1');
expect(element.find('option').eq(0).attr('selected')).toEqual('selected');
expect(countSelected()).toEqual(1);
// Here the ? option should reappear and have selected attribute
scope.$apply(function() {
scope.selected = undefined;
});
expect(element.val()).toEqual('?');
expect(element.find('option').eq(0).attr('selected')).toEqual('selected');
expect(countSelected()).toEqual(1);
});
});