kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-01-12 22:45:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refact(ngSwitch): don't create extra function in for loop

Browse Source 
Closes #8927
This commit is contained in:
Peter Bacon Darwin
2014-09-04 13:00:05 +01:00
parent 712299c2a2
commit 02bada130e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ng/directive/ngSwitch.js
View File

@@ -144,6 +144,10 @@ var ngSwitchDirective = ['$animate', function($animate) {
previousLeaveAnimations = [],
selectedScopes = [];
var spliceFactory = function(array, index) {
return function() { array.splice(index, 1); };
};
scope.$watch(watchExpr, function ngSwitchWatchAction(value) {
var i, ii;
for (i = 0, ii = previousLeaveAnimations.length; i < ii; ++i) {
@@ -155,11 +159,7 @@ var ngSwitchDirective = ['$animate', function($animate) {
var selected = getBlockNodes(selectedElements[i].clone);
selectedScopes[i].$destroy();
var promise = previousLeaveAnimations[i] = $animate.leave(selected);
promise.then((function(i) {
return function(){
previousLeaveAnimations.splice(i, 1);
};
}(i)));
promise.then(spliceFactory(previousLeaveAnimations, i));
}
selectedElements.length = 0;