Commit Graph

1159 Commits

Author SHA1 Message Date
Brian Morton
9d5e142d10 Clean up documentation and organize RKRequestQueue and RKRequestQueueDelegate header and implementation.
* Add appledoc section headers and reorganize methods/properties to fit into the sections.
* Fill in missing documentation, parameter definitions, and return values.
* Fix documentation formatting, styling, and placement.
* Remove appledoc signficant asterisk in implementation comment.
2012-02-09 03:02:17 -08:00
Brian Morton
642bd793ca Document and organize RKRequestCache header.
* Document entire RKRequestCache header.
* Add appledoc section headers and reorganize methods and properties to fit into sections.
* Clean up asterisk placements in variable declarations.
2012-02-09 02:19:51 -08:00
Brian Morton
e3841ea23c Clean up documentation and organization in RKRequestSerialization header and implementation.
* Add/change appledoc section headers to be consistent.
* Reorganize methods and properties to fit under their respective sections.
* Fill in missing parameter definitions and return values.
* Fix documentation formatting, styling, and placement.
* Clean up asterisk placements in variable declarations.
2012-02-09 01:41:51 -08:00
Brian Morton
55dd517e2c Clean up documentation and organization in RKRequest header.
* Add/change appledoc section headers to be consistent.
* Reorganize methods and properties to fit under their respective sections.
* Fix documentation whitespace to be consistent.
* Fill in missing documentation, parameter definitions, and return values.
* Fix documentation formatting, styling, and placement.
* Clean up asterisk placements in variable declarations.
* Fix indentation whitespace.
2012-02-09 01:31:35 -08:00
Brian Morton
308ec1e493 Clean up documentation and formatting in RKURL header and implementation.
* Add documentation and example to overview.
* Add appledoc section headers.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up whitespace inconsistencies.
* Remove appledoc significant asterisk in non-documenting comment.
2012-02-09 00:05:21 -08:00
Brian Morton
764dbdb1dc Clean up documentation and formatting in RKRequestSerializable header.
* Reorganize documentation to be included in overview.
* Clean up asterisk placements in declarations.
* Add appledoc section headers.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up whitespace inconsistencies.
2012-02-09 00:05:21 -08:00
Brian Morton
4eb9de3a34 Clean up documentation and formatting in RKReachabilityObserver header.
* Clean up asterisk placements in variable declarations.
* Add/fix appledoc section headers.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up whitespace inconsistencies.
* Reorganize section layout for documentation clarity.
2012-02-09 00:05:21 -08:00
Brian Morton
27dbacca03 Clean up documentation and formatting in RKParamsAttachment header.
* Add documentation to overview.
* Clean up asterisk placements in variable declarations.
* Add appledoc section headers.
* Reorganize methods and properties for documentation clarity.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up whitespace inconsistencies.
2012-02-09 00:05:21 -08:00
Brian Morton
a0719ac4a5 Clean up documentation and formatting in RKParams header.
* Add documentation and example to overview.
* Clean up asterisk placements in variable declarations.
* Add appledoc section headers.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up whitespace inconsistencies.
2012-02-09 00:05:21 -08:00
Brian Morton
2a787e92a8 Clean up spacing in RKNotifications constants. 2012-02-09 00:05:21 -08:00
Brian Morton
1fa3ea400d Clean up documentation and formatting in RKOAuthClient header and implementation.
* Add example code to overview.
* Move <RKRequestDelegate> implementation detail to RKOAuthClient.m to clean up documentation
* Add missing documentation to all properties and methods.
* Rearrange sections for documentation purposes.
* Format blocks of documentation to match the project standard.
* Cleanup spacing in @property lines.
* Remove delegate assignment in initializers to be consistent with the rest of the project.
* Fix spec instances where the initializer with the delegate was used.
2012-02-09 00:05:21 -08:00
Brian Morton
e1f4e452e9 Clean up documentation and organization in RKClient header.
* Reorganize blocks of deprecated methods to move them to the bottom of the file.
* Add/change appledoc section headers to be consistent.
* Reorganize methods and properties to fit under their respective sections.
* Fix documentation whitespace to be consistent.
* Fill in missing documentation, parameter definitions, and return values.
* Clean up asterisk placements in variable declarations.
2012-02-09 00:05:21 -08:00
Brian Morton
713becab7e Merge pull request #553 from bmorton/551-fix-synchronous-timeout
Fix Synchronous Request Timeout
2012-02-08 20:18:57 -08:00
Brian Morton
58102533f1 Fixes an issue where the timeoutTimer wouldn't work for a synchronous request. Fixes #551.
* Removed the timer creation in RKRequest sendSynchronously.
* Pass the timeoutInterval to the NSURLRequest that is responsible for the synchronous request.
* Check if the error returned by NSURLRequest is NSURLErrorTimedOut and return an RKRequestConnectionTimeoutError if necessary.
* Add test for making sure the timeout works properly for a synchronous request.
2012-02-08 20:06:53 -08:00
Blake Watters
e169cbca3d Migrated new files into Public/ headers for Framework target 2012-02-07 18:04:57 -05:00
Brian Morton
7c42f57219 Merge pull request #539 from bmorton/fix-baseurl-in-failing-timeout-test
Fix base URL in failing timeout test
2012-02-02 20:28:51 -08:00
Blake Watters
d4e3c0d559 Remove Appledoc significant asterisk in non-documenting comment 2012-02-02 09:21:00 -05:00
Blake Watters
7217b19839 Merge pull request #538 from bmorton/fix-and-update-appledoc
Fix and update appledoc
2012-01-30 15:38:49 -08:00
Brian Morton
16f81367d6 Fix how testShouldTimeoutAtInterval builds its URL so that the test passes again. 2012-01-28 13:46:29 -08:00
Brian Morton
f92fbb9f8e Fix issue that caused appledoc to fall over while building documentation.
There's currently a known issue for appledoc (https://github.com/tomaz/appledoc/issues/147) that causes it to fall over when it encounters a method declaration in an implementation that is missing a type (even if its in the header file).  While this is valid Objective-C, lets update this to allow appledoc to go on its merry little way.

* Fix 1 declaration relating to atKeyPath: in RKObjectMapper.m
* Fix 2 declarations relating to atKeyPath: in RKObjectMapper_Private.h
* Fix 1 declaration relating to atKeyPath: in RKObjectMappingOperation.m

All declarations were changed to declare keyPath as an (NSString *).
2012-01-28 13:40:38 -08:00
Brian Morton
104624e1fa Update appledoc and use a custom build that supports the DEPRECATED_ATTRIBUTE flag.
* Bring appledoc up-to-date with a binary from the current HEAD (2.0.5 build 752).
* Use custom forked version that allows us to use DEPRECATED_ATTRIBUTE as an alias for __attribute__((deprecated)).

The patch that we added is available here:
3e0261ae9f
2012-01-28 13:29:26 -08:00
Christopher Swasey
b3c5ba62d2 Replace the XMLParser with one based on Insert-Witty-Name/XMLReader 2012-01-24 12:01:47 -05:00
Blake Watters
a719843c91 Drop the client prefix from the SSL validation properties added to RKRequest 2012-01-24 11:47:31 -05:00
Blake Watters
9e0149fc0f Deprecate RKMakePathWithObjectAddingEscapes and cleanup usage within the Router 2012-01-24 09:51:05 -05:00
Christopher Swasey
7ea39690c5 Decouple RKResponse from sharedClient Fixes #430 2012-01-23 18:21:22 -05:00
Jeff Arena
5b9445cef0 Slight refactor of RKObjectPropertyInspector to expose a previously private, instance method as a public, class method, for use in processing transformable attributes in the associated CoreData category. Fixes #498. 2012-01-23 18:10:06 -05:00
Jeff Arena
7bf04e49ec Fix memory leaks in newly introduced queue code. Fixes #521. Fixes #522. 2012-01-23 17:52:29 -05:00
Christopher Swasey
ca82c6ca18 Fix test for pull request 519 2012-01-23 10:51:20 -05:00
Brian Morton
b0fd4d4981 Remove duplicate timer creation. Fixes #517. 2012-01-23 10:33:13 -05:00
Brian Morton
7c84d89bdf Move RKRequest timeoutTimer creation to a helper method so that we can test the number of times it is invoked. 2012-01-23 10:33:07 -05:00
Brian Morton
a4981ea0b6 Add test to make sure that only one timeoutTimer is created. 2012-01-23 10:33:02 -05:00
Jeff Arena
8b44c44b1c Add broken test validating issue described in #498 2012-01-21 14:12:40 -05:00
Jeff Arena
aac9abc0ad Audit uses of setValue:forKey: in mapping operations and replace with setValue:forKeyPath: where appropriate. Fixes #421. 2012-01-21 13:11:35 -05:00
Jeff Arena
86c87cfc96 Add a broken unit test demonstrating the issue described in #481. 2012-01-21 12:51:04 -05:00
Jeff Arena
1c32bd4275 Add test to ensure RKManagedObjectMappings are properly returned from RKDynamicObjectMappings. Appears to refute the bug assertions made in #457. 2012-01-20 17:04:43 -05:00
Jeff Arena
774f32d7db Remove use of stringByAppendingPathComponent: in RKURL init so as to handle cases where the resourcePath is longer than 1024 characters (which should never happen). Fixes #321. 2012-01-20 16:44:10 -05:00
Christopher Swasey
886ec75283 Import http://boredzo.org/iso8601parser/ and add it as a defaultDateFormatter for parsing ISO8601 strings. Fixes #438 2012-01-20 15:13:45 -05:00
Jeff Arena
700456c8eb Add support for serializing NSOrderedSet. Fixes #514. 2012-01-20 14:27:19 -05:00
Jeff Arena
c0cd23a14d Add setBody:forMIMEType: method to RKRequest. Fixes #227. 2012-01-20 14:09:25 -05:00
Jeff Arena
3b6c0a29e2 Added test for properly setting the Content-Length header for RKParams file uploads. Test appears to pass, contradicting concerns raised in #420. 2012-01-20 13:20:51 -05:00
Christopher Swasey
b1f4e1ffe5 RKObjectMappingOperation#parseDateFromString now transforms string representations of integers into dates as if they were unix timestamps 2012-01-20 12:59:16 -05:00
Jeff Arena
37f40d0d3a Add cacheTimeoutInterval as a settable property on RKClient and allow RKRequests to inherit the RKClient value when appropriate. Fixes #217 2012-01-20 12:40:50 -05:00
Jeff Arena
53ce2260bd Fixes #428, related to a misspelling in the request:didReceiveData:totalBytesReceived:totalBytesExpectedToReceive: 2012-01-20 12:13:40 -05:00
Jeff Arena
db0646ed19 Change NSNumber -> NSDate transformation to use doubleValue instead of intValue to ensure we do not lose precision on date conversion. Fixes #455. 2012-01-20 11:57:47 -05:00
Jeff Arena
507dfb0cfe Copy our requestQueue array prior to fast enumeration to ensure no mutations of the underlying array occur while we are looping 2012-01-20 11:52:37 -05:00
Jeff Arena
6e80ae62ae Fix for #486 2012-01-20 11:45:04 -05:00
Jeff Arena
c7777ffc8d Add coverage for sending synchronous requests with both object loader flavors 2012-01-20 11:32:12 -05:00
Jeff Arena
dbb12b37a8 Fix a few issues with broken tests 2012-01-20 11:29:17 -05:00
Blake Watters
bf2bfe18ff Fix inappropriate usage of URL method with NSString argument 2012-01-20 11:07:22 -05:00
Blake Watters
5bc1518cc5 Use URL mapping registration rather than directly providing an object mapping in RKKeyValueMappingExample 2012-01-20 10:21:57 -05:00