Fix static analyzer issues

This commit is contained in:
Blake Watters
2012-05-18 20:01:56 -04:00
parent 4105625776
commit 489bb0423a
6 changed files with 7 additions and 8 deletions

View File

@@ -106,11 +106,11 @@
NSError *error = nil;
NSArray *objectIDs = [self.managedObjectContext executeFetchRequest:fetchRequest error:&error];
[fetchRequest release];
if (error) {
RKLogError(@"Failed to load entity cache: %@", error);
return;
}
[fetchRequest release];
self.attributeValuesToObjectIDs = [NSMutableDictionary dictionaryWithCapacity:[objectIDs count]];
for (NSManagedObjectID *objectID in objectIDs) {

View File

@@ -15,7 +15,7 @@ RK_FIX_CATEGORY_BUG(RKObjectMappingProvider_CoreData)
- (void)setObjectMapping:(RKObjectMappingDefinition *)objectMapping forResourcePathPattern:(NSString *)resourcePath withFetchRequestBlock:(RKObjectMappingProviderFetchRequestBlock)fetchRequestBlock {
[self setEntry:[RKObjectMappingProviderContextEntry contextEntryWithMapping:objectMapping
userData:[fetchRequestBlock copy]] forResourcePathPattern:resourcePath];
userData:Block_copy(fetchRequestBlock)] forResourcePathPattern:resourcePath];
}
- (NSFetchRequest *)fetchRequestForResourcePath:(NSString *)resourcePath {

View File

@@ -126,8 +126,8 @@ NSString *RKPathAppendQueryParams(NSString *resourcePath, NSDictionary *queryPar
- (id)init {
self = [super init];
if (self) {
self.HTTPHeaders = [[NSMutableDictionary alloc] init];
self.additionalRootCertificates = [[NSMutableSet alloc] init];
self.HTTPHeaders = [NSMutableDictionary dictionary];
self.additionalRootCertificates = [NSMutableSet set];
self.defaultHTTPEncoding = NSUTF8StringEncoding;
self.cacheTimeoutInterval = 0;
self.runLoopMode = NSRunLoopCommonModes;

View File

@@ -103,8 +103,7 @@ static dispatch_queue_t defaultMappingQueue = nil;
- (id)initWithBaseURL:(RKURL *)baseURL {
self = [self init];
if (self) {
self.client = [[RKClient alloc] initWithBaseURL:baseURL];
[self.client release];
self.client = [RKClient clientWithBaseURL:baseURL];
self.acceptMIMEType = RKMIMETypeJSON;
}

View File

@@ -52,7 +52,7 @@
}
+ (RKObjectMappingProviderContextEntry *)contextEntryWithMapping:(RKObjectMappingDefinition *)mapping userData:(id)userData {
RKObjectMappingProviderContextEntry * contextEntry = [RKObjectMappingProviderContextEntry contextEntryWithMapping:mapping];
RKObjectMappingProviderContextEntry *contextEntry = [RKObjectMappingProviderContextEntry contextEntryWithMapping:mapping];
contextEntry.userData = userData;
return contextEntry;
}

View File

@@ -66,7 +66,7 @@ static NSMutableDictionary * __sharedBenchmarks = nil;
# pragma mark Initializers
+ (id)benchmarkWithName:(NSString *)name {
return [[self alloc] initWithName:name];
return [[[self alloc] initWithName:name] autorelease];
}
- (id)initWithName:(NSString *)name {