diff --git a/Code/CoreData/RKEntityByAttributeCache.m b/Code/CoreData/RKEntityByAttributeCache.m index 0cb20307..4ce93813 100644 --- a/Code/CoreData/RKEntityByAttributeCache.m +++ b/Code/CoreData/RKEntityByAttributeCache.m @@ -106,11 +106,11 @@ NSError *error = nil; NSArray *objectIDs = [self.managedObjectContext executeFetchRequest:fetchRequest error:&error]; + [fetchRequest release]; if (error) { RKLogError(@"Failed to load entity cache: %@", error); return; } - [fetchRequest release]; self.attributeValuesToObjectIDs = [NSMutableDictionary dictionaryWithCapacity:[objectIDs count]]; for (NSManagedObjectID *objectID in objectIDs) { diff --git a/Code/CoreData/RKObjectMappingProvider+CoreData.m b/Code/CoreData/RKObjectMappingProvider+CoreData.m index ceb46ef1..efdd421d 100644 --- a/Code/CoreData/RKObjectMappingProvider+CoreData.m +++ b/Code/CoreData/RKObjectMappingProvider+CoreData.m @@ -15,7 +15,7 @@ RK_FIX_CATEGORY_BUG(RKObjectMappingProvider_CoreData) - (void)setObjectMapping:(RKObjectMappingDefinition *)objectMapping forResourcePathPattern:(NSString *)resourcePath withFetchRequestBlock:(RKObjectMappingProviderFetchRequestBlock)fetchRequestBlock { [self setEntry:[RKObjectMappingProviderContextEntry contextEntryWithMapping:objectMapping - userData:[fetchRequestBlock copy]] forResourcePathPattern:resourcePath]; + userData:Block_copy(fetchRequestBlock)] forResourcePathPattern:resourcePath]; } - (NSFetchRequest *)fetchRequestForResourcePath:(NSString *)resourcePath { diff --git a/Code/Network/RKClient.m b/Code/Network/RKClient.m index 031b2b02..70eb174e 100644 --- a/Code/Network/RKClient.m +++ b/Code/Network/RKClient.m @@ -126,8 +126,8 @@ NSString *RKPathAppendQueryParams(NSString *resourcePath, NSDictionary *queryPar - (id)init { self = [super init]; if (self) { - self.HTTPHeaders = [[NSMutableDictionary alloc] init]; - self.additionalRootCertificates = [[NSMutableSet alloc] init]; + self.HTTPHeaders = [NSMutableDictionary dictionary]; + self.additionalRootCertificates = [NSMutableSet set]; self.defaultHTTPEncoding = NSUTF8StringEncoding; self.cacheTimeoutInterval = 0; self.runLoopMode = NSRunLoopCommonModes; diff --git a/Code/ObjectMapping/RKObjectManager.m b/Code/ObjectMapping/RKObjectManager.m index c3bb6fc7..846ffb33 100644 --- a/Code/ObjectMapping/RKObjectManager.m +++ b/Code/ObjectMapping/RKObjectManager.m @@ -103,8 +103,7 @@ static dispatch_queue_t defaultMappingQueue = nil; - (id)initWithBaseURL:(RKURL *)baseURL { self = [self init]; if (self) { - self.client = [[RKClient alloc] initWithBaseURL:baseURL]; - [self.client release]; + self.client = [RKClient clientWithBaseURL:baseURL]; self.acceptMIMEType = RKMIMETypeJSON; } diff --git a/Code/ObjectMapping/RKObjectMappingProviderContextEntry.m b/Code/ObjectMapping/RKObjectMappingProviderContextEntry.m index 5abd458a..da328f18 100644 --- a/Code/ObjectMapping/RKObjectMappingProviderContextEntry.m +++ b/Code/ObjectMapping/RKObjectMappingProviderContextEntry.m @@ -52,7 +52,7 @@ } + (RKObjectMappingProviderContextEntry *)contextEntryWithMapping:(RKObjectMappingDefinition *)mapping userData:(id)userData { - RKObjectMappingProviderContextEntry * contextEntry = [RKObjectMappingProviderContextEntry contextEntryWithMapping:mapping]; + RKObjectMappingProviderContextEntry *contextEntry = [RKObjectMappingProviderContextEntry contextEntryWithMapping:mapping]; contextEntry.userData = userData; return contextEntry; } diff --git a/Code/Support/RKBenchmark.m b/Code/Support/RKBenchmark.m index 10d1cb86..99124cb7 100644 --- a/Code/Support/RKBenchmark.m +++ b/Code/Support/RKBenchmark.m @@ -66,7 +66,7 @@ static NSMutableDictionary * __sharedBenchmarks = nil; # pragma mark Initializers + (id)benchmarkWithName:(NSString *)name { - return [[self alloc] initWithName:name]; + return [[[self alloc] initWithName:name] autorelease]; } - (id)initWithName:(NSString *)name {