kylefang/ProMotion
1
0
Fork 0
mirror of https://github.com/zhigang1992/ProMotion.git synced 2026-01-12 22:49:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #633 from clearsightstudio/warn_private_on_return_method

Browse Source 
Warn on private on_return method
This commit is contained in:
Jamon Holmgren
2015-02-26 13:34:45 -08:00
parent abb64b8467 84d7748fcc
commit dbec11f925
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/ProMotion/screen/screen_navigation.rb
View File

@@ -61,12 +61,15 @@ module ProMotion
alias :close :close_screen
def send_on_return(args = {})
if self.parent_screen && self.parent_screen.respond_to?(:on_return)
return unless self.parent_screen
if self.parent_screen.respond_to?(:on_return)
if args && self.parent_screen.method(:on_return).arity != 0
self.parent_screen.send(:on_return, args)
else
self.parent_screen.send(:on_return)
end
elsif self.parent_screen.private_methods.include?(:on_return)
PM.logger.warn "#{self.parent_screen.inspect} has an `on_return` method, but it is private and not callable from the closing screen."
end
end