Kurry
b7f1856d36
fixed issue with 404 response not returning error, and added test for empty url
2015-09-10 17:54:08 -04:00
Kurry
5ebba1967b
fixed issue with error not being set when URL is nil
2015-09-10 15:22:25 -04:00
Garrett Moon
b699bac81a
Merge pull request #49 from pinterest/fixCategoryProcessorCallOffMainThread
...
Pass through all the variables :/
2015-09-03 16:50:22 -07:00
Garrett Moon
0605492fc8
Merge pull request #46 from pinterest/fixProgressRaceCondition
...
Fix race conditions in progress generation
2015-09-03 16:49:37 -07:00
Garrett Moon
7bc11f8ebd
Pass through all the variables :/
2015-09-03 14:23:50 -07:00
Garrett Moon
f2bde95b2a
Readability improvements, thanks Jon!
2015-09-03 14:21:33 -07:00
Garrett Moon
25b2a33444
Remove unused queue. Thanks Kurry Tran!
2015-08-29 15:27:17 -07:00
Garrett Moon
ea8fad0c20
More awesome fixes from Jon
2015-08-27 14:28:34 -07:00
Garrett Moon
578bfd2a28
Cleanup, thanks Jon!
2015-08-27 11:14:42 -07:00
Jon Parise
2f07f44e09
Merge pull request #45 from pinterest/addProgressType
...
add PINRemoteImageResultTypeProgress
2015-08-27 07:37:00 -10:00
Garrett Moon
8d3d37dec2
Passing incorrect error
2015-08-27 07:30:17 -10:00
Garrett Moon
5e3ab338e1
Fix race conditions in progress generation
2015-08-26 13:48:52 -07:00
Garrett Moon
7e6d5e439c
add PINRemoteImageResultTypeProgress
2015-08-26 13:46:26 -07:00
Garrett Moon
ea39f08954
Merge pull request #40 from waltflanagan/Fix39
...
Addresses #39
2015-08-20 06:39:55 -07:00
Mike Simons
0715074f0f
Adding comments for CGImageOrientation enum
...
Until minimum sdk is >= 8.0 we can't use the actual enum
2015-08-17 20:01:27 -04:00
Mike Simons
bad4912543
Non-ARC memory management fixes.
2015-08-17 19:44:10 -04:00
Garrett Moon
aafb5d900c
Fix threadPriority deprecation warning
2015-08-17 14:12:20 -07:00
Mike Simons
42a9aa255e
Convert from class method to helper function
2015-08-14 20:30:00 -04:00
Mike Simons
892a788e0f
Whitespace cleanup
2015-08-14 20:27:57 -04:00
Mike Simons
82fc354d39
Addresses #39
...
Converts the embeded EXIF orientation into UIImageOrientation to be used when creating the resulting UIImage
2015-08-14 17:09:10 -04:00
Garrett Moon
b76df8be03
Fixing < iOS 8 crash
2015-08-04 10:15:06 -07:00
Garrett Moon
9923d1a978
Merge pull request #24 from jparise/canceled-unlock
...
Release our lock when we encounter a canceled task
2015-08-03 12:45:23 -07:00
Jon Parise
2b27e1f5c5
Release our lock when we encounter a canceled task
...
This early-out condition would exit while still holding our lock, resulting in
Very Bad Things (tm) down the line.
2015-08-03 12:35:36 -07:00
Jon Parise
a36d5ff37d
Merge pull request #20 from pinterest/setOperationQOS
...
Set QOS / Thread priority
2015-08-01 15:18:27 -07:00
Garrett Moon
053ee6dfc3
Merge pull request #17 from jmah/jmah/mini-optimization
...
Optimize cancelling operations a little
2015-08-01 14:14:38 -07:00
Garrett Moon
bbf05dec24
Merge pull request #16 from jmah/jmah/thread-safety-fix
...
Fix concurrency issue: Only alter completions dictionary while locked
2015-08-01 14:06:28 -07:00
Jon Parise
bb8c9db99f
Merge pull request #18 from jmah/jmah/bool-clean
...
Ensure BOOLs are YES / NO
2015-08-01 13:10:57 -07:00
Garrett Moon
5036a71446
Remove extra qualityOfService set
2015-08-01 12:43:26 -07:00
Garrett Moon
99b34850c7
Context should be nil'd before image source
2015-08-01 09:28:07 -07:00
Garrett Moon
144327ae99
Set QOS / Thread priority
...
Surprisingly, it seems that leaving the qos priority to default does not actually lead to a qos of background like the documentation states. I've found that the QOS gets upgraded to user interactive in some cases. This explicitly sets the QOS on all operations to background so we don't affect scroll performance.
2015-08-01 09:24:47 -07:00
Jonathon Mah
735852c800
Ensure BOOLs are YES / NO
...
Previously some could be greater than 1.
2015-07-31 18:45:44 -07:00
Jonathon Mah
ffd92b70af
Optimize cancelling operations a little
2015-07-31 18:42:13 -07:00
Jonathon Mah
18bfff532b
Fix concurrency issue: Only alter completions dictionary while locked
2015-07-31 18:28:30 -07:00
Jon Parise
ead45bf18a
Pass options directly to our early return routine.
...
This is a more flexible approach that will allow this routine to consider the
full set of options when evaluating an early return.
Also, the `queue` parameter was never being used so it has been removed.
2015-07-31 15:11:04 -07:00
Jon Parise
fd073e394e
Simplify UUID parameter handler.
2015-07-31 14:54:52 -07:00
Garrett Moon
faa6264b65
Fix QOS Test (and add cleanup)
...
- Remove lower quality images from cache if a higher quality one is to be downloaded
- Document weirdness around QOS and caching
- Fix QOS test
2015-07-30 15:27:44 -07:00
Jon Parise
38d9f8e3c9
Name our locks.
2015-07-29 14:43:23 -07:00
Zev Eisenberg
c9f1796b3f
Prefix category methods.
2015-07-27 17:57:37 -04:00
Jared Sinclair
8dc2c2a4f5
fix(imports): change to module imports where relevant
2015-07-26 18:25:56 -04:00
Garrett Moon
9d2bd31f95
1.0
2015-07-22 17:29:31 -07:00
