Garrett Moon
fd6ddbf508
Add assert for error to log webp error which seems to error often on CI
2015-12-05 14:18:47 -08:00
Garrett Moon
75283da491
Add asserts for timeouts so we understand why tests fail
2015-12-05 14:18:47 -08:00
Garrett Moon
77e3fe563a
Need to release image if returning
2015-12-05 14:18:47 -08:00
Garrett Moon
1bac095042
Remove decode for CI progressive images
...
Previously, I'd speculatively decoded images returned from the progressive CIContext
because I'd read that doing so would move the memory from the GPU to the CPU, hopefully
making drawing faster.
I decided to test this hypothesis and by drawing the un-'decoded' image and the image
directly returned from CIContext. Here are some results:
When decoded is drawn before regular
[22486:30240049] decoded - 'regular': 0.000263
[22486:30240097] decoded - 'regular': 0.000242
[22486:30240306] decoded - 'regular': 0.000092
[22486:30240068] decoded - 'regular': 0.000384
[22486:30240096] decoded - 'regular': 0.000111
[22486:30240074] decoded - 'regular': 0.000089
[22486:30240046] decoded - 'regular': 0.000273
[22486:30240351] decoded - 'regular': 0.000250
[22486:30240307] decoded - 'regular': 0.000313
[22486:30240308] decoded - 'regular': 0.000684
[22486:30240307] decoded - 'regular': 0.000485
[22486:30240069] decoded - 'regular': 0.002414
[22486:30240052] decoded - 'regular': 0.000397
[22486:30240049] decoded - 'regular': 0.000293
[22486:30240351] decoded - 'regular': 0.000145
When regular is drawn before decoded
[22610:30246046] decoded - 'regular': 0.000056
[22610:30246030] decoded - 'regular': 0.000473
[22610:30246029] decoded - 'regular': 0.000138
[22610:30246053] decoded - 'regular': 0.000387
[22610:30246030] decoded - 'regular': -0.000006
[22610:30246026] decoded - 'regular': 0.000714
[22610:30246034] decoded - 'regular': 0.000097
[22610:30246621] decoded - 'regular': 0.000039
[22610:30246024] decoded - 'regular': 0.000121
[22610:30246662] decoded - 'regular': -0.000090
[22610:30246030] decoded - 'regular': -0.000057
[22610:30246619] decoded - 'regular': 0.000443
[22610:30246033] decoded - 'regular': 0.001297
[22610:30246623] decoded - 'regular': -0.000020
[22610:30246057] decoded - 'regular': 0.001249
[22610:30246660] decoded - 'regular': 0.000208
[22610:30246659] decoded - 'regular': 0.000048
[22610:30246709] decoded - 'regular': -0.000327
[22610:30246027] decoded - 'regular': 0.000953
[22610:30246025] decoded - 'regular': 0.001228
[22610:30246659] decoded - 'regular': 0.001141
Decoding the image makes little difference and that the difference shows that
the 'decoded' image actually takes longer to draw.
So, we'll save memory and processing time by returning the CGImage from the
context directly as opposed to attempting to decode it.
2015-12-05 13:09:14 -08:00
Garrett Moon
8f190d90d7
need double quotes
2015-12-01 16:42:15 -08:00
Garrett Moon
c604a16525
try and re-enable iOS 8 testing
2015-12-01 16:32:49 -08:00
Garrett Moon
1cbb1dd3f7
not sure why ordering matters…
2015-12-01 16:14:37 -08:00
Garrett Moon
ad2da81234
specify simulator
2015-12-01 16:10:52 -08:00
Garrett Moon
763a8f4a31
Just try 9.1 for now
2015-12-01 15:59:05 -08:00
Garrett Moon
e1ae08ccc9
Maybe it's this?
2015-12-01 13:32:16 -08:00
Garrett Moon
3795deac14
Don't codesign Tests either
2015-12-01 13:26:40 -08:00
Garrett Moon
fde84c3bf1
Travis didn't like my whitespace
2015-12-01 13:19:04 -08:00
Garrett Moon
baf72008cb
Turn off required code signing
2015-12-01 13:14:55 -08:00
Garrett Moon
52e4cfbd8c
Disable code signing
2015-12-01 13:09:22 -08:00
Garrett Moon
7b5c6b54e9
Remove development team
2015-12-01 13:05:43 -08:00
Garrett Moon
6ea5292c41
Try Xcode 7.1 instead
2015-12-01 12:37:17 -08:00
Garrett Moon
fd3f16c92d
Add iOS 9 testing, drop iOS 7
2015-12-01 12:31:46 -08:00
Garrett Moon
b31ebeb8ee
Switch to Xcode 7
2015-12-01 12:29:17 -08:00
Garrett Moon
623f6fefa5
Merge pull request #99 from pinterest/fixProgressiveCrash
...
CIImage doesn't retain its CGImage :(
2015-11-24 11:50:34 -08:00
Garrett Moon
d09f83379b
CIImage doesn't retain its CGImage :(
2015-11-24 11:42:17 -08:00
Garrett Moon
b427105731
Merge pull request #97 from Adlai-Holler/UseNSOptions
...
Use NS_OPTIONS for PINRemoteImageManagerDownloadOptions
2015-11-23 14:06:56 -08:00
Adlai Holler
e1bfaa0fa1
Revert "Remove explicit options values"
...
This reverts commit bace9ce8d6
2015-11-23 13:50:04 -08:00
Adlai Holler
af7bfe3f59
Revert "Fix raw value for .None option"
...
This reverts commit 897fd4c55f
2015-11-23 13:49:59 -08:00
Adlai Holler
897fd4c55f
Fix raw value for .None option
2015-11-22 10:49:15 -08:00
Garrett Moon
61bc84c940
Merge pull request #98 from pinterest/protectAgainstMaxContextSize
...
Respect the maximum size of CIContexts
2015-11-20 18:16:21 -08:00
Garrett Moon
b52d4a867a
Improve readability
2015-11-20 18:11:23 -08:00
Garrett Moon
db588e49cc
Respect the maximum size of CIContexts
2015-11-20 18:04:01 -08:00
Adlai Holler
bace9ce8d6
Remove explicit options values
2015-11-20 15:53:04 -08:00
Adlai Holler
5fadcb46d0
Use NS_OPTIONS for PINRemoteImageManagerDownloadOptions
2015-11-20 15:24:57 -08:00
Connor Montgomery
022b554b7b
Merge pull request #95 from connor/http
...
Fix for local image URLs throwing an error.
2015-11-09 13:04:37 -05:00
Connor Montgomery
213ce3cb14
fix test
2015-11-09 13:00:05 -05:00
Connor Montgomery
1fcc55c296
check class instead
2015-11-09 12:23:08 -05:00
Connor Montgomery
5884bc29cc
Don't cast .
2015-11-09 12:11:33 -05:00
Connor Montgomery
dbf05ce687
Fix for local image URLs
2015-11-09 12:00:27 -05:00
Garrett Moon
5702efdb64
Fix degraded view controller on iOS 9
2015-11-06 09:54:06 -08:00
Garrett Moon
eef725a0e2
Merge pull request #88 from pinterest/addBadges
...
Add badges
2015-11-03 10:57:19 -08:00
Garrett Moon
52c0ea15d2
CocoaPods support is a little more tried and tested, putting it first
2015-11-03 10:56:23 -08:00
Garrett Moon
d9021cb007
Add CocoaPods and Tavis CI Badges
2015-11-03 10:54:45 -08:00
Garrett Moon
1105926e27
Updating podspec for 1.2.2 release
2015-11-03 10:34:01 -08:00
Garrett Moon
49239f6899
Merge pull request #86 from foursquare/check-nil-url
...
Guard against nil url in category methods
2015-10-28 11:30:53 -07:00
Garrett Moon
a1faca7a3d
Update pods
2015-10-28 11:27:23 -07:00
Brian Dorfman
823002b734
Update installation instructions in readme.
...
Add carthage instructions and provide a bit more info on manual installation.
Also move cocoapods and carthage sections above manual since they are preferred.
2015-10-28 11:27:22 -07:00
Brian Dorfman
755fb0f253
Remove my name from xcode's auto gen header template
2015-10-28 11:27:22 -07:00
Brian Dorfman
0add2f2846
Remove unnecessary forward declaration
2015-10-28 11:27:22 -07:00
Brian Dorfman
ce61f2d43b
Remove category methods from umbrella header.
...
LLVM's module documentation is a little arcane, but I believe this is the correct syntax to get what we want.
2015-10-28 11:27:22 -07:00
Brian Dorfman
66a889e061
Remove xcscmblueprint and update gitignore
2015-10-28 11:27:22 -07:00
Brian Dorfman
3bc02e3c24
Add a new project for building Carthage framework
2015-10-28 11:27:22 -07:00
Brian Dorfman
836223b241
Guard against nil url in category methods
2015-10-26 17:09:59 -07:00
Garrett Moon
c3ac95ad26
Merge pull request #81 from farhanpatel/farhanpatel-placeholder
...
Placeholder image is set even if url is nil
2015-10-23 15:06:34 -07:00
Garrett Moon
3f1ce1c817
Merge pull request #83 from pinterest/fixTestsIniOS9
...
URLs need to be HTTPs
2015-10-23 14:12:17 -07:00
