Commit Graph

906 Commits

Author SHA1 Message Date
Bas Broek
ac94168de0 Add handoff support for issues (#331)
* Add handoff support for issues

* Update Info.plist
2017-09-25 10:36:07 -04:00
Rizwan Mohamed Ibrahim
2a770c6a1b Fixes referenced issue view controller being pushed without nav bar (#423)
* Fixes referenced issue view controller being pushed without nav bar

* Fixes referenced issue view controller being pushed without nav bar from Issues Review
2017-09-25 10:34:01 -04:00
Ryan Nystrom
aa9c25b50e Merge branch 'master' of github.com:rnystrom/GitHawk 2017-09-25 10:33:29 -04:00
Ryan Nystrom
f6d5dd9642 cache policy ignore local cache, fixes #121 2017-09-25 10:32:42 -04:00
Ryan Nystrom
57604bf92b restore label editing perms to "can update" 2017-09-25 10:29:49 -04:00
Romain Pouclet
93c2ac3863 Add node bin to path before looking for apollo (#409) 2017-09-24 18:35:15 -04:00
James Sherlock
c28c088629 Initial repository spring clean (#415)
* Move SwipeCellKit & SlackTextViewController to Local Pods directory

* Move playgrounds to own folder

* Create podspec for MMMarkdown and move to Local Pods
2017-09-24 18:35:05 -04:00
James Sherlock
c2a8d3f87a Create CONTRIBUTING.md (#416) 2017-09-24 18:34:32 -04:00
Dylan Lewis
a3276615d5 [413] Use shared colours for standard UI components (#421)
* Update UISwitch on tint color

Align green with shared color

* Update tintColor of all UIAlertControllers

* Create factory for SFSafariViewController

* Update SFSafariViewController tint color

Only in the .configured factory

* Use SFSafariViewController factory everywhere

* Create factory for UIAlertController

* Use UIAlertController factory everywhere
2017-09-24 18:32:32 -04:00
Ryan Nystrom
e941dc3aed disable commenting when cannot admin and locked 2017-09-24 09:07:21 -04:00
Romain Pouclet
b1e2aebd4c Add a package.json to pin the apollo-codegen tool (#401) 2017-09-23 16:37:54 -04:00
Ryan Nystrom
873ad37e7e only show issues page when enabled, fixes #379 2017-09-23 10:29:53 -04:00
Ryan Nystrom
00ed7ec1e6 backout center align 2017-09-23 10:25:11 -04:00
Ryan Nystrom
8adf246d08 center pages on repo, fixes #383 2017-09-23 10:23:47 -04:00
Ryan Nystrom
6912f7617f Repo paging control (#336)
* WIP paging control on repos

* paging working but inset still broken

* remove old repo VC and replace with paging
2017-09-22 18:12:05 -04:00
Bas Broek
efbb986447 Merge pull request #358 from rnystrom/repo-more-options
Add cancel button to repository more options
2017-09-22 09:49:49 +02:00
Bas Broek
cd269665df Add cancel button to repository more options 2017-09-22 07:41:42 +02:00
Ryan Nystrom
707315dd76 update fastfile appstore step to upload ipa 2017-09-21 21:03:06 -04:00
Ryan Nystrom
9c8721cced apply signature in AddCommentClient, fixes #353 2017-09-21 18:05:01 -04:00
Ryan Nystrom
547c437f45 move content in SLKInputBar to front with iOS 11 fix, fixes #338 2017-09-21 18:02:56 -04:00
Ryan Nystrom
8a4189e9e2 Merge branch 'master' of github.com:rnystrom/GitHawk 2017-09-21 17:57:00 -04:00
Ryan Nystrom
5f6fa99d91 Merge pull request #354 from rnystrom/testflight
Add FLEX to TestFlight builds
2017-09-21 17:54:12 -04:00
James Sherlock
b2dbe7944f Add correct preprocessor definition for testflight build (tested) 2017-09-21 21:47:17 +01:00
James Sherlock
b22a831922 Add TestFlight config for subprojects (IT BUILDS!) 2017-09-21 21:34:39 +01:00
James Sherlock
98116aa11a Add preprocessor flag for testflight builds 2017-09-21 21:16:52 +01:00
James Sherlock
2b3975af42 Add FLEX to TestFlight builds 2017-09-21 21:08:44 +01:00
Ryan Nystrom
d65796f5b0 table rows calculated height based on text 2017-09-20 22:11:42 -04:00
Ryan Nystrom
86c32013c5 swift optimization settings that arent terrible 2017-09-20 22:11:20 -04:00
Ryan Nystrom
9578c521ab Merge pull request #330 from rnystrom/accessibility-speed
Prefer interpolation over concatenation
2017-09-20 13:50:45 -04:00
Bas Broek
15f41c94af Prefer interpolation over concatenation 2017-09-20 19:02:32 +02:00
Ryan Nystrom
d54115ec72 Merge pull request #327 from matt-holden/compilation-speed
Improve compile times (Issue #114)
2017-09-20 11:05:32 -04:00
Matthew Holden
3c8768574a Improve compile times (Issue #114)
**Summary**

It appears to me that the largest contributor to compile times is `API.swift` and its re-generation in the "Generate Apollo GraphQL API" build phase.

The build script currently overwrites "API.swift" on every build, resulting in a new last-modified timestamp. As such, the swift compiler won't use it's
cached build of the file.  (You'll have to excuse me, I don't know much about the compiler, so I may be butchering terminology.)

In my estimation, this causes XCode to not only recompile API.swift, but also _all files that reference its contents_.

**Fix**

Modify the "Generate Apollo GraphQL API" build phase to only overwrite API.swift if the output of `check-and-run-apollo-codegen.sh` results in a different output than the previous build.

The diff is hard to read, as it's in the pbxproj, so I've included the relevant lines below:

```sh
TEMP_FILE=$(mktemp)
[[ -f API.swift ]] || touch API.swift # ensure sure file exists

$APOLLO_FRAMEWORK_PATH/check-and-run-apollo-codegen.sh generate $(find . -name '*.graphql') --schema schema.json --output $TEMP_FILE

cmp API.swift $TEMP_FILE || cp $TEMP_FILE API.swift
```

In short, it outputs the generated API file to `TEMP_FILE`. Then, it
uses `cmp` to test if `TEMP_FILE` is identifical to the existing `API.swift`. If they are not, it overrwrites `API.swift` with the newly generated code.

**Result**

Previously, re-builds (with no changes) were taking between 60-90 seconds (I have a slow-ish Mac). Now they're taking between 7-10.
2017-09-20 00:39:32 -07:00
Ryan Nystrom
2d8005e15b updated screenshots, add app store icon 2017-09-19 22:15:29 -04:00
Ryan Nystrom
54ef11432e new screenshots 2017-09-18 22:50:34 -04:00
Ryan Nystrom
e2999fdff2 proper push from issues VC 2017-09-18 22:50:26 -04:00
Ryan Nystrom
66bdf3d835 show detail from search 2017-09-18 22:37:15 -04:00
Ryan Nystrom
eead35bdf3 Merge pull request #321 from rizwankce/fix/add-more-options-to-repo
Adds "More Options" to repository
2017-09-18 22:18:19 -04:00
Rizwan Mohamed Ibrahim
5567c20d5f Adds more options to repo with share actions 2017-09-18 19:18:28 +05:30
Ryan Nystrom
4f2363c040 only scroll to bottom of issue/pr when coming from notifications 2017-09-17 21:34:09 -04:00
Ryan Nystrom
89c6742903 update pods and project file settings for xcode 9 2017-09-17 21:28:04 -04:00
Ryan Nystrom
e8160beb00 haptic feedback on reaction 2017-09-17 21:06:08 -04:00
Ryan Nystrom
27c659400d refactor networking to use indicator when using gql 2017-09-17 20:45:44 -04:00
Ryan Nystrom
abb1411e46 local, optimistic emoji mutations 2017-09-17 20:32:25 -04:00
Ryan Nystrom
a50ee83b4a tighten prompt cycle 2017-09-17 18:02:51 -04:00
Ryan Nystrom
c73576eb66 Merge branch 'master' of github.com:rnystrom/GitHawk 2017-09-17 17:41:34 -04:00
Ryan Nystrom
1592d9b29b intro parsing options 2017-09-17 17:41:29 -04:00
Ryan Nystrom
6abd7dc114 Merge pull request #316 from rnystrom/tabBarHeight
Take into account tab bar height in empty states
2017-09-17 17:30:03 -04:00
James Sherlock
b2f71a54d2 Merge branch 'master' into tabBarHeight 2017-09-17 22:15:41 +01:00
Ryan Nystrom
3acd485807 Merge pull request #315 from rnystrom/relativeImages
Allow relative images to display in README files
2017-09-17 17:07:39 -04:00
Ryan Nystrom
ee5ffd03e9 Merge pull request #310 from rizwankce/fix/empty-state-for-repo-overview
Adds empty state when no readme for repository
2017-09-17 16:59:36 -04:00