Commit Graph

1769 Commits

Author SHA1 Message Date
Ryan Nystrom
0daf0f9cf1 update ContextMenu (#2310) 2018-10-18 21:34:04 -04:00
Ryan Nystrom
22ab3fbf19 fetch subscription status and fix mutation (#2291) 2018-10-16 22:19:41 -04:00
Ryan Nystrom
c23945ac7d Enable SwiftLint and fix issues (#2292)
* update swiftlint

* build with lint enabled

* fix almost all warnings

* remove wholemodule
2018-10-16 21:54:55 -04:00
Bas Broek
96e9554968 Warn that logging out removes bookmarks (#2303) 2018-10-16 21:48:59 -04:00
Brian Litwin
9eb26bf52c Sorts issues after fetch (#2304)
*reverse chronologically
2018-10-16 21:48:43 -04:00
Maxime Mongeau
508525d892 Add clear button to action menus (#2288)
* Add clear button to the labels and milestone action menu

* Move the selection count in the PeopleViewController into the title
Add a clear button to the people controller

* Remove mock return for testing action menu

* Add "Clear" string constant
Remove unused Protocol

* Setup the clear enabled state and the Poeple title correctly on init
2018-10-14 16:00:49 -04:00
Ryan Nystrom
108f667a2d Update MessageViewController (#2287)
* update messageviewcontroller

* add latest update

* update with revert
2018-10-13 23:20:55 -04:00
Ryan Nystrom
3ae609292d thread error descriptions to squawk throughout app (#2286) 2018-10-13 23:09:45 -04:00
Ryan Nystrom
c9f5254183 move background handling into feed for better state control (#2285) 2018-10-13 23:09:24 -04:00
Ryan Nystrom
e4f6e20a9a add empty error view to latest base VC (#2283) 2018-10-13 21:50:49 -04:00
Ryan Nystrom
18de137111 Button to display Push Notification info in Settings (#2282)
* Add push notification info in settings

* better sizing
2018-10-13 13:41:01 -04:00
Cameron Moreau
b9f0cc42b3 Add "Try Again" button for EmptyView (#2214) (#2226) 2018-10-12 23:06:58 -04:00
Maxime Mongeau
fe4853538b Add steps in the setup to avoid commiting env variables to the repo (#2262) 2018-10-12 23:06:41 -04:00
Ehud Adler
0f533a3803 Switched from long press to tap recognizer for menu controllers (#2271) 2018-10-12 23:06:28 -04:00
Michael Lutaaya
84a5872e2e Add new iPhone models to UIDevice+Model.swift (#2278) 2018-10-12 23:06:17 -04:00
Michael Lutaaya
fdd3548f29 Update Gemfile to use same version of CocoaPods referenced in Podfile.lock (#2277)
* Update cocoapods version constraint

* Run `bundle update cocoapods`

* Run `npm install`
2018-10-12 23:05:27 -04:00
Ryan Nystrom
0db4c23d77 Proper fix to prevent double fetching from background (#2279) 2018-10-12 22:42:27 -04:00
Ryan Nystrom
5b3ec76ff4 keep read layer in front when animating inbox (#2280) 2018-10-12 22:42:19 -04:00
Rizwan Mohamed Ibrahim
21edc71352 [FIX] Navigation controller on "View Source" from settings (#2276) 2018-10-12 22:36:55 -04:00
Rizwan Mohamed Ibrahim
5b14376637 [FIX] Navigation for double tap reaction on settings (#2275)
- Changes segue kind from show to showDetail
- Adds a navigation controller for "Double tap Reaction" so it will work on both iPhone and iPad
2018-10-12 22:35:33 -04:00
Ryan Nystrom
fbb223f5f1 open issue from notification (#2259) 2018-10-09 23:19:48 -04:00
Ryan Nystrom
119139a9a3 always call completion block when early returning b/c of bg (#2258) 2018-10-09 23:19:38 -04:00
Ashley Ng
2c55fc2e08 move the bookmark icon for the RepoVC and address a CR comment (#2255) 2018-10-09 23:17:52 -04:00
Ryan Nystrom
caf86a5087 Always update shortcuts on app launch (#2248) 2018-10-08 22:21:52 -04:00
Ryan Nystrom
b2d5b5f519 Simpler logic for review access button handling (#2249) 2018-10-08 22:21:42 -04:00
Brian Litwin
b70e2649a0 PeopleVC: Sort users with self first (#2246)
- moves sorting logic from fetch(page:) into type method
- unit test
2018-10-08 11:42:31 -04:00
Rizwan Mohamed Ibrahim
93e70b0d4f [FIX] Settings write review indent (#2242) 2018-10-08 08:10:18 -04:00
Ryan Nystrom
64f920a3f0 new routing library and refactor shortcuts (#2241) 2018-10-07 23:46:57 -04:00
Ashley Ng
c45b35e721 use edge inset to right align image (#2232) 2018-10-07 16:00:48 -04:00
Ashley Ng
5c94d98cf6 Adds more share actions when browsing a repository (#2161) (#2237)
* add additional share actions

* fix share URLs
2018-10-07 16:00:14 -04:00
Ryan Nystrom
e2b2bc9d47 Huge refactor of AppDelegate and authentication routing (#2238)
* refactor with new app controller, replace root nav mgr

* finish refactoring out root nav mgr

* remove root mgr
2018-10-07 15:59:18 -04:00
Ryan Nystrom
a5ed67a924 Fix readme duplicate identifier asserts (#2219)
* WIP to fix readme asserts

* remove newline

* improved markdown parsing working

* fix tests
2018-10-04 20:58:07 -04:00
Brian Litwin
cfdd6d1388 Order repo branches after fetch (#2228)
* Order repo branches after fetch
- added func to order branches + unit tests
- replaced 'var branch: String' w/ 'private(set) var selectedBranch: String'
& added a defaultBranch variable
- changed fetch(page:) to update(animated:) in didSelect(value:) - an oversight from original pr

* AX animation
2018-10-04 19:27:17 -04:00
Brian Litwin
4bb4bc6244 set spinner color in RepoBranchVC (#2221) 2018-10-03 13:21:37 -04:00
dtranmobil
ceaee75563 Update Setup.md (#2218)
Grammatical change to md
2018-10-02 21:45:42 -04:00
Ryan Nystrom
d43139484f Localize Inbox Zero and allow for per-year holidays (#2215) 2018-10-02 21:45:25 -04:00
Brian Litwin
c62ce4a62d change repo branch (#2202)
* change repo branch

additions:
- A change-repository-branch workflow thats very similar to the workflow in Milestones
- GraphQL query to fetch a repo's branches

modifications:
- a mutable "branch" string in RepositoryOverviewController and RepositoryCodeDirectoryViewController
- updated the V3RepositoryReadME fetch to include a branch parameter
- a protocol RepositoryBranchUpdatable to flag and update the appropriate ViewControllers when a user switches branches
- ContextMenu and UIAlertAction setup
- Removed some outdated code to get a repo's branch name from fetch(page:) in RepositoryOverviewViewController
- Added a line feed.adapter.reloadData() in fetch(page:) because app was crashing intermittently after a user switched branches without that line - was always an IGListKit duplicate identifier error on StyledTextRenderers  -  to reproduce, remove the feed.adapter.reloadData(), go to https://github.com/TheAlgorithms/Python, try to switch branches and the app will crash. I'm working raising an issue for it.

* requested changes

- changed public var to private(set) for var branch: String
- removed wasteful feed.adapter.reloadData() call
- re-formated params in switchBranchAction()

* style nit
2018-09-30 15:25:01 -04:00
Ryan Nystrom
d94eb86199 Fix entitlements path (#2211) 2018-09-30 00:39:44 -04:00
Ehud Adler
14aef44d19 Settings cell textColor (#2193)
* Set API Status cell textColor to custom (Matching the rest of the settings page)

* Updated Double Tap Reaction off color to custom

* Updated Enabled textColor to custom

* Updated reaction textColors to proper custom

* Switched all labels to settingsLabels
2018-09-30 00:30:59 -04:00
Ehud Adler
64fa20864d Fixed cell border on merge button (#2204)
* Fixed cell border on merge button

* Fixed nits
2018-09-30 00:15:18 -04:00
Ryan Nystrom
a23f2b5e19 Move entitlements to Resources (#2209) 2018-09-30 00:15:03 -04:00
Ryan Nystrom
dc01bf9ea0 Restore readme images after assets move (#2210) 2018-09-30 00:14:58 -04:00
Ryan Nystrom
c65877a15c Delete AppStore.md 2018-09-30 00:10:21 -04:00
Ryan Nystrom
f9ec9575da Delete appcenter-post-clone.sh 2018-09-30 00:10:09 -04:00
Ryan Nystrom
cdd988f952 move designs to own repo (#2208) 2018-09-30 00:09:50 -04:00
Ehud Adler
3193097ca4 Switched to constants (#2207) 2018-09-30 00:09:41 -04:00
Ehud Adler
1029698c2b Move lock (#2206)
* Moves lock under divider

* fix param style

* Update IssueManagingContextController.swift
2018-09-30 00:09:11 -04:00
Ehud Adler
3ebd279d55 fixed icon name (#2203) 2018-09-30 00:01:24 -04:00
Ryan Nystrom
c5ec7728b0 move blog to own repo (#2205) 2018-09-29 23:54:10 -04:00
Ryan Nystrom
965bb2fa4f Delete CNAME 2018-09-29 23:43:10 -04:00