Commit Graph

1090 Commits

Author SHA1 Message Date
Bas Broek
073fab0bde Merge branch 'master' into text-fixes 2017-10-24 05:43:22 +02:00
Hesham Salman
38252844cf Removed cell dividers, added bg color (#690) 2017-10-23 17:32:51 -04:00
Bas Broek
c2c8e4e481 Fix capitalization for short words (#680) 2017-10-23 17:14:15 -04:00
Bas Broek
3d9e484974 Rename "Add to Bookmark" to simply "Bookmark" (#681) 2017-10-23 17:13:43 -04:00
Hesham Salman
2df5e5ffb5 Standardized sign-in/out copy (#689) 2017-10-23 17:12:57 -04:00
Hesham Salman
2ec7ba2753 Preventing the search race condition instead of responding to it (#691)
* More explicit approach to search triggers

Cutt reliance off of the singleton store

* Cleaned up optional code-smell

Comments
2017-10-23 17:08:55 -04:00
Rizwan Mohamed Ibrahim
0aacad0ae3 [FIX] scroll to top for bookmarks screen (#693) 2017-10-23 17:06:53 -04:00
Rizwan Mohamed Ibrahim
ca13edd60f [ADD] 3D touch short cut item for bookmarks tab (#699) 2017-10-23 17:02:55 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Bas Broek
609151d013 Remove erroneous double localization 2017-10-22 22:53:05 +02:00
Bas Broek
359794debf Some general text improvements 2017-10-22 22:49:52 +02:00
James Sherlock
a0f1bcdfcb Replace image upload images with text, hook up cancel button (#672)
* Replace image upload images with text, hook up cancel button

* Add image privacy info.plist item

* Update Info.plist
2017-10-22 15:08:37 -04:00
Bas Broek
b5a4fe959a Change "Clear" to "Clear All" (#667) 2017-10-22 14:50:15 -04:00
Ryan Nystrom
a78e96c63a Ceiling final height of repo issue cells (#668) 2017-10-22 14:50:00 -04:00
Ryan Nystrom
d4adc9016a Disable updating tab and badge when on Archives (#657) 2017-10-22 14:21:55 -04:00
Bas Broek
ce681fcfcf Open accounts in detail on iPad (#648) 2017-10-22 14:05:33 -04:00
Ostap
a89202a42a Added insets handling for SearchViewController when keyboard is presented (#652) 2017-10-22 14:04:14 -04:00
Weyert de Boer
803909e1ff Use actual filename for the file browsing screen (#555)
* Added an extension to the `File` extension so you can get the `potentialLanguage` (based on extension) and the actual name of the file expressed in the class
Updated the `IssuePatchContentViewController.swift` so that it only shoes the file name and not the full path

* Tidying up of the code
2017-10-22 14:03:30 -04:00
Afonso
bb818a75c1 Fix: persist local changes (#623)
* fix: persist local changes

* chore: revert API.swift file
2017-10-22 14:02:01 -04:00
Hesham Salman
b7c46faa35 Cancelled debounce action if explicit search (#643) 2017-10-22 14:01:35 -04:00
Hesham Salman
ad6caa286d Swapped Bar Button Items (#644)
Catpitalization
2017-10-22 14:01:18 -04:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Joe Rocca
a6275bb5b9 Adds label summary dots to repo issues/PR cell (#622)
* added labelableFields to RepoPages queries

* added labels to RepositoryIssueSummaryModel

* added DotListView

* replaced UICollectionView with DotListView

* added DotListView to RepositorySummaryCell

* fixed max items calculation

* removed constraints and set collection view frame instead
2017-10-22 13:58:51 -04:00
James Sherlock
bde290f192 Image Upload for Bug Reports (#475)
* WIP: Basic image upload for bug reports

* Added image upload UI, Improved flow, Sped up process, Accurate information is passed through

* Improved navigation structure and transitions

* Tidy up of code, enable actual submission to Imgur

* Update to use table view

* Minor changes as per @BasThomas code review

* Remove all classes from Test target, Added @testable

Should fix Buddybuild issues

* Tweaks as per Ryan code review, Moved image upload logic to shared controller, added flag to toggle upload action
2017-10-22 13:58:03 -04:00
Joe Rocca
fd9950e209 Add done return key type that dismisses keyboard for notifications/issues/pr search (#569)
* added done return key type that dismisses keyboard

* changed returnKeyType to .search
2017-10-22 11:59:31 -04:00
Bas Broek
da9048c26b Resign first responder when hiding keyboard (#615)
* Resign first responder when hiding keyboard

* Improve readability, limit target scope

* Use target action
2017-10-22 11:58:35 -04:00
Hesham Salman
866418ec8a New tests, fixed failing tests (#645) 2017-10-22 11:58:07 -04:00
Hesham Salman
a52e533b5f User can receive search results while typing (#611)
* Cancelled networking when the cancel button is pressed

* Responded to comments: code formatting & cleanup

* Can now search while typing

Slight formatting changes

* Prevented search term from showing up in recent before search succeeds

* Show loading screen while typing

* Less complicated network cancellation

* Cleaned up groups

* Recently viewed repos (#631)

* Recently Viewed Repos saved in search store

* Styling changes

* Equatable changes and visual updates

* Visually update after selecting a repo

* Rebased

* Slowed down the debouncer a bit
2017-10-22 00:11:12 -04:00
Ryan Nystrom
5bae4ba89d [WIP] Add FlatCache lib and use for Notifications (#632)
* init FlatCache lib

* tests for all other cases

* install flatcache to freeitme project, move VM creation into client

* refactor and split up inbox design

* fixup flatcache pod
2017-10-22 00:08:42 -04:00
Ryan Nystrom
c932be148e Avoid KVO bugs changing content offset (#635) 2017-10-22 00:08:07 -04:00
Ryan Nystrom
ba156d1ef8 Disable git hash from build script (#637) 2017-10-22 00:07:58 -04:00
Ryan Nystrom
ac4719445e Remove unused UICV subclass (#636) 2017-10-21 21:51:39 -04:00
Hesham Salman
07febda7a6 User can delete individual searches in the search controller (#618)
* Allowed deletion of individual searches

Spacing fixes

* Set design to option 2

* Styling change to match notification swipe

* Responded to comments
2017-10-21 20:37:58 -04:00
Bas Broek
980fba6cc0 Move some hardcoded "Search"es to Constants (#616) 2017-10-21 20:35:57 -04:00
Hesham Salman
d916fbbf07 Miscellaneous tests (#613) 2017-10-21 20:34:07 -04:00
Hesham Salman
c631c10b49 Cancelled networking when the search cancel button is pressed (#607)
* Cancelled networking when the cancel button is pressed

* Responded to comments: code formatting & cleanup
2017-10-21 20:32:36 -04:00
Bas Broek
a6e8ddab47 Adds sharing to code browsing (#602) 2017-10-21 20:31:36 -04:00
Viktor Gardart
d43fe6d3d1 🐛 Disable selection in IssueCommentHtmlCell (#600)
* 🐛 Disable selection in IssueCommentHtmlCell

* 🔥 made the template a "swift 4 string"
2017-10-21 20:17:11 -04:00
Ryan Nystrom
5c0b10f6ac CFBundleVersion set to commit count (#614) 2017-10-19 12:39:14 -04:00
Ryan Nystrom
29f771887f prod build number 1.11.0 2017-10-19 09:17:45 -04:00
Ryan Nystrom
39df2bdb1a iPhone X support for Slack text view (#612) 2017-10-18 19:50:49 -04:00
Ryan Nystrom
6217ba18d4 Fix foreground/background notification mismatch (#604) 2017-10-18 16:33:50 -04:00
Ryan Nystrom
72429dbaea Toast mounts to UIWindow (#603) 2017-10-18 16:33:44 -04:00
Ryan Nystrom
244e73106c fix unit tests 2017-10-18 12:18:50 -04:00
Ryan Nystrom
357e7e1bde Finish wiring up edit comments (#594) 2017-10-18 12:14:17 -04:00
Ryan Nystrom
55a0064495 Merge branch 'master' of github.com:rnystrom/GitHawk 2017-10-16 21:10:08 -04:00
Ryan Nystrom
148dbd853a disable collapse overlay animations 2017-10-16 21:07:33 -04:00
Weyert de Boer
3cbe88f541 Lower the priority for the 4 pixel padding for the contentView of the input bar view, fixes #572 (#586) 2017-10-16 21:04:45 -04:00
Ryan Nystrom
680105020e Only use left and right safe insets for UICollectionViewCell contentView (#593) 2017-10-16 21:04:38 -04:00
Ryan Nystrom
d51db6f3b9 Remove toast on pan completion and avoid recenter exception (#592) 2017-10-16 17:36:46 -04:00