Sort milestones by due date and title (#1386)

* Sort milestones by due date and title #1341

* Use switch statement #1341
This commit is contained in:
Ivan Magda
2018-01-13 20:41:07 +03:00
committed by Ryan Nystrom
parent 65959c7c14
commit f18c1916fc

View File

@@ -25,7 +25,18 @@ extension GithubClient {
milestones.append(milestone)
}
}
milestones.sort { $0.number < $1.number }
milestones.sort { lhs, rhs in
switch (lhs.dueOn, rhs.dueOn) {
case (let lhsDue?, let rhsDue?):
return lhsDue.compare(rhsDue) == .orderedAscending
case (_?, nil):
return true
case (nil, _?):
return false
default:
return lhs.title < rhs.title
}
}
completion(.success(milestones))
} else {
completion(.error(response.error))