[react-daterange-picker] Fix onSelect prop type definitions (#29370)

* react-daterange-picker - update props definitions, specifically onSelect prop

* react-daterange-picker - refactor type definitions and update test

types/react-daterange-picker/index.d.ts

@@ -3,6 +3,7 @@
 // Definitions by: UNCOVER TRUTH Inc. <https://github.com/uncovertruth>
 //                 MartynasZilinskas <https://github.com/MartynasZilinskas>
 //                 Donald Ford <https://github.com/donaldtf>
+//                 Vlad Florescu <https://github.com/vladflorescu94>
 // Definitions: https://github.com/borisyankov/DefinitelyTyped
 // TypeScript Version: 2.8
 
@@ -32,7 +33,7 @@ export interface Props<T = DateRangePicker> extends React.Props<T> {
     numberOfCalendars?: number;
     onHighlightDate?(date: Date): void;
     onHighlightRange?(date: Date): void;
-    onSelect?(value: Props): void;
+    onSelect?(value: OnSelectCallbackParam): void;
     onSelectStart?(value: momentRange.MomentRangeExtends): void;
     paginationArrowComponent?: React.ComponentClass<PaginationArrowProps> | React.SFC<PaginationArrowProps>;
     selectedLabel?: string;
@@ -63,3 +64,8 @@ export interface PaginationArrowProps<T = {}> extends React.Props<T> {
     onTrigger?(): void;
     direction?: 'next' | 'previous';
 }
+
+export interface OnSelectCallbackParam {
+    start: moment.Moment;
+    end: moment.Moment;
+}

types/react-daterange-picker/react-daterange-picker-tests.tsx

@@ -30,7 +30,7 @@ class CustomComponentClassPaginationArrow extends React.Component<ReactDateRange
 }
 
 class App extends React.Component<AppProps, any> {
-    handleSelect(value: AppProps, states: any): void {
+    handleSelect(value: ReactDateRangePicker.OnSelectCallbackParam, states: any): void {
         this.setState({ value, states });
     }
 
@@ -56,7 +56,7 @@ class App extends React.Component<AppProps, any> {
 }
 
 class DateSinglePicker extends React.Component<AppProps, any> {
-    handleSelect(value: AppProps) {
+    handleSelect(value: ReactDateRangePicker.OnSelectCallbackParam) {
         this.setState({ value });
     }