kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-24 05:06:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14424 from Strate/patch-2

Browse Source 
react: make defaultProps Partial<P>
This commit is contained in:
Arthur Ozga
2017-02-10 14:22:28 -08:00
committed by GitHub
parent 59ad0b8684 e875fc829a
commit a15be2eed2
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
react/index.d.ts vendored
View File

@@ -207,7 +207,7 @@ declare namespace React {
(props: P & { children?: ReactNode }, context?: any): ReactElement<any>;
propTypes?: ValidationMap<P>;
contextTypes?: ValidationMap<any>;
defaultProps?: P;
defaultProps?: Partial<P>;
displayName?: string;
}
@@ -216,7 +216,7 @@ declare namespace React {
propTypes?: ValidationMap<P>;
contextTypes?: ValidationMap<any>;
childContextTypes?: ValidationMap<any>;
defaultProps?: P;
defaultProps?: Partial<P>;
displayName?: string;
}

15
react/test/index.ts
View File

@@ -689,3 +689,18 @@ type InputChangeEvent = React.ChangeEvent<HTMLInputElement>;
type InputFormEvent = React.FormEvent<HTMLInputElement>;
const changeEvent:InputChangeEvent = undefined as any;
const formEvent:InputFormEvent = changeEvent;
// defaultProps should be optional of props
{
interface ComponentProps {
prop1: string;
prop2: string;
prop3?: string;
}
class ComponentWithDefaultProps extends React.Component<ComponentProps, void> {
static defaultProps = {
prop3: "default value",
};
}
const VariableWithAClass: React.ComponentClass<ComponentProps> = ComponentWithDefaultProps;
}