Merge pull request #1309 from vvakame/fix-maxBuffer-bug

Fixed a bug, there is a test should fail if the original
This commit is contained in:
Basarat Ali Syed
2013-11-21 03:54:10 -08:00
6 changed files with 8 additions and 5 deletions

View File

@@ -59,7 +59,7 @@ var NodeExec = (function () {
result.exitCode = null;
var cmdLine = filename + ' ' + cmdLineArgs.join(' ');
var process = nodeExec(cmdLine, function (error, stdout, stderr) {
var process = nodeExec(cmdLine, { maxBuffer: 1 * 1024 * 1024 }, function (error, stdout, stderr) {
result.stdout = stdout;
result.stderr = stderr;
result.exitCode = error ? error.code : 0;
@@ -691,7 +691,7 @@ var DefinitelyTyped;
}
Object.defineProperty(TestResult.prototype, "success", {
get: function () {
return this.exitCode !== 1;
return this.exitCode === 0;
},
enumerable: true,
configurable: true

View File

@@ -139,7 +139,7 @@ module DefinitelyTyped.TestManager {
exitCode:number;
public get success():boolean {
return this.exitCode !== 1;
return this.exitCode === 0;
}
}

View File

@@ -57,8 +57,8 @@ class NodeExec implements IExec {
var result = new ExecResult();
result.exitCode = null;
var cmdLine = filename + ' ' + cmdLineArgs.join(' ');
var process = nodeExec(cmdLine, function (error, stdout, stderr) {
var process = nodeExec(cmdLine, {maxBuffer: 1 * 1024 * 1024}, function (error, stdout, stderr) {
result.stdout = stdout;
result.stderr = stderr;
result.exitCode = error ? error.code : 0;

View File

@@ -1 +1,2 @@
""

View File

@@ -0,0 +1,2 @@
""