kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-05-12 19:59:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correct parameter type for Vector4.setAxisAngleFromRotationMatrix.

Browse Source 
The parameter to Vector4.setAxisAngleFromRotationMatrix is a
Matrix4 from which the upper 3x3 matrix is used, not a Matrix3.

See https://github.com/mrdoob/three.js/blob/master/src/math/Vector4.js#L271
for a reference.
This commit is contained in:
Oscar Lorentzon
2016-01-13 11:05:44 +01:00
parent 1984ea435f
commit 88296dd9b2
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
threejs/three.d.ts vendored
View File

@@ -4166,7 +4166,7 @@ declare module THREE {
* http://www.euclideanspace.com/maths/geometry/rotations/conversions/matrixToAngle/index.htm
* @param m assumes the upper 3x3 of m is a pure rotation matrix (i.e, unscaled)
*/
setAxisAngleFromRotationMatrix(m: Matrix3): Vector4;
setAxisAngleFromRotationMatrix(m: Matrix4): Vector4;
min(v: Vector4): Vector4;
max(v: Vector4): Vector4;