kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-06-05 20:02:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

lodash: Revert ReadonlyArray support (crashes older compilers) (#23710)

Browse Source
This commit is contained in:
Andy
2018-02-16 10:14:04 -08:00
committed by GitHub
parent 9c62709d88
commit 7c243097d1
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
types/lodash/common/common.d.ts vendored
View File

@@ -2,7 +2,7 @@ import _ = require("../index");
type GlobalPartial<T> = Partial<T>;
declare module "../index" {
type PartialObject<T> = GlobalPartial<T>;
type Many<T> = T | ReadonlyArray<T>;
type Many<T> = T | T[]; // TODO: Should be ReadonlyArray<T>, but requires ts2.5 to not infinitely loop
interface LoDashStatic {
/**
* Creates a lodash object which wraps value to enable implicit method chain sequences.

10
types/lodash/lodash-tests.ts
View File

@@ -3775,7 +3775,7 @@ namespace TestCommit {
// _.prototype.concat
namespace TestConcat {
const numberROA: ReadonlyArray<number> = [0];
const numberROA: number[] = [0]; // TODO: Should be ReadonlyArray, but see comment on type Many<T>
_.concat(1); // $ExpectType number[]
_.concat([1]); // $ExpectType number[]
@@ -3798,7 +3798,7 @@ namespace TestConcat {
_.chain(numberROA).concat(numberROA); // $ExpectType LoDashExplicitWrapper<number[]>
_.chain(numberROA).concat(numberROA, numberROA); // $ExpectType LoDashExplicitWrapper<number[]>
const stringROA: ReadonlyArray<string> = [''];
const stringROA: string[] = ['']; // TODO: Should be ReadonlyArray, but see comment on type Many<T>
_.concat('a'); // $ExpectType string[]
_.concat(['a']); // $ExpectType string[]
@@ -3822,7 +3822,7 @@ namespace TestConcat {
_.chain(stringROA).concat(stringROA, stringROA); // $ExpectType LoDashExplicitWrapper<string[]>
const abcObject: AbcObject = { a: 1, b: 'foo', c: true };
const objectROA: ReadonlyArray<AbcObject> = [{ a: 1, b: 'foo', c: true }];
const objectROA: AbcObject[] = [{ a: 1, b: 'foo', c: true }]; // TODO: Should be ReadonlyArray, but see comment on type Many<T>
_.concat(abcObject); // $ExpectType AbcObject[]
_.concat([abcObject]); // $ExpectType AbcObject[]
@@ -11802,9 +11802,9 @@ namespace TestOmitBy {
namespace TestPick {
const obj1: AbcObject | null | undefined = anything;
const obj2: AbcObject = anything;
const readonlyArray: ReadonlyArray<string> = ['a', 'b'];
const readonlyArray: string[] = ['a', 'b']; // TODO: Should be ReadonlyArray, but see comment on type Many<T>
const literalsArray = ['a' as 'a', 'b' as 'b'];
const roLiteralsArray: ReadonlyArray<'a' | 'b'> = literalsArray;
const roLiteralsArray: Array<'a' | 'b'> = literalsArray; // TODO: Should be ReadonlyArray, but see comment on type Many<T>
_.pick(obj1, 'a'); // $ExpectType PartialDeep<AbcObject>
_.pick(obj1, 0, 'a'); // $ExpectType PartialDeep<AbcObject>