kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-21 13:27:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add undefined type to ol.Overlay.setPosition

Browse Source 
According to the [document of ol.Overlay.setPosition](http://openlayers.org/en/latest/apidoc/ol.Overlay.html#setPosition), set it to undefined makes the popup disappear. However, in the current definition, it doesn't allow to be set to undefined.
This commit is contained in:
Bin Wang
2017-09-14 09:59:19 +08:00
parent acc37d8b9d
commit 5538cba820
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
types/openlayers/index.d.ts vendored
View File

@@ -1,6 +1,8 @@
// Type definitions for OpenLayers v4.3.0
// Project: http://openlayers.org/
// Definitions by: Olivier Sechet <https://github.com/osechet>, Guilhem Brouat <https://github.com/ganlhi>
// Definitions by: Olivier Sechet <https://github.com/osechet>
// Guilhem Brouat <https://github.com/ganlhi>
// Bin Wang <https://github.com/wb14123>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// Definitions partially generated using tsd-jsdoc (https://github.com/englercj/tsd-jsdoc)
@@ -7597,7 +7599,7 @@ declare module ol {
* @observable
* @api stable
*/
setPosition(position: (ol.Coordinate)): void;
setPosition(position: (ol.Coordinate | undefined)): void;
/**
* Set the positioning for this overlay.

1
types/openlayers/openlayers-tests.ts
View File

@@ -590,6 +590,7 @@ voidValue = popup.setElement(popupElement);
voidValue = popup.setMap(popupMap);
voidValue = popup.setOffset(popupOffset);
voidValue = popup.setPosition(coordinate);
voidValue = popup.setPosition(undefined);
voidValue = popup.setPositioning(popupPositioning);