kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-05-16 19:09:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

[knockout] Introduce specialized signatures for subscribe method, specifically common "change" and "beforeChange"

Browse Source 
Add subscribe for "arrayChange" event for observable array (fixes #11203)
Improve KnockoutArrayChange status typing.
This commit is contained in:
Igor Oleinikov
2016-09-14 11:27:33 -07:00
parent f46e806408
commit 47588ba8f9
3 changed files with 45 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
knockout/knockout.d.ts vendored
View File

@@ -61,8 +61,10 @@ interface KnockoutSubscription {
}
interface KnockoutSubscribable<T> extends KnockoutSubscribableFunctions<T> {
subscribe(callback: (newValue: T) => void, target?: any, event?: string): KnockoutSubscription;
subscribe(callback: (newValue: T) => void, target: any, event: "beforeChange"): KnockoutSubscription;
subscribe(callback: (newValue: T) => void, target?: any, event?: "change"): KnockoutSubscription;
subscribe<TEvent>(callback: (newValue: TEvent) => void, target: any, event: string): KnockoutSubscription;
extend(requestedExtenders: { [key: string]: any; }): KnockoutSubscribable<T>;
getSubscriptionsCount(): number;
}
@@ -91,6 +93,11 @@ interface KnockoutObservableArrayStatic {
}
interface KnockoutObservableArray<T> extends KnockoutObservable<T[]>, KnockoutObservableArrayFunctions<T> {
subscribe(callback: (newValue: KnockoutArrayChange<T>[]) => void, target: any, event: "arrayChange"): KnockoutSubscription;
subscribe(callback: (newValue: T[]) => void, target: any, event: "beforeChange"): KnockoutSubscription;
subscribe(callback: (newValue: T[]) => void, target?: any, event?: "change"): KnockoutSubscription;
subscribe<TEvent>(callback: (newValue: TEvent) => void, target: any, event: string): KnockoutSubscription;
extend(requestedExtenders: { [key: string]: any; }): KnockoutObservableArray<T>;
}
@@ -325,7 +332,7 @@ interface KnockoutUtils {
}
interface KnockoutArrayChange<T> {
status: string;
status: "added" | "deleted";
value: T;
index: number;
moved?: number;

2
knockout/knockoutamd-tests.ts
View File

@@ -1,6 +1,6 @@
/// <reference path="./knockout.d.ts" />
import ko = require("knockout");
import ko = require("knockout");
var myArray = ko.observableArray([1, 2, 3]);

35
knockout/tests/knockout-tests.ts
View File

@@ -680,3 +680,38 @@ function test_tasks() {
setTimeout(callback, 0);
};
}
function observableEventsTests() {
var observable = ko.observable(1);
observable.subscribe(value => {
var num: number = value;
});
observable.subscribe(value => {
var num: number = value;
}, null, "change");
observable.subscribe(value => {
var num: number = value;
}, null, "beforeChange");
}
function observableArrayEventsTests() {
var observableArray = ko.observableArray([1, 2, 3, 4]);
observableArray.subscribe(array => {
var arr: number[] = array;
});
observableArray.subscribe(array => {
var arr: number[] = array;
}, null, "change");
observableArray.subscribe(array => {
var arr: number[] = array;
}, null, "beforeChange");
var count = 0;
observableArray.subscribe(changes => {
changes.forEach(change => {
if (change.status == "added")
count++;
else if (change.status == "deleted")
count--;
});
}, null, "arrayChange");
}