kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-01-12 22:46:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

SortFunction signature should match Array.sort (#29468)

Browse Source 
-1 and 1 aren't the only numbers allowed. Any number less than or greater than 0 will sort the item properly.
This enables shortcuts like (a, b) => a - b;
Restricting the signature to -1 | 0 | 1 is a mistake.
This commit is contained in:
nixxquality
2018-10-10 21:53:18 +02:00
committed by Andy
parent 95fdf92cc2
commit 3d6ded6cd7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
types/react-table/index.d.ts vendored
View File

@@ -27,7 +27,7 @@ export type SortedChangeFunction = (newSorted: SortingRule[], column: any, addit
export type FilteredChangeFunction = (newFiltering: Filter[], column: any, value: any) => void;
export type ExpandedChangeFunction = (column: any, event: any, isTouch: boolean) => void;
export type ResizedChangeFunction = (newResized: Resize[], event: any) => void;
export type SortFunction = (a: any, b: any, desc: any) => -1 | 0 | 1;
export type SortFunction = (a: any, b: any, desc: any) => number;
export interface Resize {
id: string;