kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-23 21:00:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #23342 from jeremejevs/patch-1

Browse Source 
[bluebird-global] Fix finally
This commit is contained in:
Daniel Rosenwasser
2018-02-15 17:36:56 -08:00
committed by GitHub
parent 480cab7dcb 39384f10de
commit 09baac6869
1 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
types/bluebird-global/index.d.ts vendored
View File

@@ -31,6 +31,22 @@
* in the runtime. Do this by either importing bluebird.js via a `<script />` tag in your html or
* via importing it in your js entry file AND assigning it to the global Promise symbol.
*
* c) if you're `--target`ing "es5", then you'll need to include the "es2015.iterable" lib typings to
* let the bluebird.d.ts compile (requirement for Map, Iterable & friends). This is only for the
* compile-time, since bluebird doesn't require these es6 features to be present in the runtime.
* To summarise: when targeting "es5", make sure you have the follwing "lib" config in your tsconfig.json:
*
* {
* "compilerOptions": {
* "lib": [
* "es5",
* "es2015.iterable",
* "dom"
* (more, if you need...)
* ],
* }
* }
*
* 3. Why so much effort?
*
* If a promise-polyfilling library wants to play nicely with TypeScript, it needs to augment
@@ -38,7 +54,7 @@
* For various reasons this couldn't be done in The `bluebird` typings.
*
* 4. Contributors: After changing this file please manually test these cases (via altering ./tsconfig.json ):
* a. target es5, no `lib` key
* a. target es5, with the following `lib` keys: "es5", "es2015.iterable", "dom"
* b. target es6, no `lib` key
* c. target es5, latest "es20xx", e.g. "es2017"
* d. target es6, latest "es20xx", e.g. "es2017"
@@ -65,7 +81,7 @@ declare global {
each: typeof Bluebird.prototype.each;
error: typeof Bluebird.prototype.error;
filter: typeof Bluebird.prototype.filter;
finally: typeof Bluebird.prototype.finally;
// finally: typeof Bluebird.prototype.finally;
get: typeof Bluebird.prototype.get;
isCancelled: typeof Bluebird.prototype.isCancelled;
isFulfilled: typeof Bluebird.prototype.isFulfilled;
@@ -124,6 +140,11 @@ declare global {
catch<E extends Error, U>(ErrorClass: new (...args: any[]) => E, onReject: (error: E) => U | PromiseLike<U>): Bluebird<U | T>;
catch(predicate: Object, onReject: (error: any) => T | PromiseLike<T> | void | PromiseLike<void>): Bluebird<T>;
catch<U>(predicate: Object, onReject: (error: any) => U | PromiseLike<U>): Bluebird<U | T>;
/*
* See comments above `then` for the reason why this is needed. Taken from esnext.promise.d.ts.
*/
finally(onfinally?: (() => void) | undefined | null): Promise<T>;
}
/*