Fix incorrectly typed GatewayDest's component prop in react-gateway (#27414)

* Use correct type for GatewayDestProps component

* Test react-gateway GatewayDest component prop type

* Add another test for react-gateway GatewayDest component prop type
This commit is contained in:
Kamil Waheed
2018-07-21 03:53:51 +03:00
committed by Wesley Wigham
parent 7212e9a242
commit 08cd3c3b36
2 changed files with 14 additions and 2 deletions

View File

@@ -4,7 +4,7 @@ declare namespace GatewayDest {
interface GatewayDestProps {
name: string;
tagName?: string;
component?: string | React.Component;
component?: string | React.ComponentClass;
}
}
declare class GatewayDest extends React.Component<GatewayDest.GatewayDestProps> { }

View File

@@ -1,6 +1,14 @@
import * as React from 'react';
import { Gateway, GatewayProvider, GatewayDest } from 'react-gateway';
class GatewayComponent extends React.Component {
render() {
return (
<div>{this.props.children}</div>
);
}
}
class ReactGateway extends React.Component<Gateway.GatewayProps> {
render() {
return (
@@ -17,7 +25,9 @@ class ReactGatewayProvider extends React.Component {
render() {
return (
<GatewayProvider>
<GatewayDest name="test" />
<GatewayDest name="test" component={GatewayComponent} />
<GatewayDest name="test2" component="span" />
<GatewayDest name="test3" />
<div>
All the way down...
<div>
@@ -26,6 +36,8 @@ class ReactGatewayProvider extends React.Component {
Getting close...
<div>
<ReactGateway into="test" />
<ReactGateway into="test2" />
<ReactGateway into="test3" />
</div>
</div>
</div>