Commit Graph

1550 Commits

Author SHA1 Message Date
Luke Parham
d9559111a0 renamed nic cage sample, added redundancy for loading player in case its nil when visible, added video tests, disabled assert for new range controller 2016-01-14 02:39:36 -06:00
Luke Parham
579313f086 Merge branch 'master' into ASVideoNode 2016-01-13 12:22:55 -06:00
appleguy
516e1f177d Merge pull request #1053 from facebook/ASRangeControllerBetaOptimizations
Substantial optimizations for ASRangeControllerBeta & recursivelySetInterfaceState:.
2016-01-10 03:31:52 -08:00
Scott Goodson
90a1bb2346 Ruthlessly improve efficiency in ASRangeControllerBeta.
- Use completedNodes directly, caching inner arrays and counts between loop iterations.
- Merge codepaths between the "entire self - table / collection" visible or invisible cases
- Ensure we do not trigger an assertion if a previous iteration's node is nil by the time
  we try to reset its interfaceState.
2016-01-10 02:58:48 -08:00
Scott Goodson
0feaa2a368 Improvements to the efficiency of recursivelySetInterfaceState: and the beta range controller. 2016-01-10 02:40:47 -08:00
appleguy
03d13b19b0 Merge pull request #1051 from facebook/TableCollectionRangeEtc
Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle).
2016-01-09 21:19:12 -08:00
Scott Goodson
d45db5ac32 Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle). 2016-01-09 20:44:24 -08:00
appleguy
c3ef2efe0c Merge pull request #1040 from facebook/ASRangeControllerBetaScrollJump
[ASRangeControllerBeta] Support disjoint ranges between updates (scroll jumps, etc)
2016-01-09 15:54:05 -08:00
appleguy
2f7aae194a Merge pull request #1042 from binl/bl_control_state_fix
Make ASControlState imitate UIControlState
2016-01-06 17:50:27 -08:00
Bin Liu
a36a955eb0 fix indentation 2016-01-06 13:09:59 -08:00
Bin Liu
4435405cbb Make ASControlState imitate UIControlState
- selected state isn't implicitly controlled by ASControlNode anymore
- highlighted state can be overriden by users
- Decouple ASButtonNode's state from control events
2016-01-06 12:17:52 -08:00
Scott Goodson
bbfd08829f Switch Tests to use ASRangeControllerBeta. Use NSSet instead of NSMutableSet. 2016-01-05 23:29:11 -08:00
Scott Goodson
d1c3894dbb [ASRangeControllerBeta] Add tracking of all index paths that have .interfaceState set, ensure updating. 2016-01-05 23:17:54 -08:00
appleguy
fa9668a94b Merge pull request #1038 from binl/bl_button_states
[ASButtonNode] Use ASControlState instead of declaring a unique ASButtonState type.
2016-01-05 22:11:24 -08:00
Bin Liu
6a4c953443 fix build failure 2016-01-05 21:20:52 -08:00
Bin Liu
4f67050b9b Fix another typo, fix build failure 2016-01-05 18:04:26 -08:00
Bin Liu
82c098b39d Fixed typo 2016-01-05 17:35:30 -08:00
Bin Liu
6bb51063f9 Replace ASButtonState with ASControlState 2016-01-05 17:07:44 -08:00
appleguy
8a5f080fcc Merge pull request #1026 from 1nput0utput/ASControlNodeMutationCrash
[ASControlNode] Copy event table before calling action methods, as they may trigger action removal.
2016-01-03 20:18:30 -08:00
appleguy
005408bd2c Merge pull request #1030 from facebook/OthogonalEfficiency
[ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible.
2016-01-03 20:17:25 -08:00
appleguy
5737f31a58 Merge pull request #1029 from rahul-malik/rmalik-asviewcontroller-generics
[ASViewController] Update interface to use lightweight generics (covariant node type).
2016-01-03 19:31:26 -08:00
Scott Goodson
984fe43997 [ASRangeController] Inspect delegate's ASInterfaceState to delay preloading beyond viewport until visible. 2016-01-03 19:14:07 -08:00
Rahul Malik
a509b7523f Update interface of ASViewController to use lightweight generics. This allows
subclasses of ASViewController to specify the type of ASDisplayNode it
contains which allows for stronger type-checking and auto-completion against
the specified type.

Example Subclass Declaration:
@interface MyASViewController : ASViewController<MyASDisplayNodeSubclass *>
@end
2016-01-03 18:56:09 -08:00
Rajinder Ramgarhia
688e8d27de Add comment explaning the change 2016-01-03 11:02:33 -05:00
appleguy
95bd2c264c Merge pull request #1027 from facebook/ASCollectionInternal
Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer.
2016-01-02 00:05:04 -08:00
Scott Goodson
25b6f29584 Introduce ASCollectionInternal file and create always-available ASCView -> ASCNode backpointer. 2016-01-01 23:36:00 -08:00
Rajinder Ramgarhia
73373ee17b Fix ASControlNode mutation crash 2016-01-01 22:27:08 -05:00
Scott Goodson
1d1a248167 Bump podspec to 1.9.5 for upcoming development cycle, now that 1.9.4 is tagged and launched. 2016-01-01 01:35:11 -08:00
appleguy
c40c2d383b Merge pull request #1024 from facebook/RangeControllerBeta
[ASRangeController] Newly rewritten, functional-style range controller based on ASInterfaceState.
2016-01-01 01:33:33 -08:00
Scott Goodson
b273f358f5 [ASRangeController] Initial implementation of functional-style, ASInterfaceState-based range controller. 2016-01-01 00:48:44 -08:00
Scott Goodson
7a9cd1f930 [ASRangeController] Introduce totally rewritten range controller based on ASInterfaceState. 2015-12-31 17:59:59 -08:00
Scott Goodson
8f914f8430 Fix logic error in handling enablement of beta display range. 1.9.4 2015-12-31 15:38:32 -08:00
Scott Goodson
aee7b3b77a Remove padding workaround from old CoreText days.
This is a vestige from Paper.  Discussion: https://github.com/facebook/AsyncDisplayKit/issues/1013
2015-12-31 01:52:08 -08:00
appleguy
640568aff8 Merge pull request #1022 from facebook/UICVUnsupported
Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance)
2015-12-31 01:03:33 -08:00
Scott Goodson
df9f433353 Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance) 2015-12-31 00:21:20 -08:00
appleguy
0636ec44ed Merge pull request #1021 from facebook/revert-1008-bridge-uitableviewcell-pointinside
Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell."
2015-12-30 23:45:15 -08:00
appleguy
50c97b2636 Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell." 2015-12-30 23:42:18 -08:00
appleguy
5a7772a0ae Merge pull request #1020 from facebook/RangeDeletions
Ensure that ASRangeController immediately removes any deleted nodes from its range state.
2015-12-30 23:07:32 -08:00
Scott Goodson
ffcddf36e2 Ensure that ASRangeController immediately removes any deleted nodes from its range state. 2015-12-30 22:42:11 -08:00
appleguy
9b9d8bc9b6 Merge pull request #1016 from facebook/RasterizationUnloadingNodes
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
2015-12-30 00:23:06 -08:00
appleguy
cc15d74e67 Merge pull request #1008 from yury/bridge-uitableviewcell-pointinside
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
2015-12-29 23:25:48 -08:00
Scott Goodson
df3ce787f7 Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal. 2015-12-29 23:11:33 -08:00
appleguy
95e28d6c11 Merge pull request #1015 from facebook/CollectionTableLayers
Use _ASDisplayLayer for both ASTableView and ASCollectionView.  zeroContentInsets to fix UIKit.
2015-12-29 23:10:43 -08:00
Scott Goodson
051f1f6cdd Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit. 2015-12-29 22:24:44 -08:00
appleguy
b1b9ad23d6 Merge pull request #1014 from facebook/PagerProxy
[ASPagerNode] Ensure delegate property can be set before the view is loaded.
2015-12-29 21:18:21 -08:00
Scott Goodson
1870208153 [ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten. 2015-12-29 20:46:42 -08:00
yury
83960065ed Code style fix 2015-12-29 12:10:08 +03:00
appleguy
0dc017918d Merge pull request #1012 from NatashaTheRobot/master
[Swift] Add Readme code snippet with example usage of an ASDisplayNode.
2015-12-28 23:06:10 -08:00
Natasha Murashev
90af0d393b Update README.md 2015-12-29 16:55:48 +13:00
Natasha Murashev
2ff683bc0b Added Swift example to README 2015-12-29 16:54:20 +13:00