Commit Graph

1581 Commits

Author SHA1 Message Date
appleguy
bde37ac3b8 Merge pull request #1089 from Adlai-Holler/TextNodeIgnoreEmptyStringReplace
[ASTextNode] Ignore Setting Text to Nil When Text Is Already Empty
2016-01-22 11:09:11 -08:00
appleguy
7f1ac58c69 Merge pull request #1095 from aaronschubert0/Code-Coverage-Fix-Coverage
Check to see if Clang code coverage is interfering with GCC
2016-01-22 11:03:20 -08:00
Aaron Schubert
4817484f47 Enable clang code coverage 2016-01-22 14:22:40 +00:00
Aaron Schubert
423a5b0752 Enabled Xcode 7 code coverage on project 2016-01-22 12:22:32 +00:00
Aaron Schubert
475c9c1e2c Check to see if Clang code coverage is interfering with GCC 2016-01-22 09:38:32 +00:00
appleguy
5a6d48b7d3 Merge pull request #1087 from aaronschubert0/patch-1
Update ReadMe to include Cocoapods downloads badge
2016-01-22 00:46:37 -08:00
appleguy
e5b2b566e4 Merge pull request #1084 from lkzhao/master
Update comments for ASPanningOverriddenUITextView
2016-01-21 23:17:17 -08:00
appleguy
992cc9fffa Merge pull request #1094 from binl/bl_layout_facilitator_beta
Remove public interface for ASCV with facilitator
2016-01-21 23:15:43 -08:00
Bin Liu
b2db6cce4d remove public interface for ASCV with facilitator 2016-01-21 22:39:27 -08:00
appleguy
aa0c64e8ea Merge pull request #1064 from binl/bl_layout_facilitator_change
Initial implementation of ASCollectionNode's LayoutFacilitator to help apps optimize custom layouts.
2016-01-21 21:12:02 -08:00
Bin Liu
1965018c46 attempt to fix build 2016-01-21 15:20:47 -08:00
Bin Liu
8d3c32727e fix build 2016-01-21 12:05:28 -08:00
Bin Liu
726bc7d668 addressed comments 2016-01-21 11:14:00 -08:00
Bin Liu
d07759ca40 Add file to project 2016-01-21 09:57:28 -08:00
aaronschubert0
2fc474ee75 Include manual downloads badge 2016-01-21 09:54:36 +00:00
Luke Zhao
882379a820 Update comments for ASPanningOverriddenUITextView 2016-01-20 16:33:45 -08:00
Adlai Holler
db18724d5b If they set attributedString to nil twice, ignore the second one. 2016-01-20 14:00:46 -08:00
Bin Liu
bc92c64e8c Proposed version 1 2016-01-20 02:34:32 -08:00
Bin Liu
da2cbf4644 initial design 2016-01-20 02:34:32 -08:00
aaronschubert0
42c56fc334 Update ReadMe to include Cocoapods badges
As specified in #1086. Hey @appleguy Turns out these links have been there all along but were just hidden since they were using http (I think). The img.shields.io is a bit unstable at times but seems to be the best solution so far. Will update in future if better solutions come up!
2016-01-20 09:30:19 +00:00
appleguy
3aceabbbf9 Merge pull request #1069 from lkzhao/master
[ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it.
2016-01-19 19:24:24 -08:00
appleguy
44aae77ef4 Merge pull request #1079 from aaronschubert0/ASTextNode-Fix-for-layout-bug
[ASTextKitRenderer] Potential fix headIndent attribute not being accounted for by the shadower.
2016-01-19 19:23:19 -08:00
appleguy
5be14e41fd Merge pull request #1078 from aaronschubert0/ASTableView-Layout-bug-fix
[ASTableView] Ensure -[super layoutSubviews] is called before messaging delegate.
2016-01-19 19:21:19 -08:00
appleguy
1e8c70726c Merge pull request #1083 from facebook/ASTableCollectionVisibility
Restore full functionality of the display / data ranges when not using the Node variants of Table / Collection.
2016-01-19 18:53:06 -08:00
appleguy
bd8ba38725 Merge pull request #1082 from Adlai-Holler/feature/RemoveSpinLock
Remove SpinLock to ensure it doesn't get used in new code.
2016-01-19 18:34:29 -08:00
Scott Goodson
b989be6499 Restore full functionality of the display / data ranges when not using the Node variants of Table / Collection. 2016-01-19 18:30:01 -08:00
Luke Zhao
995f437e12 Allow ASEditableTextNode to scroll 2016-01-19 10:32:19 -08:00
Adlai Holler
e972059f23 Remove SpinLock because it's illegal in iOS 2016-01-19 10:28:04 -08:00
Aaron Schubert
10a2984d8c Potential fix for #1076 2016-01-19 12:25:30 +00:00
Aaron Schubert
7821a0aa19 Fixes bug #1077 2016-01-19 11:43:03 +00:00
appleguy
46bcc90185 Merge pull request #1072 from knopp/ASCollectionView-content-offset-975
[ASCollectionView] prevent data controller from removing/adding sections during reloadDataImmediately.
2016-01-18 21:24:04 -08:00
Matej Knopp
a6da3d185a [ASCollectionView] prevent data controller from removing/adding sections during reloadDataImmediately
Signed-off-by: Matej Knopp <matej.knopp@gmail.com>
2016-01-17 19:25:03 +01:00
appleguy
58c2e8039f Merge pull request #1067 from facebook/ASCellNodeVCCreation
[ASCellNode] Ensure we don't trigger the UIViewController to be created early if we are wrapping one.
2016-01-14 23:30:57 -08:00
Scott Goodson
6741ae658e [ASCellNode] Ensure we don't trigger the UIViewController to be created early if we are wrapping one. 2016-01-14 23:28:15 -08:00
Scott Goodson
affb786a14 [ASButtonNode] Pass through setDisplaysAsynchronously: to subnodes (image and title). 2016-01-14 23:12:01 -08:00
appleguy
ebfbfab976 Merge pull request #1066 from facebook/PagerWeak
[ASPagerNode] Ensure new pager component has a weak reference to the data source.
2016-01-14 22:12:52 -08:00
Scott Goodson
e92a1360e7 Ensure new ASPagerNode has a weak reference to the data source. 2016-01-14 21:43:46 -08:00
Scott Goodson
df10f8f19a Check array size before accessing section - rare crash for improper data source use, de-escalated to messaging nil. 1.9.5 2016-01-14 00:25:53 -08:00
appleguy
9afb77f7bc Merge pull request #1058 from Adlai-Holler/DidEndDisplayingNodeProvideNode
Add New didEndDisplayingNode:forItemAtIndexPath: delegate methods to provide removed node
2016-01-13 23:55:34 -08:00
appleguy
a0c7b0a7b5 Merge pull request #1061 from dinhviethoa/ascontrolnode-touchesended-twice
Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice.
2016-01-13 23:26:53 -08:00
Viet Hoa Dinh
dbe068c970 Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice. 2016-01-13 19:06:01 -08:00
appleguy
d56f0b14f4 Merge pull request #1060 from Adlai-Holler/FixRangeControllerUpdateIssue
Resolve Internal Inconsistency During Updates When Using Stable Range Controller
2016-01-13 18:52:52 -08:00
Adlai Holler
a19ba586f7 Revert change that seems to have caused internal inconsistency in range controller 2016-01-13 13:34:20 -07:00
Adlai Holler
d19e56d802 Beef up documentation around new delegate methods 2016-01-12 23:27:30 -07:00
Adlai Holler
5e72daa2e3 Pass node along in didEndDisplayingNode method 2016-01-12 15:42:37 -07:00
appleguy
516e1f177d Merge pull request #1053 from facebook/ASRangeControllerBetaOptimizations
Substantial optimizations for ASRangeControllerBeta & recursivelySetInterfaceState:.
2016-01-10 03:31:52 -08:00
Scott Goodson
90a1bb2346 Ruthlessly improve efficiency in ASRangeControllerBeta.
- Use completedNodes directly, caching inner arrays and counts between loop iterations.
- Merge codepaths between the "entire self - table / collection" visible or invisible cases
- Ensure we do not trigger an assertion if a previous iteration's node is nil by the time
  we try to reset its interfaceState.
2016-01-10 02:58:48 -08:00
Scott Goodson
0feaa2a368 Improvements to the efficiency of recursivelySetInterfaceState: and the beta range controller. 2016-01-10 02:40:47 -08:00
appleguy
03d13b19b0 Merge pull request #1051 from facebook/TableCollectionRangeEtc
Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle).
2016-01-09 21:19:12 -08:00
Scott Goodson
d45db5ac32 Disable creation of backing ASTable/CollectionNode for the *View varients (retain cycle). 2016-01-09 20:44:24 -08:00