appleguy
bae2f232f0
Merge pull request #1407 from nguyenhuy/cancel_layout_transitions
...
[ASDisplayNode] [Async layout transition] Add method to cancel layout transitions in progress
2016-03-20 23:24:18 -07:00
Huy Nguyen
9e76d7b603
Add method to cancel layout transitions in progress
...
- Also make sure a transition isn't invalidated right after it passed the validation test and before it proceeds
2016-03-20 23:17:35 -07:00
appleguy
1a57e2c097
Merge pull request #1406 from rahul-malik/rmalik-button-a11y
...
[Accessibility] Basic a11y support for ASButtonNode (adopt text node title as a11y label)
2016-03-20 19:24:55 -07:00
Rahul Malik
4eb3356615
Basic a11y support for ASButtonNode
2016-03-20 19:22:53 -07:00
appleguy
a9eaa9cc82
Merge pull request #1405 from facebook/RelativeSpec
...
[ASRelativeLayoutSpec] New Layout Spec for 9-part rectangular positioning (corners, edges, center).
2016-03-20 01:05:12 -07:00
Sam Stow
086bd8a52b
[ASRelativeLayoutSpec] New core layout spec type: Relative Position, now powers Center as well.
...
This spec allows positioning a child at any 9-part box position (corners, edges, or center).
2016-03-19 22:37:02 -07:00
appleguy
4297cb1eb5
Merge pull request #1398 from facebook/Placeholders
...
[ASDisplayNode] Placeholders should always be recreated if returning to cleared nodes, and remain until ASNetwork/MultiplexImageNode finish loading their image from the network.
2016-03-19 21:19:05 -07:00
appleguy
36437f2fb7
Merge pull request #1399 from facebook/MKCancel
...
[ASMapNode] Reduce number of MapKit calls to -cancel by using the .isLoading property.
2016-03-19 21:16:30 -07:00
appleguy
636b7d937f
Merge pull request #1404 from facebook/pragma
...
[AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale).
2016-03-19 21:15:44 -07:00
appleguy
ebd3567f1b
Merge pull request #1262 from ekurutepe/carthage-example
...
[Carthage] Build Test project to ensure framework is never left behind by file additions.
2016-03-19 21:14:46 -07:00
Scott Goodson
8308a4ce49
[AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale).
2016-03-19 19:56:41 -07:00
appleguy
5feedb002f
Merge pull request #1403 from hannahmbanana/fixCustomCollectionExampleApp
...
[CustomCollectionView Example] Fix shouldInvalidateLayoutForBoundsChange: method
2016-03-19 19:08:11 -07:00
appleguy
178301200b
Merge pull request #1402 from hannahmbanana/master
...
[ASVideoNode] Add to AsyncDisplayKit.h
2016-03-19 19:05:42 -07:00
Hannah Troisi
2dae2d1c09
[CustomCollectionView Example]
...
Issue (#1366 ):
CustomColelctionView example app always returns YES from shouldInvalidateLayoutForBoundsChange: which triggers a re-layout.
Fix:
Comparing CGSize rather than CGRect is enough to handle rotation support without always triggering a re-layout. .
2016-03-19 18:14:19 -07:00
Hannah Troisi
d99a13f1a7
Revert "[CustomCollectionView Example]"
...
This reverts commit fcccb1bf03
2016-03-19 18:10:08 -07:00
Hannah Troisi
fcccb1bf03
[CustomCollectionView Example]
...
Issue (#1366 ):
CustomColelctionView example app always returns YES from shouldInvalidateLayoutForBoundsChange: which triggers a re-layout.
Fix:
Comparing CGSize rather than CGRect is enough to handle rotation support without always triggering a re-layout. .
2016-03-19 18:00:24 -07:00
Hannah Troisi
f9a92366d3
[AsyncDisplayKit] Fix build so we can weak link AVFoundation
...
Unclear why the framework target required these seemingly unrelated changes to Collection
classes, but I modeled them after related files and it seems cleaner now (passes tests & framework target)
2016-03-19 17:54:02 -07:00
Hannah Troisi
b98920c19f
[ASVideoNode] Add to ASDK umbrella header
2016-03-19 17:10:47 -07:00
Hannah Troisi
5716cbf18c
Merge remote-tracking branch 'facebook/master'
2016-03-18 23:48:17 -07:00
Scott Goodson
7bb48d266c
[ASMapNode] Reduce number of MapKit calls to -cancel by using the .isLoading property.
2016-03-18 23:31:33 -07:00
Scott Goodson
c5c7abb1d6
[ASDisplayNode] Placeholders should always be recreated if returning to past nodes.
...
If previously-displayed contents is gone (e.g. clearContents), and is not finished displaying
by the time the node is onscreen, recreate the placeholder immediately.
2016-03-18 21:13:26 -07:00
appleguy
0745eabec9
Merge pull request #1397 from maicki/ASRunLoopQueueContinueProcessing
...
[ASRunLoopQueue] Add custom run loop source to signal if jobs are still enqueued, to guarantee another runloop turn.
2016-03-18 14:48:50 -07:00
Michael Schneider
14b9df30a3
Create CFRunLoopSourceContext via calloc
2016-03-18 14:32:45 -07:00
Michael Schneider
d1756baae7
Add custom run loop source to signal if new jobs are enqueued in ASRunLoopQueue
...
It is not guaranteed that the runloop will turn if it has no scheduled work, and this causes processing of the queue to stop. Attaching a custom loop source to the run loop and signal it if new work needs to be done
2016-03-18 14:02:27 -07:00
appleguy
c8cbd2ec4a
Merge pull request #1393 from ejensen/cleanup
...
[Refactoring] Redundant function removal; Ternary formatting
2016-03-17 13:47:02 -07:00
Engin Kurutepe
2a978054f2
remove Cartfile.resolved
2016-03-17 20:27:03 +01:00
Eric Jensen
6739a3a4ab
Condition logic simplification
2016-03-17 11:22:53 -07:00
Eric Jensen
17aebcbaba
Add a space between the ? and : in ternarys
2016-03-17 10:38:51 -07:00
Eric Jensen
14a389c5e0
Replace ASTextKitAttributes' objectsEqual with the shared ASObjectIsEqual
2016-03-17 10:36:35 -07:00
Engin Kurutepe
ad09d83f19
make the sample scheme shared
2016-03-17 15:22:00 +01:00
Engin Kurutepe
e11ed66d99
use current-branch in carthage build
2016-03-17 15:00:32 +01:00
Engin Kurutepe
229bce7f42
disable autocreate schemes
2016-03-17 14:49:14 +01:00
Engin Kurutepe
618febd29b
Merge pull request #2 from ekurutepe/master
...
pull changes from master
2016-03-17 14:15:55 +01:00
Engin Kurutepe
780b00c0f9
Merge pull request #1 from facebook/master
...
pull changes from upstream
2016-03-17 14:13:41 +01:00
Hannah Troisi
69c3b6172c
Merge remote-tracking branch 'facebook/master'
2016-03-17 03:09:21 -07:00
appleguy
d9ef0922d8
Merge pull request #1354 from ejensen/cleanup
...
[Refactoring] Objective-C 2.0 / Modern syntax for arrays, dictionaries, numbers; logic simplification
2016-03-17 01:06:33 -07:00
Hannah Troisi
19f0d5982b
Merge remote-tracking branch 'facebook/master'
2016-03-16 23:16:39 -07:00
appleguy
2ad9d83520
Merge pull request #1353 from ejensen/spelling
...
[Documentation] Correct spelling errors
2016-03-16 22:53:15 -07:00
Hannah Troisi
2d1a8ff4d2
Merge remote-tracking branch 'facebook/master'
2016-03-16 22:48:25 -07:00
appleguy
37a0ba200c
Merge pull request #1391 from facebook/ImageNodeDeadlock
...
[ASImageNode] -setDefaultImage: should release lock before calling -setImage:
2016-03-16 22:16:06 -07:00
appleguy
5788e40719
Merge pull request #1389 from maicki/ImproveASViewControllerExample
...
[Examples] Improve ASViewController example
2016-03-16 21:32:57 -07:00
Scott Goodson
a966b7b6a6
[ASImageNode] -setDefaultImage: should release lock before calling -setImage:
...
This allows -setImage: to fully unlock before it calls -invalidateCalculatedSize.
2016-03-16 20:55:08 -07:00
Hannah Troisi
e4348c0516
Merge remote-tracking branch 'facebook/master'
2016-03-16 18:16:59 -07:00
appleguy
5f58b9d8af
Merge pull request #1382 from maicki/AutomaticRangeModeImprovements
...
[ASRangeController] Improvements for automatic range mode to ensure it is persistent / stable if set for an invisible view.
2016-03-16 16:50:28 -07:00
Michael Schneider
e297608e2a
In the first range update and the range mode is not explicitly use the automatic range mode detection
...
This is necessary to get out of the initial range mode state into the first defined range mode state
2016-03-16 16:44:58 -07:00
Michael Schneider
e82118e72f
Add assertion for ASDisplayNode is layer backed if using ASInterfaceStateForDisplayNode
2016-03-16 16:27:08 -07:00
Michael Schneider
41ca796ef4
Improve logic around choosing the range mode automatically and update documentation around logic
2016-03-16 13:37:33 -07:00
Michael Schneider
8d771f930a
Refactor calculation of interface state based on ASDisplayNode and window
2016-03-16 13:26:17 -07:00
Michael Schneider
3b4e8d732c
Improve way to detect interface state of ASCollectionView and ASTableView
2016-03-16 11:45:22 -07:00
Michael Schneider
19232ac493
Address pull request comments
2016-03-16 11:44:56 -07:00
