Commit Graph

2346 Commits

Author SHA1 Message Date
Scott Goodson
a36cf79300 [AsyncDisplayKit] Main .podspec update to 1.9.7.1 (final GM of 1.9.7, as the tag changed). Uses PINRemoteImage 2.1.2. 2016-03-25 20:50:12 -07:00
appleguy
dba16ce009 Merge pull request #1433 from levi/patch-12
Fix PagerNode from not loading
2016-03-25 12:02:12 -07:00
Levi McCallum
c07175bfcb Fix conditional 2016-03-25 11:54:56 -07:00
Levi McCallum
687be58621 Fix PagerNode from not loading 2016-03-25 10:02:47 -07:00
appleguy
c1330682f9 Merge pull request #1430 from levi/patch-11
[ASPagerNode] Prevent calculation of current index path when the collection view is empty
2016-03-24 21:43:30 -07:00
Levi McCallum
f51ca78570 Simplify boolean logic 2016-03-24 21:40:49 -07:00
Levi McCallum
d845a18dfb Prevent calculation of current index path when the collection view is empty 2016-03-24 21:33:01 -07:00
appleguy
1199dd69f7 Merge pull request #1429 from ejensen/scroll-enabled-fix
[ASEditableTextNode] Assign textView's scrollEnabled on creation
2016-03-24 21:03:08 -07:00
appleguy
809563ece4 Merge pull request #1420 from hannahmbanana/fixSocialSampleApp
[SocialAppLayout example] update to use ASTextNode's passthroughNonlinkTouches property
2016-03-24 21:01:46 -07:00
Eric Jensen
057ec55941 Correct documentation comments 2016-03-24 20:08:03 -07:00
Eric Jensen
7de48da44f Correct ASEditableTextNode's default value according to the documentation 2016-03-24 20:00:53 -07:00
Eric Jensen
f988f86f7f Assign the textView's scrollEnabled property in ASEditableTextNode's didLoad method.
This prevents a mismatch if the scrollEnabled property on ASEditableTextNode is set before the textView is loaded.
2016-03-24 19:51:16 -07:00
Scott Goodson
eed812dcdf [ASRangeController] Slight tweaks to the default Full ranges, for memory savings in multi-tabbed apps with still-excellent preloading consistency. 1.9.7 2016-03-23 23:36:59 -07:00
appleguy
36d23230fe Merge pull request #1421 from Adlai-Holler/AvoidMutatingSublayersDuringEnumeration
[ASDisplayNode] When Enumerating Subtree, Copy sublayers to Avoid NSFastEnumerationMutation Exception
2016-03-23 23:33:48 -07:00
Hannah Troisi
6c4af53434 Revert project changes for Social App Example 2016-03-23 23:25:26 -07:00
Adlai Holler
a90a83b607 Copy sublayers to avoid NSFastEnumerationMutation exception 2016-03-23 21:57:23 -07:00
Hannah Troisi
c2e5db85ae [SocialAppLayout example] update to use ASTextNode's passthroughNonlinkTouches property 2016-03-23 21:32:05 -07:00
Hannah Troisi
18b17a1ecc Merge remote-tracking branch 'facebook/master' 2016-03-23 21:24:05 -07:00
appleguy
4ffaebc93b Merge pull request #1409 from ejensen/swift-alignment-enum
[Refactoring] ASHorizontalAlignment & ASVerticalAlignment Swift interface
2016-03-23 21:03:44 -07:00
appleguy
ac5d0265d9 Merge pull request #1408 from ejensen/swift-enum
[Refactoring] ASCellNodeVisibilityEvent Swift interface
2016-03-23 21:02:45 -07:00
appleguy
fe868b14f4 Merge pull request #1418 from levi/patch-10
[ASPagerNode] Nil out currentIndexPath after usage to prevent ASPagerFlowLayout crashes
2016-03-23 18:35:05 -07:00
Levi McCallum
f760c8460a Nil out currentIndexPath after usage to prevent ASPagerFlowLayout crashes 2016-03-23 17:55:25 -07:00
appleguy
505d4ffb5d Merge pull request #1416 from maicki/ASRunLoopQueueAddWakeUpCall
[ASRunLoopQueue] Add CFRunLoopWakeUp in processQueue
2016-03-22 20:30:38 -07:00
Hannah Troisi
aa9f21063f Merge remote-tracking branch 'facebook/master' 2016-03-22 20:24:40 -07:00
Michael Schneider
4207e0e1a6 Add CFRunLoopWakeUp in processQueue 2016-03-22 20:19:17 -07:00
Scott Goodson
e59431e702 [ASDisplayNode] Restore dispatch_async for clearContents, to prevent discarding contents for nodes that are simply moving to a new container. 2016-03-22 18:39:23 -07:00
Scott Goodson
5b9302b681 Revert "Prevent deallocation of asyncDataSource and asyncDelegate in ASCollectionView and ASTableView"
This reverts commit 3668f45286.
2016-03-22 14:38:50 -07:00
Scott Goodson
953c0f51f0 Revert "Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths"
This reverts commit 41362fca39.
2016-03-22 14:37:49 -07:00
appleguy
2319197a59 Merge pull request #1415 from facebook/DeallocInterfaceState
[ASInterfaceState] Clear the "Visible" bit immediately upon deallocation, rather than waiting for ASRangeController on the next runloop.
2016-03-22 14:37:29 -07:00
Scott Goodson
76b38cbe6e [ASInterfaceState] Clear the "Visible" bit immediately upon deallocation, rather than waiting for ASRangeController on the next runloop. 2016-03-22 14:32:32 -07:00
appleguy
1f3cedb4b6 Merge pull request #1414 from maicki/LastRangeUpdateBeforeClosing
[ASRangeController] Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths
2016-03-22 13:17:42 -07:00
Michael Schneider
41362fca39 Move call of range update completion blocks to consider early returns in _updateVisibleNodeIndexPaths 2016-03-22 12:43:09 -07:00
appleguy
e4f14c34f3 Merge pull request #1412 from maicki/LastRangeUpdateBeforeClosing
[ASRangeController] Prevent deallocation of dataSource & delegate in Collection & Table when navigating back, during final range update.
2016-03-22 12:15:07 -07:00
Michael Schneider
3668f45286 Prevent deallocation of asyncDataSource and asyncDelegate in ASCollectionView and ASTableView
Grab a strong reference for asyncDataSource and asyncDelegate in ASCollectionView and ASTableView before executing the range update to be sure they are not going away while executing the range update. This can happen in range updates while going back in the view controller hierarchy
2016-03-22 08:09:59 -07:00
Hannah Troisi
3d781d53d4 Merge remote-tracking branch 'facebook/master' 2016-03-21 18:18:37 -07:00
appleguy
fbe87cde4b Merge pull request #1410 from maicki/ASRunLoopQueueImproveProcessTriggering
[ASRunLoopQueue] Always signal runloop source if queue is not fully drained, to ensure more batches are guaranteed to run.
2016-03-21 17:12:39 -07:00
Michael Schneider
a937184a0b Remove CFRunLoopWakeUp in CFRunLoop observer callback
We don't nee CFRunLoopWakeUp as at this time are currently running in an observer callback, and after running all of the BeforeWaiting observers it must surely check for more sources / etc to run before determining if it will sleep
2016-03-21 17:10:29 -07:00
Michael Schneider
b3e98e9f5f If the queue is not fully drained yet force another run loop to process next batch of items 2016-03-21 16:58:39 -07:00
Eric Jensen
12da9ac6a9 Improve Swift compatibility of ASHorizontalAlignment & ASVerticalAlignment by using consistent naming 2016-03-21 11:16:28 -07:00
Eric Jensen
b733936133 Improve Swift compatibility of ASCellNodeVisibilityEvent by using NS_ENUM macro 2016-03-21 11:10:28 -07:00
appleguy
bae2f232f0 Merge pull request #1407 from nguyenhuy/cancel_layout_transitions
[ASDisplayNode] [Async layout transition] Add method to cancel layout transitions in progress
2016-03-20 23:24:18 -07:00
Huy Nguyen
9e76d7b603 Add method to cancel layout transitions in progress
- Also make sure a transition isn't invalidated right after it passed the validation test and before it proceeds
2016-03-20 23:17:35 -07:00
appleguy
1a57e2c097 Merge pull request #1406 from rahul-malik/rmalik-button-a11y
[Accessibility] Basic a11y support for ASButtonNode (adopt text node title as a11y label)
2016-03-20 19:24:55 -07:00
Rahul Malik
4eb3356615 Basic a11y support for ASButtonNode 2016-03-20 19:22:53 -07:00
appleguy
a9eaa9cc82 Merge pull request #1405 from facebook/RelativeSpec
[ASRelativeLayoutSpec] New Layout Spec for 9-part rectangular positioning (corners, edges, center).
2016-03-20 01:05:12 -07:00
Sam Stow
086bd8a52b [ASRelativeLayoutSpec] New core layout spec type: Relative Position, now powers Center as well.
This spec allows positioning a child at any 9-part box position (corners, edges, or center).
2016-03-19 22:37:02 -07:00
appleguy
4297cb1eb5 Merge pull request #1398 from facebook/Placeholders
[ASDisplayNode] Placeholders should always be recreated if returning to cleared nodes, and remain until ASNetwork/MultiplexImageNode finish loading their image from the network.
2016-03-19 21:19:05 -07:00
appleguy
36437f2fb7 Merge pull request #1399 from facebook/MKCancel
[ASMapNode] Reduce number of MapKit calls to -cancel by using the .isLoading property.
2016-03-19 21:16:30 -07:00
appleguy
636b7d937f Merge pull request #1404 from facebook/pragma
[AsyncDisplayKit] Adopt #pragma once, remove last remaining dispatch_sync (UIScreen scale).
2016-03-19 21:15:44 -07:00
appleguy
ebd3567f1b Merge pull request #1262 from ekurutepe/carthage-example
[Carthage] Build Test project to ensure framework is never left behind by file additions.
2016-03-19 21:14:46 -07:00