4 Commits

Author SHA1 Message Date
Aram Drevekenin
eee5bee556 fix: Add Node 10 support (#5769)
**Summary**

1. Added node 10 to CircleCI
2. Fixed a test that was using the `net.createServer` method. This was having issues, likely because of this: https://github.com/nodejs/node/issues/20334 - it now uses a "normal" `http` server instead, serving the same purpose.
3. Changed the `readFirstAvailableStream` method in `util/fs.js`. I'm guessing this is related to the same issue as 2, but there have been quite some changes in `10` that might be causing this - so it's just a guess. Since this piece of code could be clearer and more conceise anyway, I opted to just change it. Now instead of relying on the stream `error` event to check if a file exists, it just explicitly checks it before starting the stream.
4. Upgraded `upath` from `1.0.2` to `1.0.5` which supports node 10 (found through its `engines` field when installing).
5. Upgraded Jest
6. Fixed a bug regarding replacing symlinks to non-existent targets on Windows
7. Removed a redundant test
8. Fixed two test cases that were failing frequently on macOS builds

fixes #5761
fixes #5477

**Test plan**

CI should be green (including and especially the new node10 job!)
2018-05-23 11:16:38 +01:00
Valerii Iatsko
d43340c05d Updated node to 8.x in Dockerfile.dev (#4607) 2017-10-03 21:20:34 +11:00
Daniel Lo Nigro
68d59b98e4 Update Dockerfiles (#3934) 2017-07-17 14:53:41 +01:00
Daniel Lo Nigro
7182302de3 Create Docker image for Node.js + Yarn (#2721)
* Create Docker image for Node.js + Yarn

* Fix comment in Dockerfile.node7
2017-02-18 17:22:30 -08:00