**Summary**
_To be a good citizen of UNIX ecosystem._
One may write a script to add `$(yarn global bin)` to `$PATH`, but one must consider different cases depending on what this command returns in STDOUT. This is not ideal.
And, of course, error messages such as this naturally belongs to STDERR.
**Test plan**
```sh-session
$ yarn global bin 2>/dev/null
$
```
**Summary**
This addresses some of the windows issues regarding running yarn in gitbash and friends envrionment.
with this fix I keep the behavior introduced 5 months ago in yarnpkg/yarn#3245, but try to do a better job detecting when to use winpty out of the box, in order make `piping` of output work with yarn.
Before this fix:
```shell
$ yarn --version
1.1.0
$ yarn --version | cat
1.1.0
$ yarn init
yarn init v1.1.0
error An unexpected error occurred: "Can't answer a question unless a user TTY".
info If you think this is a bug, please open a bug report with the information provided in "D:\\workspace\\yarn\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/init for documentation about this command.
```
Piping works for simple commands, but interactive commands only work with an environment set to something. This prohibits scripts/tools around yarn that uses pipe, which is quite common to do in an unix like environment, but theses tools cannot work in windows' unix like environment.
WinPTY seems to be the savior here, but we need to only run yarn through winpty when a tty actually needs to be allocated.
Previous attempts to solve this problem like:
- yarnpkg/yarn#2230
- yarnpkg/yarn#2243
Did not address the use cases of piping, so they essentially broke that behavior.
Then yarnpkg/yarn#3245 fixed that, but now you have to use `YARN_FORCE_WINPTY=1` environment variable in order for `yarn init` and `yarn upgrade-interactive` to work and that's alright, but if you export that variable then piping is broken yet again because the variable will also be set in the piped command, and we haven't solved any problem.
I suggest we keep the environment variable behavior but open up for better detection when to use winpty out of the box.
This fix detects if the winpty binary is in path, and only use it if stdin is in fact a TTY: `test -t 1`.
**Test plan**
The output of running:
- `yarn init`
- `yarn upgrade-interactive`
- `yarn --version | cat`
Without having the `YARN_FORCE_WINPTY=1` environment variable set.
```shell
$ ./bin/yarn init
yarn init v1.1.0
question name (yarn):
$ ./bin/yarn upgrade-interactive
yarn upgrade-interactive v1.1.0
info Color legend :
"<red>" : Major Update backward-incompatible updates
"<yellow>" : Minor Update backward-compatible features
"<green>" : Patch Update backward-compatible bug fixes
? Choose which packages to update. (Press <space> to select, <a> to toggle all, <i> to inverse selection)
devDependencies
name range from to url
>( ) babel-core ^6.24.1 6.24.1 ❯ 6.26.0 https://babeljs.io/
( ) babylon ^6.5.0 6.17.1 ❯ 6.18.0 https://babeljs.io/
( ) eslint ^4.3.0 4.3.0 ❯ 4.7.2 http://eslint.org
( ) eslint-config-fb-strict ^20.1.0-delta.3 20.1.0-delta.3 ❯ 20.1.0-echo.1 https://github.com/facebook/jest#readme
( ) eslint-plugin-babel ^4.0.0 4.1.1 ❯ 4.1.2 https://github.com/babel/eslint-plugin-babel#readme
( ) eslint-plugin-flowtype ^2.35.0 2.35.0 ❯ 2.36.0 https://github.com/gajus/eslint-plugin-flowtype#readme
( ) eslint-plugin-jasmine ^2.6.2 2.6.2 ❯ 2.8.4 https://github.com/tlvince/eslint-plugin-jasmine
( ) eslint-plugin-prettier ^2.1.2 2.1.2 ❯ 2.3.1 https://github.com/prettier/eslint-plugin-prettier#readme
( ) eslint-plugin-react ^7.1.0 7.1.0 ❯ 7.4.0 https://github.com/yannickcr/eslint-plugin-react
( ) eslint-plugin-yarn-internal file:scripts/eslint-rules 0.0.0 ❯ exotic file:scripts/eslint-rules
( ) gulp-sourcemaps ^2.2.0 2.6.0 ❯ 2.6.1 http://github.com/gulp-sourcemaps/gulp-sourcemaps
( ) prettier ^1.5.2 1.5.2 ❯ 1.7.2 https://prettier.io
( ) webpack ^2.1.0-beta.25 2.6.0 ❯ 2.7.0 https://github.com/webpack/webpack
dependencies
name range from to url
( ) babel-runtime ^6.0.0 6.23.0 ❯ 6.26.0 https://github.com/babel/babel/tree/master/packages/babel-runtime
( ) commander ^2.9.0 2.9.0 ❯ 2.11.0 https://github.com/tj/commander.js#readme
( ) debug ^2.2.0 2.6.8 ❯ 2.6.9 https://github.com/visionmedia/debug#readme
( ) gunzip-maybe ^1.4.0 1.4.0 ❯ 1.4.1 https://github.com/mafintosh/gunzip-maybe
( ) inquirer ^3.0.1 3.0.6 ❯ 3.3.0 https://github.com/SBoudrias/Inquirer.js#readme
( ) node-emoji ^1.6.1 1.6.1 ❯ 1.8.1 https://github.com/omnidan/node-emoji#readme
( ) request ^2.81.0 2.81.0 ❯ 2.83.0 https://github.com/request/request#readme
( ) rimraf ^2.5.0 2.6.1 ❯ 2.6.2 https://github.com/isaacs/rimraf#readme
( ) semver ^5.1.0 5.3.0 ❯ 5.4.1 https://github.com/npm/node-semver#readme
( ) tar-fs ^1.15.1 1.15.2 ❯ 1.15.3 https://github.com/mafintosh/tar-fs
( ) uuid ^3.0.1 3.0.1 ❯ 3.1.0 https://github.com/kelektiv/node-uuid#readme
$ ./bin/yarn --version | cat
1.1.0
$
```
And importantly when running the interactive commands through a pipe, it will correctly fail by saying you not are running the interactive commands in a TTY:
```shell
$ ./bin/yarn init | cat
yarn init v1.1.0
error An unexpected error occurred: "Can't answer a question unless a user TTY".
info If you think this is a bug, please open a bug report with the information provided in "D:\\workspace\\yarn\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/init for documentation about this command.
$ ./bin/yarn upgrade-interactive | cat
yarn upgrade-interactive v1.1.0
info Color legend :
"<red>" : Major Update backward-incompatible updates
"<yellow>" : Minor Update backward-compatible features
"<green>" : Patch Update backward-compatible bug fixes
Done in 1.43s.
Error: Can't answer a question unless a user TTY
at D:\workspace\yarn\lib\reporters\console\console-reporter.js:487:31
at Generator.next (<anonymous>)
at step (D:\workspace\yarn\node_modules\babel-runtime\helpers\asyncToGenerator.js:17:30)
at D:\workspace\yarn\node_modules\babel-runtime\helpers\asyncToGenerator.js:35:14
at Promise (<anonymous>)
at F (D:\workspace\yarn\node_modules\core-js\library\modules\_export.js:35:28)
at D:\workspace\yarn\node_modules\babel-runtime\helpers\asyncToGenerator.js:14:12
at ConsoleReporter.prompt (D:\workspace\yarn\lib\reporters\console\console-reporter.js:518:7)
at Object.<anonymous> (D:\workspace\yarn\lib\cli\commands\upgrade-interactive.js:116:38)
at Generator.next (<anonymous>)
```
**Summary**
Fixes#4057.
**Test plan**
CI should pass, especially with `build-dist` job.
Manual:
- Run `yarn build-dist`
- Run `node artifacts/yarn-0.28.0.js --version`
- Run `./dist/bin/yarn --version`
Make sure all above commands work without errors.
**Summary**
Refs #3524. We are using `process.exit()` pretty liberally although it is [strongly advised not to use it](https://nodejs.org/api/process.html#process_process_exit_code) since it may cause the `stdout` to get corrupted/terminated before a full flush. This patch changes all possible `process.exit(code)` calls with `process.exitCode = code` statements.
We'd also ideally enable [no-process-exit](http://eslint.org/docs/rules/no-process-exit) rule in ESLint but it requires an upgrade to ESLint v4 which should be handled separately.
**Test plan**
Expect tests to pass and actually finish (not run indefinitely due to `yarn` not exiting at all). Also, the script referenced in #3524 to output something like the following:
```
DATA 18
DATA 8192
DATA 8192
DATA 5392
DATA 15
EXIT 0
```
Instead of including all the raw JS files in the dist tarball, just use the single Yarn JS file that's built as part of the build, along with a few other files that are required. This significantly reduces the number of files in the tarball:
```
C:\src\yarn\dist (bundle-as-dist) (yarn@0.23.0-0)
λ find .
.
./bin
./bin/node-gyp-bin
./bin/node-gyp-bin/node-gyp
./bin/node-gyp-bin/node-gyp.cmd
./bin/yarn
./bin/yarn.cmd
./bin/yarn.js
./bin/yarnpkg
./bin/yarnpkg.cmd
./lib
./lib/v8-compile-cache.js
./lib/yarn-cli.js
./LICENSE
./package.json
```
There are three .js files in the archive:
- `lib/v8-compile-cache.js`: Speeds up instantiation time by using the V8 code cache (https://www.npmjs.com/package/v8-compile-cache). This needs to be separate as it has to load **before** the bulk of the application code is loaded, so it can **not** be bundled
- `lib/yarn-cli.js`: Contains all the bundled Yarn code
- `bin/yarn.js`: Entry point to the app, just like today. Loads `v8-compile-cache` then loads `yarn-cli`
This change means that **only** the JavaScript files that are actually used are included, resulting in a nice file size reduction for the installation packages:
Differences are due to differing compression algorithms: Debian packages use xz or LZMA, RedHat uses gzip, Windows installer uses Cabinet
They're also slightly faster to extract:
Testing was performed on my desktop computer (Intel Core i5 6500, Samsung 850 Evo 1TB SSD, Windows 10), with testing for Linux stuff (like installing the Debian package) tested in a Docker container.
Raw data: https://docs.google.com/spreadsheets/d/1d8jdf3DU_GUFdotlPl08PkYa8SkzStK2tgnQ54ivsm0/edit?usp=sharing
Performance is very slightly faster when using `v8-compile-cache` along with the bundled file, but it's not extremely significant (`yarn --version` went from 0.19s to 0.14s on my BuyVM server). The difference might be bigger on servers with slower disks (HDD) or with more overloaded servers.
I also deleted the `build-dist.ps1` file because we _should_ be able to assume that Bash is available on Windows, particularly if Git is installed (as it comes with Git Bash). I need to verify that this works on AppVeyor.
* Support interactive commands in standard MINGW as well
Previous fix only supported some old configuration of Git bash
provided by Git for windows, newer Git bash use standard MINGW
which uses a different `uname` but the fix is ultimately the same
Github: #743
* Refactor: use better variable name when determine to use winpty
* Support both MSYS 32bit and 64bit terminal emulators
* Fix self-update
Pick the correct file to download in self-update
We cannot rely that the first asset is always the tar file
This picks the correct file from the assets
Use dev version of roadrunner and reset it correctly
Enable self-update tests
* Remove github resolving from self-update
* Fix tests.
* Update roadrunner and fix tests
* Increase test timeout to 3 minutes
* disable test because to slow on circleCI
* Rename --quick-sloppy flag from `kpm check` to --integrity
* Make --save implicit when installing new modules, remove strict lockfiles, always create updated lockfile and populate tarball cache
* Add integrity hash check to `kpm install`
* Update kpm.lock
* remove incorrect assert messages
* split up package resolving and fetching
* update kpm.lock
* clean up activityStep, move back cursor at end to cover worker lines - fixes#262
* use fake jest timers
* remove old test
* add mocks to jest test ignore
* fix test fixture lockfile
* Add lockfile version header - fixes#280
* split up `kpm install` into `kpm add` - closes#284
* fix lint
* fix using `latest` tag when adding new dependencies - fixes#263
* clean up kpm entry files
* add useless `kpm version` command
* rename config.js to Config.js
* remove Makefile and switch to simple npm scripts
* add more flow-typed definitions
* correctly case Config file
* fix misc lint
* fix type annotation of PackageConstraintResolver#reduce
* fix bin/kpm nits and unused variable
* use dashed filenames instead of camelcase
* move add command fixtures to separate folder
* hoist common-mirror test folder
