kylefang/stacks-puppet-node
1
0
Fork 0
mirror of https://github.com/alexgo-io/stacks-puppet-node.git synced 2026-04-30 12:42:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: only attempt to refresh the signer during the next prepare phase

Browse Source 
This handles the case where for the first block in a cycle (height %
cycle_length == 0), it will report that it is in cycle N, but it will
also report that it is in the prepare phase. This was resulting in
refreshing the signer config too early. For example, with a cycle length
of 20, at block 160, we would see a log:

```
Received a new burnchain block height (160) in the prepare phase of the
next reward cycle (9). Checking for signer registration...
```

This is incorrect, because block 160 is not in the prepare phase for
cycle 9.
This commit is contained in:
Brice Dobry
2024-05-01 10:07:52 -04:00
parent b41019722e
commit af235d0bb7
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
stacks-signer/src/runloop.rs
View File

@@ -89,6 +89,14 @@ impl RewardCycleInfo {
burnchain_block_height,
)
}
/// Check if the provided burnchain block height is in the prepare phase of the next cycle
pub fn is_in_next_prepare_phase(&self, burnchain_block_height: u64) -> bool {
let next_reward_cycle = self.reward_cycle.saturating_add(1);
self.is_in_prepare_phase(burnchain_block_height)
&& self.get_reward_cycle(burnchain_block_height) == next_reward_cycle
}
}
/// The runloop for the stacks signer
@@ -299,7 +307,7 @@ impl RunLoop {
}
let current_reward_cycle = reward_cycle_info.reward_cycle;
// We should only attempt to refresh the signer if we are not configured for the next reward cycle yet and we received a new burn block for its prepare phase
if reward_cycle_info.is_in_prepare_phase(current_burn_block_height) {
if reward_cycle_info.is_in_next_prepare_phase(current_burn_block_height) {
let next_reward_cycle = current_reward_cycle.saturating_add(1);
if self
.stacks_signers