kylefang/stacks-puppet-node
1
0
Fork 0
mirror of https://github.com/alexgo-io/stacks-puppet-node.git synced 2026-04-29 12:15:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Seperate unsigned and signed transaction building and update tests

Browse Source 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
This commit is contained in:
Jacinta Ferrant
2024-03-22 17:31:40 -04:00
parent 7a970ac37f
commit abfc68a3a3
3 changed files with 66 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
testnet/stacks-node/src/tests/signer.rs
View File

@@ -549,7 +549,7 @@ impl SignerTest {
None,
),
};
let invalid_contract_address = StacksClient::build_signed_contract_call_transaction(
let invalid_contract_address = StacksClient::build_unsigned_contract_call_transaction(
&StacksAddress::p2pkh(false, &StacksPublicKey::from_private(&signer_private_key)),
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -558,11 +558,10 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_contract_name = StacksClient::build_signed_contract_call_transaction(
let invalid_contract_name = StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
"bad-signers-contract-name".into(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -571,11 +570,10 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_signers_vote_function = StacksClient::build_signed_contract_call_transaction(
let invalid_signers_vote_function = StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
"some-other-function".into(),
@@ -584,12 +582,11 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_function_arg_signer_index =
StacksClient::build_signed_contract_call_transaction(
StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -603,11 +600,10 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_function_arg_key = StacksClient::build_signed_contract_call_transaction(
let invalid_function_arg_key = StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -621,11 +617,10 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_function_arg_round = StacksClient::build_signed_contract_call_transaction(
let invalid_function_arg_round = StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -639,12 +634,11 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_function_arg_reward_cycle =
StacksClient::build_signed_contract_call_transaction(
StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -658,11 +652,10 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
1,
10,
)
.unwrap();
let invalid_nonce = StacksClient::build_signed_contract_call_transaction(
let invalid_nonce = StacksClient::build_unsigned_contract_call_transaction(
&contract_addr,
contract_name.clone(),
SIGNERS_VOTING_FUNCTION_NAME.into(),
@@ -671,7 +664,6 @@ impl SignerTest {
TransactionVersion::Testnet,
CHAIN_ID_TESTNET,
0, // Old nonce
10,
)
.unwrap();
@@ -682,10 +674,10 @@ impl SignerTest {
false,
);
let invalid_signer_tx = invalid_stacks_client
.build_vote_for_aggregate_public_key(0, round, point, reward_cycle, None, 0)
.build_unsigned_vote_for_aggregate_public_key(0, round, point, reward_cycle, 0)
.expect("FATAL: failed to build vote for aggregate public key");
vec![
let unsigned_txs = vec![
invalid_nonce,
invalid_not_contract_call,
invalid_contract_name,
@@ -696,7 +688,15 @@ impl SignerTest {
invalid_function_arg_round,
invalid_function_arg_signer_index,
invalid_signer_tx,
]
];
unsigned_txs
.into_iter()
.map(|unsigned| {
invalid_stacks_client
.sign_transaction(unsigned)
.expect("Failed to sign transaction")
})
.collect()
}
/// Kills the signer runloop at index `signer_idx`