From 7eebde0e795652861b482259916bdb9e6bd3f205 Mon Sep 17 00:00:00 2001
From: BowTiedDevOps <157840260+BowTiedDevOps@users.noreply.github.com>
Date: Tue, 16 Jul 2024 15:31:32 +0300
Subject: [PATCH] update: ci - remove redundant lines, negate expression

---
 .github/workflows/ci.yml | 68 ++++++++++++++++++----------------------
 1 file changed, 31 insertions(+), 37 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2303e8865..d1ae65226 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -92,7 +92,7 @@ jobs:
   ##  - it is not a release run
   docker-image:
     if: |
-      needs.check-release.outputs.is_release == 'false'
+      needs.check-release.outputs.is_release != 'true'
     name: Docker Image (Source)
     uses: ./.github/workflows/image-build-source.yml
     needs:
@@ -113,18 +113,16 @@ jobs:
   create-cache:
     if: |
       needs.check-release.outputs.is_release == 'true' || (
-        needs.check-release.outputs.is_release == 'false' && (
-          github.event_name == 'workflow_dispatch' ||
-          github.event_name == 'pull_request' ||
-          github.event_name == 'merge_group' ||
-          (
-            contains('
-              refs/heads/master
-              refs/heads/develop
-              refs/heads/next
-            ', github.event.pull_request.head.ref) &&
-            github.event_name == 'push'
-          )
+        github.event_name == 'workflow_dispatch' ||
+        github.event_name == 'pull_request' ||
+        github.event_name == 'merge_group' ||
+        (
+          contains('
+            refs/heads/master
+            refs/heads/develop
+            refs/heads/next
+          ', github.event.pull_request.head.ref) &&
+          github.event_name == 'push'
         )
       )
     name: Create Test Cache
@@ -147,18 +145,16 @@ jobs:
   stacks-core-tests:
     if: |
       needs.check-release.outputs.is_release == 'true' || (
-        needs.check-release.outputs.is_release == 'false' && (
-          github.event_name == 'workflow_dispatch' ||
-          github.event_name == 'pull_request' ||
-          github.event_name == 'merge_group' ||
-          (
-            contains('
-              refs/heads/master
-              refs/heads/develop
-              refs/heads/next
-            ', github.event.pull_request.head.ref) &&
-            github.event_name == 'push'
-          )
+        github.event_name == 'workflow_dispatch' ||
+        github.event_name == 'pull_request' ||
+        github.event_name == 'merge_group' ||
+        (
+          contains('
+            refs/heads/master
+            refs/heads/develop
+            refs/heads/next
+          ', github.event.pull_request.head.ref) &&
+          github.event_name == 'push'
         )
       )
     name: Stacks Core Tests
@@ -171,18 +167,16 @@ jobs:
   bitcoin-tests:
     if: |
       needs.check-release.outputs.is_release == 'true' || (
-        needs.check-release.outputs.is_release == 'false' && (
-          github.event_name == 'workflow_dispatch' ||
-          github.event_name == 'pull_request' ||
-          github.event_name == 'merge_group' ||
-          (
-            contains('
-              refs/heads/master
-              refs/heads/develop
-              refs/heads/next
-            ', github.event.pull_request.head.ref) &&
-            github.event_name == 'push'
-          )
+        github.event_name == 'workflow_dispatch' ||
+        github.event_name == 'pull_request' ||
+        github.event_name == 'merge_group' ||
+        (
+          contains('
+            refs/heads/master
+            refs/heads/develop
+            refs/heads/next
+          ', github.event.pull_request.head.ref) &&
+          github.event_name == 'push'
         )
       )
     name: Bitcoin Tests