From 7ac58c2e0854f651ccc64ae7253e51906c25d43c Mon Sep 17 00:00:00 2001
From: Nathan Weizenbaum <nex342@gmail.com>
Date: Thu, 16 Oct 2014 18:10:56 -0700
Subject: [PATCH] Fix a crash for @for loops.

Closes #1468
---
 doc-src/SASS_CHANGELOG.md       |  2 ++
 lib/sass/script/value/number.rb |  2 +-
 test/sass/scss/scss_test.rb     | 28 ++++++++++++++++++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/doc-src/SASS_CHANGELOG.md b/doc-src/SASS_CHANGELOG.md
index da5fbce1..6387e92c 100644
--- a/doc-src/SASS_CHANGELOG.md
+++ b/doc-src/SASS_CHANGELOG.md
@@ -7,6 +7,8 @@
 
 * Parent selectors now work in selector pseudoclasses (for example, `:not(&)`).
 
+* `@for` loops no longer crash when one bound is an integer-like float.
+
 ## 3.4.5 (19 September 2014)
 
 * Fix `sass-convert --recursive`.
diff --git a/lib/sass/script/value/number.rb b/lib/sass/script/value/number.rb
index 4abb4c80..031a6e75 100644
--- a/lib/sass/script/value/number.rb
+++ b/lib/sass/script/value/number.rb
@@ -289,7 +289,7 @@ module Sass::Script::Value
     # @raise [Sass::SyntaxError] if the number isn't an integer
     def to_i
       super unless int?
-      value
+      value.to_i
     end
 
     # @return [Boolean] Whether or not this number is an integer.
diff --git a/test/sass/scss/scss_test.rb b/test/sass/scss/scss_test.rb
index 535ae277..e02c2aa9 100755
--- a/test/sass/scss/scss_test.rb
+++ b/test/sass/scss/scss_test.rb
@@ -3570,6 +3570,34 @@ SCSS
 
   # Regression
 
+  def test_for_directive_with_float_bounds
+    assert_equal(<<CSS, render(<<SCSS))
+.a {
+  b: 0;
+  b: 1;
+  b: 2;
+  b: 3;
+  b: 4;
+  b: 5; }
+CSS
+.a {
+  @for $i from 0.0 through 5.0 {b: $i}
+}
+SCSS
+
+    assert_raise_message(Sass::SyntaxError, "0.5 is not an integer.") {render(<<SCSS)}
+.a {
+  @for $i from 0.5 through 5.0 {b: $i}
+}
+SCSS
+
+    assert_raise_message(Sass::SyntaxError, "5.5 is not an integer.") {render(<<SCSS)}
+.a {
+  @for $i from 0.0 through 5.5 {b: $i}
+}
+SCSS
+  end
+
   def test_parent_selector_in_function_pseudo_selector
     assert_equal <<CSS, render(<<SCSS)
 .bar:not(.foo) {