From b4259d719611ce5ad64f70541eb0b4998745ebc2 Mon Sep 17 00:00:00 2001 From: Mark Rickert Date: Thu, 1 Jan 2015 22:28:19 -0500 Subject: [PATCH] Adds deprecation warning capabilities. No tests here... move along please. --- motion/ruby_motion_query/deprecation.rb | 7 +++++++ .../stylers/ui_view_styler.rb | 19 +++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 motion/ruby_motion_query/deprecation.rb diff --git a/motion/ruby_motion_query/deprecation.rb b/motion/ruby_motion_query/deprecation.rb new file mode 100644 index 0000000..93f0210 --- /dev/null +++ b/motion/ruby_motion_query/deprecation.rb @@ -0,0 +1,7 @@ +module RubyMotionQuery + class Deprecation + def self.warn(method_called, message = nil) + puts "[RMQ Warning] The `#{method_called}` method has been deprecated and will be removed in a future version of RMQ. #{message}" if rmq.device.simulator? + end + end +end diff --git a/motion/ruby_motion_query/stylers/ui_view_styler.rb b/motion/ruby_motion_query/stylers/ui_view_styler.rb index aa9f727..7a24063 100644 --- a/motion/ruby_motion_query/stylers/ui_view_styler.rb +++ b/motion/ruby_motion_query/stylers/ui_view_styler.rb @@ -314,6 +314,7 @@ module RubyMotionQuery # @deprecated - use frame hashs def left=(value) + Deprecation.warn(:left=, "Set `left` with the frame hash.") f = @view.frame f.origin.x = value @view.frame = f @@ -321,6 +322,7 @@ module RubyMotionQuery # @deprecated - use st.frame.left def left + Deprecation.warn(:left, "Use `st.frame.left`.") @view.origin.x end @@ -329,6 +331,7 @@ module RubyMotionQuery # @deprecated - use frame hash def top=(value) + Deprecation.warn(:top=, "Set `top` with the frame hash.") f = @view.frame f.origin.y = value @view.frame = f @@ -336,6 +339,7 @@ module RubyMotionQuery # @deprecated - use st.frame.top def top + Deprecation.warn(:top, "Use `st.frame.top`.") @view.origin.y end @@ -344,6 +348,7 @@ module RubyMotionQuery # @deprecated - use frame hash def width=(value) + Deprecation.warn(:width=, "Set `width` with the frame hash.") f = @view.frame f.size.width = value @view.frame = f @@ -351,11 +356,13 @@ module RubyMotionQuery # @deprecated - use st.frame.width def width + Deprecation.warn(:width, "Use `st.frame.width`.") @view.size.width end # @deprecated - use frame hash def height=(value) + Deprecation.warn(:height=, "Set `height` with the frame hash.") f = @view.frame f.size.height = value @view.frame = f @@ -363,21 +370,25 @@ module RubyMotionQuery # @deprecated - use st.frame.height def height + Deprecation.warn(:height, "Use `st.frame.height`.") @view.size.height end # @deprecated - use frame hash def bottom=(value) + Deprecation.warn(:bottom=, "Set `bottom` with the frame hash.") self.top = value - self.height end # @deprecated - st.frame.bottom def bottom + Deprecation.warn(:bottom, "Use `st.frame.bottom`.") self.top + self.height end # @deprecated - use frame hash def from_bottom=(value) + Deprecation.warn(:from_bottom=, "Set `from_bottom` with the frame hash.") if sv = @view.superview self.top = sv.bounds.size.height - self.height - value end @@ -385,6 +396,7 @@ module RubyMotionQuery # @deprecated - st.frame.from_bottom def from_bottom + Deprecation.warn(:from_bottom, "Use `st.frame.from_bottom`.") if sv = @view.superview sv.bounds.size.height - self.top end @@ -392,16 +404,19 @@ module RubyMotionQuery # @deprecated - use frame hash def right=(value) + Deprecation.warn(:right=, "Set `right` with the frame hash.") self.left = value - self.width end # @deprecated - st.frame.right def right + Deprecation.warn(:right, "Use `st.frame.right`.") self.left + self.width end # @deprecated - use frame hash def from_right=(value) + Deprecation.warn(:from_right=, "Set `from_right` with the frame hash.") if superview = @view.superview self.left = superview.bounds.size.width - self.width - value end @@ -409,6 +424,7 @@ module RubyMotionQuery # @deprecated - st.frame.from_right def from_right + Deprecation.warn(:from_right, "Use `st.frame.from_right`.") if superview = @view.superview superview.bounds.size.width - self.left end @@ -417,6 +433,7 @@ module RubyMotionQuery # @deprecated - use frame hash # param can be :horizontal, :vertical, :both def centered=(option) + Deprecation.warn(:centered=, "Use the frame hash to center a view.") if parent = @view.superview case option when :horizontal @@ -430,8 +447,6 @@ module RubyMotionQuery end end - - private def is_color(value)