From d169ab17948ab1183dcb8c90ac64cb1cceaaf88a Mon Sep 17 00:00:00 2001 From: Gant Date: Thu, 12 Mar 2015 22:31:31 -0500 Subject: [PATCH 1/3] adding a friendly alias for text_alignment --- motion/ruby_motion_query/stylers/ui_label_styler.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/motion/ruby_motion_query/stylers/ui_label_styler.rb b/motion/ruby_motion_query/stylers/ui_label_styler.rb index 6d514ae..eee35e7 100644 --- a/motion/ruby_motion_query/stylers/ui_label_styler.rb +++ b/motion/ruby_motion_query/stylers/ui_label_styler.rb @@ -41,6 +41,8 @@ module RubyMotionQuery def text_alignment @view.textAlignment end + alias :text_align= :text_alignment= + alias :text_align :text_alignment def resize_to_fit_text @view.sizeToFit From 5ebfafeaf97b2a8ad373ce7fc70bded2ca6161f3 Mon Sep 17 00:00:00 2001 From: Gant Date: Thu, 12 Mar 2015 22:35:38 -0500 Subject: [PATCH 2/3] text_align testing --- spec/stylers/ui_label_styler.rb | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/spec/stylers/ui_label_styler.rb b/spec/stylers/ui_label_styler.rb index 41d3edf..8b1e291 100644 --- a/spec/stylers/ui_label_styler.rb +++ b/spec/stylers/ui_label_styler.rb @@ -21,6 +21,11 @@ class StyleSheetForUIViewStylerTests < RubyMotionQuery::Stylesheet st.text_alignment = :centered end + def ui_label_text_align(st) + ui_label_kitchen_sink(st) + st.text_align = :left + end + def ui_label_attributed_string(st) st.attributed_text = NSAttributedString.alloc.initWithString("RMQ") end @@ -64,6 +69,14 @@ describe 'stylers/ui_label' do end end + it 'should use text_align as an alias for ui_label_text_align' do + view = @vc.rmq.append(@view_klass, :ui_label_text_align).get + + view.tap do |v| + v.textAlignment.should == NSTextAlignmentLeft + end + end + it "applies an attributed string" do view = @vc.rmq.append(@view_klass, :ui_label_attributed_string).get From 906fe65ffb684271fc28e157e32c264d061b1148 Mon Sep 17 00:00:00 2001 From: Gant Date: Fri, 13 Mar 2015 09:14:31 -0500 Subject: [PATCH 3/3] text align changed to be non-default as per rickert --- spec/stylers/ui_label_styler.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/stylers/ui_label_styler.rb b/spec/stylers/ui_label_styler.rb index 8b1e291..de88084 100644 --- a/spec/stylers/ui_label_styler.rb +++ b/spec/stylers/ui_label_styler.rb @@ -23,7 +23,7 @@ class StyleSheetForUIViewStylerTests < RubyMotionQuery::Stylesheet def ui_label_text_align(st) ui_label_kitchen_sink(st) - st.text_align = :left + st.text_align = :right end def ui_label_attributed_string(st) @@ -73,7 +73,7 @@ describe 'stylers/ui_label' do view = @vc.rmq.append(@view_klass, :ui_label_text_align).get view.tap do |v| - v.textAlignment.should == NSTextAlignmentLeft + v.textAlignment.should == NSTextAlignmentRight end end