From fcee54c729f81fd8bcabb3d69ffd177cc4bae69d Mon Sep 17 00:00:00 2001 From: jacobawenger Date: Sat, 13 Sep 2014 15:56:34 -0700 Subject: [PATCH] Travis now fails build if linting fails --- gulpfile.js | 15 +++++++++++++-- package.json | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index d104910..a96c09a 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -12,6 +12,10 @@ var uglify = require("gulp-uglify"); // Testing var karma = require("gulp-karma"); +// Determine if this is being run in Travis +var travis = (process.argv.indexOf('--travis') > -1); + + /****************/ /* FILE PATHS */ /****************/ @@ -47,6 +51,7 @@ var paths = { } }; + /***********/ /* TASKS */ /***********/ @@ -66,6 +71,12 @@ gulp.task("scripts", function() { // Lint .pipe(jshint()) .pipe(jshint.reporter("jshint-stylish")) + .pipe(jshint.reporter("fail")) + .on("error", function(error) { + if (travis) { + throw error; + } + }) // Write un-minified version .pipe(gulp.dest(paths.scripts.dest.dir)) @@ -89,8 +100,8 @@ gulp.task("test", function() { configFile: paths.tests.config, action: "run" })) - .on("error", function(err) { - throw err; + .on("error", function(error) { + throw error; }); }); diff --git a/package.json b/package.json index 823f802..e7b0508 100644 --- a/package.json +++ b/package.json @@ -54,6 +54,6 @@ }, "scripts": { "test": "gulp test", - "travis": "gulp" + "travis": "gulp --travis" } }